Formularium\Formularium

Complexity

Total Complexity

9

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Test Coverage

Coverage

94.44%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	graphqlDirectives()	0	39	3
A	getDatatypeValidators()	0	15	3
A	getDatatypeNames()	0	18	3

<?php declare(strict_types=1);

namespace Formularium;

/**
 * Abstract base class for frameworks. Each framework should have a class inheriting
 * from this class.
 */
class Formularium
{
    /**
     * Returns a list of datatype class names
     *
     * @return array
     */
    public static function getDatatypeNames(): array
    {
        $datatypes = array_map(
            function ($x) {
                return str_replace('Datatype_', '', str_replace('.php', '', $x));
            },
            array_diff(scandir(__DIR__ . '/Datatype/'), array('.', '..'))

It seems like scandir(__DIR__ . '/Datatype/') can also be of type false; however, parameter $array1 of array_diff() does only seem to accept array, maybe add an additional type check?

        );
    
        // TODO: avoid abstract classes
        $datatypes = array_filter(
            $datatypes,
            function ($t) {
                return ($t !== 'number' && $t !== 'choice' && $t !== 'association');
            }
        );

        return $datatypes;
    }

    public static function getDatatypeValidators(array $extraDatatypes = []): array
    {
        $datatypes = self::getDatatypeNames();

        $validators = [];

        foreach ($datatypes as $name) {
            $datatype = Datatype::factory($name);
            $validators = array_merge($validators, $datatype->getValidatorMetadata());
        }
        foreach ($extraDatatypes as $name) {
            $datatype = Datatype::factory($name);
            $validators = array_merge($validators, $datatype->getValidatorMetadata());
        }
        return $validators;
    }

    public static function graphqlDirectives(array $extraDatatypes = []): string
    {
        $validators = static::getDatatypeValidators($extraDatatypes);

        foreach ($validators as $name => $v) {
            $args = array_map(
                function ($a) {
                    return <<<EOF
    """
    {$a['comment']}
    """
    {$a['name']}: {$a['type']}

EOF;
                },
                $v['args']
            );

            $argString = '';
            if ($args) {

The expression $args of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $argString = "(\n" . join("\n", $args) . ')';
            }
            $graphql[$name] = <<< EOF
"""
{$v['comment']}
"""
directive @{$name}{$argString} on FIELD_DEFINITION

EOF;
        }

        unset($graphql['required']); // ! already does this


        return '
# File generated by Formularium.
# Do not edit this file directly.

' . join("\n", $graphql);

The variable $graphql seems to be defined by a foreach iteration on line 57. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }
}