Corollarium /
Formularium
| Conditions | 6 |
| Paths | 13 |
| Total Lines | 51 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 14 | public function render(array $parameters, HTMLNode $previous): HTMLNode |
||
| 15 | { |
||
| 16 | $previous->setTag('b-button'); |
||
| 17 | |||
| 18 | $color = $parameters[HTMLButton::COLOR] ?? ''; |
||
| 19 | $colorMap = [ |
||
| 20 | HTMLButton::COLOR_PRIMARY => 'is-primary', |
||
| 21 | HTMLButton::COLOR_LINK => 'is-link', |
||
| 22 | HTMLButton::COLOR_INFO => 'is-info', |
||
| 23 | HTMLButton::COLOR_SUCCESS => 'is-success', |
||
| 24 | HTMLButton::COLOR_WARNING => 'is-warning', |
||
| 25 | HTMLButton::COLOR_ERROR => 'is-error', |
||
| 26 | ]; |
||
| 27 | |||
| 28 | if (array_key_exists($color, $colorMap)) { |
||
| 29 | $color = $parameters[HTMLButton::COLOR]; |
||
| 30 | } else { |
||
| 31 | $colors = [ |
||
| 32 | 'is-primary', |
||
| 33 | 'is-success', |
||
| 34 | 'is-danger', |
||
| 35 | 'is-warning', |
||
| 36 | 'is-info', |
||
| 37 | 'is-light', |
||
| 38 | 'is-dark', |
||
| 39 | 'is-link', |
||
| 40 | 'is-black', |
||
| 41 | 'is-white', |
||
| 42 | ]; |
||
| 43 | if (!in_array($color, $colors)) { |
||
| 44 | throw new Exception('Invalid button color.'); |
||
| 45 | } |
||
| 46 | } |
||
| 47 | $previous->addAttribute('type', $color); |
||
| 48 | |||
| 49 | $size = $parameters[self::SIZE] ?? ''; |
||
| 50 | switch ($size) { |
||
| 51 | case self::SIZE_LARGE: |
||
| 52 | $previous->addAttribute('size', 'is-large'); |
||
| 53 | break; |
||
| 54 | case self::SIZE_SMALL: |
||
| 55 | $previous->addAttribute('size', 'is-small'); |
||
| 56 | break; |
||
| 57 | } |
||
| 58 | |||
| 59 | $icon = $parameters[self::ICON] ?? ''; |
||
| 60 | if ($icon) { |
||
| 61 | $previous->addAttribute('icon-left', $icon); |
||
| 62 | } |
||
| 63 | |||
| 64 | return $previous; |
||
| 65 | } |
||
| 80 |
