Renderable::viewable() - Code Metrics - Inspection of "moving validation to a separate adapter fix #26" - Corollarium/Formularium - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4ada59...3080fc )

by Bruno

created 2020-10-22 17:27 UTC

Renderable::viewable() A

↳ Parent: Renderable

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	1
f	0
nc	1
nop	3
dl	0
loc	3
rs	10

<?php declare(strict_types=1);

namespace Formularium\Frontend\HTMLValidation;

use Formularium\Field;
use Formularium\HTMLNode;
use Formularium\Validator\MaxLength;
use Formularium\Validator\MinLength;
use Formularium\Validator\Regex;

class Renderable extends \Formularium\Renderable
{
    public function viewable($value, Field $field, HTMLNode $previous): HTMLNode
    {
        return $previous;
    }

    public function editable($value, Field $field, HTMLNode $previous): HTMLNode
    {
        $validators = $field->getValidators();

        $element = $this->getInput($previous);
        if (!$element) {

            return $previous;
        }

        $datatype = $field->getDatatype();


        foreach ($validators as $validator => $data) {
            switch ($validator) {
            case MinLength::class:
                $element->setAttribute('minlength', $field->getValidatorOption($validator, 'value', ''));
                break;
            case MaxLength::class:
                $element->setAttribute('maxlength', $field->getValidatorOption($validator, 'value', ''));
                break;
            case Regex::class:
                $element->setAttribute('pattern', $field->getValidatorOption($validator, 'value', ''));
                break;
            default:
                break;
            }
        }

        return $previous;
    }

    protected function getInput(HTMLNode $previous): ?HTMLNode
    {
        /**
         * @var HTMLNode $element
         */
        $element = null;
        $input = $previous->get('input');
        if (count($input)) {
            return $input[0];
        }
        $input = $previous->get('textarea');
        if (count($input)) {
            $element = $input[0];
        }
        return $element;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Formularium\Frontend\HTMLValidation;
4
5			use Formularium\Field;
6			use Formularium\HTMLNode;
7			use Formularium\Validator\MaxLength;
8			use Formularium\Validator\MinLength;
9			use Formularium\Validator\Regex;
10
11			class Renderable extends \Formularium\Renderable
12			{
13			public function viewable($value, Field $field, HTMLNode $previous): HTMLNode
14			{
15			return $previous;
16			}
17
18			public function editable($value, Field $field, HTMLNode $previous): HTMLNode
19			{
20			$validators = $field->getValidators();
21
22			$element = $this->getInput($previous);
23			if (!$element) {
			0 ignored issues – show introduced 2020-10-22 17:37 UTC by Report Bug Copy Issue Report `$element` is of type `Formularium\HTMLNode`, thus it always evaluated to `true`. Loading history...
24			return $previous;
25			}
26
27			$datatype = $field->getDatatype();
			0 ignored issues – show Unused Code introduced 2020-10-22 17:37 UTC by Report Bug Copy Issue Report The assignment to `$datatype` is dead and can be removed. Loading history...
28
29			foreach ($validators as $validator => $data) {
30			switch ($validator) {
31			case MinLength::class:
32			$element->setAttribute('minlength', $field->getValidatorOption($validator, 'value', ''));
33			break;
34			case MaxLength::class:
35			$element->setAttribute('maxlength', $field->getValidatorOption($validator, 'value', ''));
36			break;
37			case Regex::class:
38			$element->setAttribute('pattern', $field->getValidatorOption($validator, 'value', ''));
39			break;
40			default:
41			break;
42			}
43			}
44
45			return $previous;
46			}
47
48			protected function getInput(HTMLNode $previous): ?HTMLNode
49			{
50			/**
51			* @var HTMLNode $element
52			*/
53			$element = null;
54			$input = $previous->get('input');
55			if (count($input)) {
56			return $input[0];
57			}
58			$input = $previous->get('textarea');
59			if (count($input)) {
60			$element = $input[0];
61			}
62			return $element;
63			}
64			}
65

Corollarium / Formularium

Push — master ( 4ada59...3080fc )

Renderable::viewable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like