GlobeLabsSmsMessage::getApiSendUrl() - Code Metrics - Inspection of "Initial commit for a working version" - CoreProc/laravel-notification-channel-globe-labs-sms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Chris

created 2018-05-05 17:37 UTC

GlobeLabsSmsMessage::getApiSendUrl() A

↳ Parent: GlobeLabsSmsMessage

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Coreproc\GlobeLabsSms;

use Exception;
use Coreproc\MsisdnPh\Msisdn;
use Coreproc\GlobeLabsSms\Exceptions\CouldNotSendNotification;

class GlobeLabsSmsMessage
{
    protected $message;

    protected $clientCorrelator;

    protected $accessToken;

    protected $address;

    protected $globeLabsSmsApiSendUrl = 'https://devapi.globelabs.com.ph/smsmessaging/v1/outbound/{senderAddress}/requests?access_token={accessToken}';

    public static function create($notifiable)
    {
        $instance = new static();

        $info = $notifiable->routeNotificationFor('globeLabsSms');

        $instance->setAddress($info['address']);
        $instance->setAccessToken($info['access_token']);

        return $instance;
    }

    public function getApiSendUrl()
    {
        // The URL should have the {senderAddress} and {accessToken} values embedded in the string so we can replace
        // this with the correct values.
        $url = config('broadcasting.connections.globe_labs_sms.api_send_url', $this->globeLabsSmsApiSendUrl);

        $url = str_replace('{senderAddress}', $this->getSenderAddress(), $url);
        $url = str_replace('{accessToken}', $this->getAccessToken(), $url);

        return $url;
    }

    public function getSenderAddress()
    {
        return substr(config('broadcasting.connections.globe_labs_sms.short_code'), -4);
    }

    public function getAccessToken()
    {
        return $this->accessToken;
    }

    public function setAccessToken($accessToken)
    {
        $this->accessToken = $accessToken;

        return $this;
    }

    public function getAddress()
    {
        try {
            $msisdn = new Msisdn($this->address);
        } catch (Exception $e) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($e->getMessage());
        }

        return 'tel:'.$msisdn->get(true);
    }

    public function setAddress($address)
    {
        $this->address = $address;

        return $this;
    }

    public function getClientCorrelator()
    {
        return $this->clientCorrelator;
    }

    public function setClientCorrelator($clientCorrelator)
    {
        $this->clientCorrelator = $clientCorrelator;

        return $this;
    }

    public function getMessage()
    {
        return $this->message;
    }

    public function setMessage($message)
    {
        $this->message = $message;

        return $this;
    }

    public function toJson()
    {
        $request['outboundSMSMessageRequest']['address'] = $this->getAddress();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $request['outboundSMSMessageRequest']['senderAddress'] = $this->getSenderAddress();

        if (! empty($this->getClientCorrelator())) {
            $request['outboundSMSMessageRequest']['clientCorrelator'] = $this->getClientCorrelator();
        }

        $request['outboundSMSMessageRequest']['outboundSMSTextMessage']['message'] = $this->getMessage();

        return json_encode($request);
    }
}


1			<?php
2
3			namespace Coreproc\GlobeLabsSms;
4
5			use Exception;
6			use Coreproc\MsisdnPh\Msisdn;
7			use Coreproc\GlobeLabsSms\Exceptions\CouldNotSendNotification;
8
9			class GlobeLabsSmsMessage
10			{
11			protected $message;
12
13			protected $clientCorrelator;
14
15			protected $accessToken;
16
17			protected $address;
18
19			protected $globeLabsSmsApiSendUrl = 'https://devapi.globelabs.com.ph/smsmessaging/v1/outbound/{senderAddress}/requests?access_token={accessToken}';
20
21			public static function create($notifiable)
22			{
23			$instance = new static();
24
25			$info = $notifiable->routeNotificationFor('globeLabsSms');
26
27			$instance->setAddress($info['address']);
28			$instance->setAccessToken($info['access_token']);
29
30			return $instance;
31			}
32
33			public function getApiSendUrl()
34			{
35			// The URL should have the {senderAddress} and {accessToken} values embedded in the string so we can replace
36			// this with the correct values.
37			$url = config('broadcasting.connections.globe_labs_sms.api_send_url', $this->globeLabsSmsApiSendUrl);
38
39			$url = str_replace('{senderAddress}', $this->getSenderAddress(), $url);
40			$url = str_replace('{accessToken}', $this->getAccessToken(), $url);
41
42			return $url;
43			}
44
45			public function getSenderAddress()
46			{
47			return substr(config('broadcasting.connections.globe_labs_sms.short_code'), -4);
48			}
49
50			public function getAccessToken()
51			{
52			return $this->accessToken;
53			}
54
55			public function setAccessToken($accessToken)
56			{
57			$this->accessToken = $accessToken;
58
59			return $this;
60			}
61
62			public function getAddress()
63			{
64			try {
65			$msisdn = new Msisdn($this->address);
66			} catch (Exception $e) {
67			throw CouldNotSendNotification::serviceRespondedWithAnError($e->getMessage());
68			}
69
70			return 'tel:'.$msisdn->get(true);
71			}
72
73			public function setAddress($address)
74			{
75			$this->address = $address;
76
77			return $this;
78			}
79
80			public function getClientCorrelator()
81			{
82			return $this->clientCorrelator;
83			}
84
85			public function setClientCorrelator($clientCorrelator)
86			{
87			$this->clientCorrelator = $clientCorrelator;
88
89			return $this;
90			}
91
92			public function getMessage()
93			{
94			return $this->message;
95			}
96
97			public function setMessage($message)
98			{
99			$this->message = $message;
100
101			return $this;
102			}
103
104			public function toJson()
105			{
106			$request['outboundSMSMessageRequest']['address'] = $this->getAddress();
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-05-05 17:38 UTC by Report Bug Copy Issue Report `$request` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$request = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
107			$request['outboundSMSMessageRequest']['senderAddress'] = $this->getSenderAddress();
108
109			if (! empty($this->getClientCorrelator())) {
110			$request['outboundSMSMessageRequest']['clientCorrelator'] = $this->getClientCorrelator();
111			}
112
113			$request['outboundSMSMessageRequest']['outboundSMSTextMessage']['message'] = $this->getMessage();
114
115			return json_encode($request);
116			}
117			}
118

CoreProc / laravel-notification-channel-globe-labs-sms

Pull Request — master (#1)

GlobeLabsSmsMessage::getApiSendUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like