CorWatts / fasterscale

common/models/LoginForm.php

<?php
namespace common\models;

use Yii;
use yii\base\Model;

/**
 * Login form
 */
class LoginForm extends Model
{
  public $email;
  public $password;
  public $rememberMe = true;

  private $user = false;
  private $tmp_user;

  public function __construct(\common\interfaces\UserInterface $user, $config = []) {
    $this->tmp_user = $user;
    parent::__construct($config);
  }

  /**
   * @inheritdoc
   */
  public function rules()
  {
    return [
      // email and password are both required
      ['email', 'filter', 'filter' => 'trim'],
      ['email', 'filter', 'filter' => 'strtolower'],
      [['email', 'password'], 'required'],
      ['email', 'email'],
      // rememberMe must be a boolean value
      ['rememberMe', 'boolean'],
      // password is validated by validatePassword()
      ['password', 'validatePassword'],
    ];
  }

  /**
   * Validates the password.
   * This method serves as the inline validation for password.
   */
  public function validatePassword()
  {
    if (!$this->hasErrors()) {
      $user = $this->getUser();
      if (!$user || !$user->validatePassword($this->password)) {
        $this->addError('password', 'Incorrect email or password.');
      }
    }
  }

  /**
   * Logs in a user using the provided email and password.
   *
   * @return boolean whether the user is logged in successfully
   */
  public function login()
  {
    if($this->validate()) {
      $user = $this->getUser();
      if($user->isVerified()) {
        return Yii::$app->user->login($user, $this->rememberMe ? 3600 * 24 * 30 : 0);

The method login() does not exist on null.

It seems like $user can also be of type null; however, parameter $identity of yii\web\User::login() does only seem to accept yii\web\IdentityInterface, maybe add an additional type check?

      } else {
        Yii::$app->session->setFlash('warning', 'You must verify your account before you can proceed. Please check your email inbox for a verification email and follow the instructions.');

The method setFlash() does not exist on null.

      }
    }
    return false;
  }

  /**
   * Finds user by [[email]]
   *
   * @return User|null
   */
  public function getUser()
  {
    if ($this->user === false) {
      $this->user = $this->tmp_user->findByEmail($this->email);
    }

    return $this->user;
  }
}