site\controllers\SiteController

Complexity

Total Complexity

42

Size/Duplication

Total Lines	250
Duplicated Lines	0 %

Importance

Changes

0

17 Methods

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	0	14	2
B	actionRequestPasswordReset()	0	15	5
A	actionAbout()	0	3	1
B	behaviors()	0	26	1
A	actionSignup()	0	11	3
B	actionVerifyEmail()	0	19	6
A	actionWelcome()	0	3	1
A	actionLogin()	0	8	3
B	actionResetPassword()	0	17	5
A	actions()	0	8	1
A	actionFaq()	0	3	1
A	actionLogout()	0	4	1
A	actionContact()	0	14	4
A	actionTerms()	0	3	1
A	actionChangeEmail()	0	19	4
B	actionExport()	0	27	2
A	actionPrivacy()	0	3	1

<?php

namespace site\controllers;

use Yii;
use common\models\LoginForm;
use common\models\Question;
use site\models\PasswordResetRequestForm;
use site\models\ResetPasswordForm;
use site\models\ContactForm;
use yii\base\InvalidParamException;
use yii\web\BadRequestHttpException;
use yii\web\Controller;
use yii\filters\VerbFilter;
use common\components\AccessControl;

/**
 * Site controller
 */
class SiteController extends Controller
{
  /**
   * @inheritdoc
   */
  public function behaviors()
  {
    return [
      'access' => [
        'class' => AccessControl::class,
        'rules' => [
          [
            'actions' => ['index', 'error', 'privacy', 'terms', 'about', 'captcha', 'contact', 'faq', 'change-email'],
            'allow' => true,
          ],
          [
            'actions' => ['login', 'signup', 'reset-password', 'request-password-reset', 'verify-email'],
            'allow' => true,
            'roles' => ['?'],
          ],
          [
            'actions' => ['logout', 'welcome'],
            'allow' => true,
            'roles' => ['@'],
          ],
        ],
      ],
      'verbs' => [
        'class' => VerbFilter::class,
        'actions' => [
          'logout' => ['post'],
        ],
      ],
    ];
  }

  /**
   * @inheritdoc
   */
  public function actions()
  {
    return [
      'error' => [
        'class' => 'yii\web\ErrorAction',
      ],
      'captcha' => [
        'class' => 'yii\captcha\CaptchaAction',
      ],
    ];
  }

  public function actionIndex()
  {
    $time = Yii::$container->get(\common\interfaces\TimeInterface::class); 
    $key = "index_blog_".$time->getLocalDate('UTC');
    $posts = Yii::$app->cache->get($key);
    if($posts === false) {
      $posts = \Yii::$app->getModule('blog')
                            ->fetch()
                            ->parse()
                            ->results;
    }
    Yii::$app->cache->set($key, $posts, 60*60*24);

    return $this->render('index', ['posts'=>$posts]);
  }

  public function actionLogin()
  {
    $model = Yii::$container->get(\common\models\LoginForm::class);
    if ($model->load(Yii::$app->request->post()) && $model->login()) {
      return $this->goBack();
    } else {
      return $this->render('login', [
        'model' => $model,
      ]);
    }
  }

  public function actionLogout()
  {
    Yii::$app->user->logout();

The method logout() does not exist on null.

    return $this->goHome();
  }

  public function actionContact()
  {
    $model = new ContactForm();
    if ($model->load(Yii::$app->request->post()) && $model->validate()) {
      if($model->sendEmail(Yii::$app->params['adminEmail'])) {
        Yii::$app->session->setFlash('success', 'Thank you for contacting us. We will respond to you as soon as possible.');

The method setFlash() does not exist on null.

      } else {
        Yii::$app->session->setFlash('error', 'There was an error sending email.');
      }

      return $this->refresh();
    } else {
      return $this->render('contact', [
        'model' => $model,
      ]);
    }
  }

  public function actionAbout()
  {
    return $this->render('about');
  }

  public function actionFaq()
  {
    return $this->render('faq');
  }

  public function actionWelcome()
  {
    return $this->render('welcome');
  }

  public function actionSignup()
  {
    $model = Yii::$container->get(\site\models\SignupForm::class);
    if($model->load(Yii::$app->request->post()) && $model->validate()) {
      $model->signup();
      Yii::$app->getSession()->setFlash('success', 'We have sent a verification email to the email address you provided. Please check your inbox and follow the instructions to verify your account.');
      return $this->redirect('/',302);
    }

    return $this->render('signup', [
      'model' => $model,
    ]);
  }

  public function actionRequestPasswordReset()
  {
    $model = Yii::$container->get(\site\models\PasswordResetRequestForm::class);
    if($model->load(Yii::$app->request->post()) && $model->validate()) {
      if(!$model->sendEmail()) {
        $ip = Yii::$app->getRequest()->getUserIP() ?: "UNKNOWN";
        Yii::warning("$ip has tried to reset the password for ".$model->email);
      }

      Yii::$app->getSession()->setFlash('success', 'If there is an account with the submitted email address you will receive further instructions in your email inbox.');
      return $this->goHome();
    }

    return $this->render('requestPasswordResetToken', [
      'model' => $model,
    ]);
  }

  public function actionResetPassword($token)
  {
    try {
      $model = Yii::$container->get(\site\models\ResetPasswordForm::class, [$token]);
    } catch (InvalidParamException $e) {
      throw new BadRequestHttpException($e->getMessage());
    }

    if ($model->load(Yii::$app->request->post())
        && $model->validate()
        && $model->resetPassword()) {
      Yii::$app->getSession()->setFlash('success', 'New password was saved.');
      return $this->goHome();
    }

    return $this->render('resetPassword', [
      'model' => $model,
    ]);
  }

  public function actionVerifyEmail($token)
  {
    if (empty($token) || !is_string($token)) {
      throw new BadRequestHttpException('Email verification token cannot be blank.');
    }

    $user = Yii::$container->get(\common\interfaces\UserInterface::class)->findByVerifyEmailToken($token);
    if (!$user) {
      throw new BadRequestHttpException("Wrong or expired email verification token. If you aren't sure why this error occurs perhaps you've already verified your account. Please try logging in.");
    }

    if($user->isTokenConfirmed($user->verify_email_token)) {
      Yii::$app->getSession()->setFlash('success', 'Your account has already been verified. Please log in.');
      return $this->redirect('/login',302);
    } else if (Yii::$app->getUser()->login($user)) {
      $user->confirmVerifyEmailToken();
      $user->save();
      Yii::$app->getSession()->setFlash('success', 'Your account has been verified. Please continue with your check-in.');
      return $this->redirect('/welcome',302);
    }
  }

  public function actionChangeEmail($token)
  {
    if (empty($token) || !is_string($token)) {
      throw new BadRequestHttpException('The email change token cannot be blank.');
    }

    $user = Yii::$container->get(\common\interfaces\UserInterface::class)->findByChangeEmailToken($token);
    var_dump( $user);

var_dump($user) looks like debug code. Are you sure you do not want to remove it?

    exit();

Using exit here is not recommended.

    if (!$user) {

IfNode is not reachable.

      throw new BadRequestHttpException("Wrong or expired email change token. If you aren't sure why this error occurs perhaps you've already confirmed your change of email. Please try logging in.");
    }

    $user->email = $user->desired_email;
    $user->save();
    // log out the user (if they're logged in)

    Yii::$app->getSession()->setFlash('success', 'Your email address has been successfully changed. Please log in.');
    return $this->redirect('/login',302);
  }

  public function actionPrivacy()
  {
    return $this->render('privacy');
  }

  public function actionTerms()
  {
    return $this->render('terms');
  }

  public function actionExport()
  {
    header("Content-Type: text/csv");
    header("Content-Disposition: attachment; filename=fsa-data-export-".Yii::$app->user->identity->email."-".date('Ymd').".csv");

Accessing email on the interface yii\web\IdentityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    $reader = Yii::$app->user->identity->getExportData();

The method getExportData() does not exist on null.

The method getExportData() does not exist on yii\web\IdentityInterface. It seems like you code against a sub-type of said class. However, the method does not exist in site\tests\_support\MockUser. Are you sure you never get one of those?

    $fp = fopen('php://output', 'w');

    $header = [
      'Date',
      'Behavior',
      'Category',
      Question::$QUESTIONS[1],
      Question::$QUESTIONS[2],
      Question::$QUESTIONS[3],
    ];

    fputcsv($fp, $header);

It seems like $fp can also be of type false; however, parameter $handle of fputcsv() does only seem to accept resource, maybe add an additional type check?

    $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
    while($row = $reader->read()) {
      $row = $user_behavior::decorateWithCategory([$row]);
      $row = Yii::$app->user->identity->cleanExportData($row);

The method cleanExportData() does not exist on yii\web\IdentityInterface. It seems like you code against a sub-type of said class. However, the method does not exist in site\tests\_support\MockUser. Are you sure you never get one of those?

      fputcsv($fp, $row[0]);
    }
    fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    die;

Using exit here is not recommended.

  }
}