site\models\CustomBehaviorForm

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	save()	0	6	1
A	attributeLabels()	0	4	1
A	rules()	0	6	1

<?php
namespace site\models;

use common\models\User;
use yii\base\Model;
use Yii;

/**
 * custom behavior form
 */
class CustomBehaviorForm extends Model {
  public $name;
  public $category_id;

  private $user;
  private $categories;

  /**
   * Creates a form model
   *
   * @param  object $user
   * @param  array  $config name-value pairs that will be used to initialize the object properties
   */
  public function __construct(\common\interfaces\UserInterface $user, \common\interfaces\CategoryInterface $category, $config = []) {
    $this->user = $user;
    $this->categories = $category->categories;

Accessing categories on the interface common\interfaces\CategoryInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    parent::__construct($config);
  }

  /**
   * @inheritdoc
   * @codeCoverageIgnore
   */
  public function rules() {
    return [
      [['name', 'category_id'], 'required'],
      ['name', 'filter', 'filter' => 'trim'],
      ['category_id', 'integer'],
      ['category_id', 'in', 'range'=>array_keys($this->categories)],

    ];
  }

  /**
   * @codeCoverageIgnore
   */
  public function attributeLabels() {
    return [
      'name'        => 'Behavior Name',
      'category_id' => 'Behavior Category',
      ];
  }


  public function save() {
    $custom_behavior = Yii::$container->get(\common\interfaces\CustomBehaviorInterface::class);
    $custom_behavior->name = $this->name;
    $custom_behavior->user_id = $this->user->id;

Accessing id on the interface common\interfaces\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    $custom_behavior->category_id = $this->category_id;
    return $custom_behavior->save();
  }
}