CorWatts / fasterscale

common/models/User.php

Braces +21 added lines, -6 removed lines

@@ -158,7 +158,9 @@ 
    */
   public function findByVerifyEmailToken($token)
   {
-    if($this->isTokenConfirmed($token)) return null;
+    if($this->isTokenConfirmed($token)) {
+      return null;
+    }
 
     $user = $this->findOne([
       'verify_email_token' => [$token, $token . self::CONFIRMED_STRING],
@@ -222,7 +224,9 @@ 
    * @param string    $match the needle to search for
    */
   public function isTokenConfirmed($token = null, String $match = self::CONFIRMED_STRING) {
-    if(is_null($token)) $token = $this->verify_email_token;
+    if(is_null($token)) {
+      $token = $this->verify_email_token;
+    }
     return substr($token, -strlen($match)) === $match;
   }
 
@@ -366,7 +370,10 @@ 
    * partner email address the user has set.
    */
   public function sendEmailReport($date) {
-    if(!$this->send_email) return false; // no partner emails set
+    if(!$this->send_email) {
+      return false;
+    }
+    // no partner emails set
     list($start, $end) = $this->time->getUTCBookends($date);
 
     $user_behavior = Yii::$container->get(UserBehaviorInterface::class);
@@ -375,14 +382,22 @@ 
     // we should only proceed with sending the email if the user
     // scored above their set email threshold (User::email_category)
     $this_checkin     = $checkins_last_month[$date]; // gets the check-in
-    if(!$this_checkin)  return false;                // sanity check
+    if(!$this_checkin) {
+      return false;
+    }
+    // sanity check
     $highest_cat_data = end($this_checkin);          // gets the data for the highest category from the check-in
-    if(!$highest_cat_data) return false;             // another sanity check
+    if(!$highest_cat_data) {
+      return false;
+    }
+    // another sanity check
     $highest_cat_idx  = key($this_checkin);          // gets the key of the highest category
 
     // if the highest category they reached today was less than
     // the category threshold they have set, don't send the email
-    if($highest_cat_idx < $this->email_category) return false;
+    if($highest_cat_idx < $this->email_category) {
+      return false;
+    }
 
     $user_behaviors = $user_behavior->getByDate(Yii::$app->user->id, $date);
 

Indentation +20 added lines, -20 removed lines

@@ -523,26 +523,26 @@
   }
 
   public function cleanExportData($row) {
-   // change timestamp to local time (for the user)
-   $row['date'] = $this->time->convertUTCToLocal($row['date'], false);
-
-   // clean up things we don't need
-   $row['category'] = $row['category']['name'];
-   if(array_key_exists('behavior', $row)) {
-     $row['behavior'] = $row['behavior']['name'];
-   } else {
-     $row['behavior'] = $row['custom_behavior'];
-   }
-   unset($row['id']);
-   unset($row['behavior_id']);
-   unset($row['category_id']);
-   unset($row['custom_behavior']);
-
-   // sort the array into a sensible order
-   uksort($row, function($a, $b) {
-     return $this->export_order[$a] <=> $this->export_order[$b];
-   });
-   return $row;
+    // change timestamp to local time (for the user)
+    $row['date'] = $this->time->convertUTCToLocal($row['date'], false);
+
+    // clean up things we don't need
+    $row['category'] = $row['category']['name'];
+    if(array_key_exists('behavior', $row)) {
+      $row['behavior'] = $row['behavior']['name'];
+    } else {
+      $row['behavior'] = $row['custom_behavior'];
+    }
+    unset($row['id']);
+    unset($row['behavior_id']);
+    unset($row['category_id']);
+    unset($row['custom_behavior']);
+
+    // sort the array into a sensible order
+    uksort($row, function($a, $b) {
+      return $this->export_order[$a] <=> $this->export_order[$b];
+    });
+    return $row;
   }
 
   /*

Spacing +25 added lines, -25 removed lines

@@ -149,7 +149,7 @@ 
    */
   public function findByPasswordResetToken($token)
   {
-    if(!$this->isTokenCurrent($token)) {
+    if (!$this->isTokenCurrent($token)) {
       return null;
     }
 
@@ -167,15 +167,15 @@ 
    */
   public function findByVerifyEmailToken($token)
   {
-    if($this->isTokenConfirmed($token)) return null;
+    if ($this->isTokenConfirmed($token)) return null;
 
     $user = $this->findOne([
       'verify_email_token' => [$token, $token . self::CONFIRMED_STRING],
       'status' => self::STATUS_ACTIVE,
     ]);
 
-    if($user) {
-      if(!$this->isTokenConfirmed($token) &&
+    if ($user) {
+      if (!$this->isTokenConfirmed($token) &&
          !$this->isTokenCurrent($token, 'user.verifyAccountTokenExpire')) {
         return null;
       }
@@ -197,8 +197,8 @@ 
       'status' => self::STATUS_ACTIVE,
     ]);
 
-    if($user) {
-      if(!$user->isTokenCurrent($token, 'user.verifyAccountTokenExpire')) {
+    if ($user) {
+      if (!$user->isTokenCurrent($token, 'user.verifyAccountTokenExpire')) {
         return null;
       }
     }
@@ -216,7 +216,7 @@ 
   public function isTokenCurrent($token, String $paramPath = 'user.passwordResetTokenExpire') {
     $expire = \Yii::$app->params[$paramPath];
     $parts = explode('_', $token);
-    $timestamp = (int) end($parts);
+    $timestamp = (int)end($parts);
     if ($timestamp + $expire < time()) {
       // token expired
       return false;
@@ -231,7 +231,7 @@ 
    * @param string    $match the needle to search for
    */
   public function isTokenConfirmed($token = null, String $match = self::CONFIRMED_STRING) {
-    if(is_null($token)) $token = $this->verify_email_token;
+    if (is_null($token)) $token = $this->verify_email_token;
     return substr($token, -strlen($match)) === $match;
   }
 
@@ -256,7 +256,7 @@ 
   }
 
   public function isVerified() {
-    if(is_null($this->verify_email_token)) {
+    if (is_null($this->verify_email_token)) {
       // for old users who verified their accounts before the addition of
       // '_confirmed' to the token
       return true;
@@ -375,7 +375,7 @@ 
    * partner email address the user has set.
    */
   public function sendEmailReport($date) {
-    if(!$this->send_email) return false; // no partner emails set
+    if (!$this->send_email) return false; // no partner emails set
     list($start, $end) = $this->time->getUTCBookends($date);
 
     $user_behavior = Yii::$container->get(UserBehaviorInterface::class);
@@ -384,14 +384,14 @@ 
     // we should only proceed with sending the email if the user
     // scored above their set email threshold (User::email_category)
     $this_checkin     = $checkins_last_month[$date]; // gets the check-in
-    if(!$this_checkin)  return false;                // sanity check
-    $highest_cat_data = end($this_checkin);          // gets the data for the highest category from the check-in
-    if(!$highest_cat_data) return false;             // another sanity check
-    $highest_cat_idx  = key($this_checkin);          // gets the key of the highest category
+    if (!$this_checkin)  return false; // sanity check
+    $highest_cat_data = end($this_checkin); // gets the data for the highest category from the check-in
+    if (!$highest_cat_data) return false; // another sanity check
+    $highest_cat_idx  = key($this_checkin); // gets the key of the highest category
 
     // if the highest category they reached today was less than
     // the category threshold they have set, don't send the email
-    if($highest_cat_idx < $this->email_category) return false;
+    if ($highest_cat_idx < $this->email_category) return false;
 
     $user_behaviors = $user_behavior->getByDate(Yii::$app->user->id, $date);
 
@@ -403,8 +403,8 @@ 
       ->create($checkins_last_month);
 
     $messages = [];
-    foreach($this->getPartnerEmails() as $email) {
-      if($email) {
+    foreach ($this->getPartnerEmails() as $email) {
+      if ($email) {
         $messages[] = Yii::$app->mailer->compose('checkinReport', [
           'user'           => $this,
           'email'          => $email,
@@ -416,7 +416,7 @@ 
           'behaviors_list' => \common\models\Behavior::$behaviors,
         ])->setFrom([Yii::$app->params['supportEmail'] => Yii::$app->name])
         ->setReplyTo($this->email)
-        ->setSubject($this->email." has completed a Faster Scale check-in")
+        ->setSubject($this->email . " has completed a Faster Scale check-in")
         ->setTo($email);
       }
     }
@@ -493,7 +493,7 @@ 
     return \Yii::$app->mailer->compose('signupNotification')
       ->setFrom([\Yii::$app->params['supportEmail'] => \Yii::$app->name])
       ->setTo(\Yii::$app->params['adminEmail'])
-      ->setSubject('A new user has signed up for '.\Yii::$app->name)
+      ->setSubject('A new user has signed up for ' . \Yii::$app->name)
       ->send();
   }
 
@@ -501,20 +501,20 @@ 
     return \Yii::$app->mailer->compose('verifyEmail', ['user' => $this])
       ->setFrom([\Yii::$app->params['supportEmail'] => \Yii::$app->name])
       ->setTo($this->email)
-      ->setSubject('Please verify your '.\Yii::$app->name .' account')
+      ->setSubject('Please verify your ' . \Yii::$app->name . ' account')
       ->send();
   }
 
   public function sendDeleteNotificationEmail() {
     $messages = [];
-    foreach(array_merge([$this->email], $this->getPartnerEmails()) as $email) {
-      if($email) {
+    foreach (array_merge([$this->email], $this->getPartnerEmails()) as $email) {
+      if ($email) {
         $messages[] = Yii::$app->mailer->compose('deleteNotification', [
           'user' => $this,
           'email' => $email
         ])->setFrom([Yii::$app->params['supportEmail'] => Yii::$app->name])
         ->setReplyTo($this->email)
-        ->setSubject($this->email." has deleted their The Faster Scale App account")
+        ->setSubject($this->email . " has deleted their The Faster Scale App account")
         ->setTo($email);
       }
     }
@@ -528,7 +528,7 @@ 
 
    // clean up things we don't need
    $row['category'] = $row['category']['name'];
-   if(array_key_exists('behavior', $row)) {
+   if (array_key_exists('behavior', $row)) {
      $row['behavior'] = $row['behavior']['name'];
    } else {
      $row['behavior'] = $row['custom_behavior'];
@@ -564,7 +564,7 @@ 
     return rtrim(
       strtr(
         base64_encode(
-          hash('sha256', $this->id."::".$this->created_at, true)
+          hash('sha256', $this->id . "::" . $this->created_at, true)
         ),
       '+/', '-_'),
     '=');

site/models/QuestionForm.php

Spacing +10 added lines, -10 removed lines

@@ -73,7 +73,7 @@ 
         'whenClient' => "function(attribute, value) { return false; }", // lame, but acceptable
         "message" => "You must select a behavior your responses apply to."],
 
-      [['answer_1a','answer_1b','answer_1c','answer_2a','answer_2b','answer_2c','answer_3a','answer_3b','answer_3c','answer_4a','answer_4b','answer_4c','answer_5a', 'answer_5b','answer_5c','answer_6a', 'answer_6b','answer_6c','answer_7a','answer_7b','answer_7c'], 'safe']
+      [['answer_1a', 'answer_1b', 'answer_1c', 'answer_2a', 'answer_2b', 'answer_2c', 'answer_3a', 'answer_3b', 'answer_3c', 'answer_4a', 'answer_4b', 'answer_4c', 'answer_5a', 'answer_5b', 'answer_5c', 'answer_6a', 'answer_6b', 'answer_6c', 'answer_7a', 'answer_7b', 'answer_7c'], 'safe']
     ];
   }
 
@@ -91,10 +91,10 @@ 
 
   public function getBhvrValidator() {
     return function($model, $attr) {
-      $attrNum = $attr[strlen($attr)-1];
-      foreach(['a', 'b', 'c'] as $l) {
+      $attrNum = $attr[strlen($attr) - 1];
+      foreach (['a', 'b', 'c'] as $l) {
         $attr = "answer_{$attrNum}{$l}";
-        if($model->$attr) return true;
+        if ($model->$attr) return true;
       }
       return false;
     };
@@ -125,7 +125,7 @@ 
 
   public function getPrefixProps($prefix) {
     return array_filter(get_object_vars($this), function($v, $k) use($prefix) {
-      if(strpos($k, $prefix) === 0 && strlen($v)) {
+      if (strpos($k, $prefix) === 0 && strlen($v)) {
         return true;
       }
     }, ARRAY_FILTER_USE_BOTH);
@@ -143,9 +143,9 @@ 
   public function getAnswers($bhvrs) {
     $answers = [];
     $user_bhvrs = array_combine($this->getUserBehaviorProps(), $bhvrs);
-    foreach($user_bhvrs as $property => $user_bhvr) {
+    foreach ($user_bhvrs as $property => $user_bhvr) {
       $behavior_id = intval(substr($property, -1, 1));
-      foreach($this->behaviorToAnswers($behavior_id) as $answer_letter => $answer) {
+      foreach ($this->behaviorToAnswers($behavior_id) as $answer_letter => $answer) {
         $question_id = \common\models\Question::$TYPES[$answer_letter];
         array_push($answers, [
                                'behavior_id'    => $user_bhvr->behavior_id,
@@ -161,7 +161,7 @@ 
 
   public function saveAnswers($bhvrs) {
     $result = true;
-    foreach($this->getAnswers($bhvrs) as $answer) {
+    foreach ($this->getAnswers($bhvrs) as $answer) {
       $model = new \common\models\Question;
       $model->user_id = Yii::$app->user->id;
       $model->behavior_id = $answer['behavior_id'];
@@ -170,9 +170,9 @@ 
       $model->date = new Expression("now()::timestamp");
       $model->question = $answer['question_id'];
       $model->answer = $answer['answer'];
-      if(!$model->save()) {
+      if (!$model->save()) {
         $result = false;
-        var_dump( $model->errors);
+        var_dump($model->errors);
         exit();
       }
     }

site/views/checkin/view.php

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
 $plus_week  = $time->alterLocalDate($actual_date, "+1 week");
 
 $pie_data = [];
-if($answer_pie) {
+if ($answer_pie) {
   $values     = array_map('intval', array_column($answer_pie, "count"));
   $labels     = array_column($answer_pie, "name");
   $colors     = array_column($answer_pie, "color");
@@ -68,15 +68,15 @@ 
     </div>
   </div>
 
-  <?php if($questions) {
-  foreach($questions as $behavior_id => $behavior_questions) {
+  <?php if ($questions) {
+  foreach ($questions as $behavior_id => $behavior_questions) {
     print "<div class='well well-sm'>";
     print "<button type='button' class='btn btn-primary' disabled='disabled'>{$behavior_questions['question']['behavior_name']}</button>";
     print "<div class='row'>";
-    foreach($behavior_questions['answers'] as $question) { 
+    foreach ($behavior_questions['answers'] as $question) { 
       print "<div class='col-md-4'>";
       print "<p><strong>{$question['title']}</strong></p>";
-      print "<p>".Html::encode($question['answer'])."</p>";
+      print "<p>" . Html::encode($question['answer']) . "</p>";
       print "</div>";
     }
     print "</div></div>";
@@ -88,7 +88,7 @@ 
     'options' => ['class' => 'form-horizontal'],
   ]);
 
-  foreach($categories as $category) {
+  foreach ($categories as $category) {
     $behaviors = AH::map($behaviorsList[$category['id']], 'id', 'name');
     print $form
             ->field($model, "behaviors{$category['id']}")

site/tests/unit/models/SignupFormTest.php

Spacing +8 added lines, -8 removed lines

@@ -32,13 +32,13 @@ 
     $this->container = new \yii\di\Container;
     $this->container->set('common\interfaces\UserInterface', '\site\tests\_support\MockUser');
     $this->container->set('common\interfaces\UserBehaviorInterface', '\site\tests\_support\MockUserBehavior');
-    $this->container->set('common\interfaces\TimeInterface', function () {
+    $this->container->set('common\interfaces\TimeInterface', function() {
       return new \common\components\Time('America/Los_Angeles');
     });
 
     // instantiate mock objects
     $user_behavior = $this->container->get(\common\interfaces\UserBehaviorInterface::class);
-    $time        = $this->container->get(\common\interfaces\TimeInterface::class);
+    $time = $this->container->get(\common\interfaces\TimeInterface::class);
 
     $question = $this->getMockBuilder(\common\models\Question::class)
       ->setMethods(['save', 'attributes'])
@@ -107,7 +107,7 @@ 
 
     // set up a side effect to occur when the user's save() function is called
     $saved = false;
-    $this->user->method('save')->will($this->returnCallback(function($runValidation=true, $attributeNames=null) use(&$saved) {
+    $this->user->method('save')->will($this->returnCallback(function($runValidation = true, $attributeNames = null) use(&$saved) {
       $saved = true;
       return $this->user;
     }));
@@ -133,7 +133,7 @@ 
  
   public function testSignupExistingConfirmedUser() {
     $saved = false;
-    $this->existing_user->method('save')->will($this->returnCallback(function($runValidation=true, $attributeNames=null) use(&$saved) {
+    $this->existing_user->method('save')->will($this->returnCallback(function($runValidation = true, $attributeNames = null) use(&$saved) {
       $saved = true;
       return $this->existing_user;
     }));
@@ -152,7 +152,7 @@ 
 
   public function testSignupExistingUnconfirmedUser() {
     $saved = false;
-    $this->existing_user->method('save')->will($this->returnCallback(function($runValidation=true, $attributeNames=null) use(&$saved) {
+    $this->existing_user->method('save')->will($this->returnCallback(function($runValidation = true, $attributeNames = null) use(&$saved) {
       $saved = true;
       return $this->existing_user;
     }));
@@ -183,14 +183,14 @@ 
 
     $result = $form->setFields($this->user);
     $this->specify('populate should set the values of the user model from the form', function() use ($result) {
-      foreach($this->whitelist as $attr) {
+      foreach ($this->whitelist as $attr) {
         $this->assertEquals($this->vals[$attr], $result->$attr);
       }
     });
   }
 
   private function setAttrs($form, Array $vals) {
-    foreach($vals as $key => $val) {
+    foreach ($vals as $key => $val) {
       $form->$key = $val;
     }
     return $form;
@@ -211,7 +211,7 @@ 
   }
 
   private function getForm($user = null) {
-    if(is_null($user)) $user = $this->user;
+    if (is_null($user)) $user = $this->user;
     $form = $this->container->get('\site\models\SignupForm', [$user]);
     $form->attributes = $this->vals; // massive assignment
     return $form;

site/controllers/ProfileController.php

Spacing +9 added lines, -9 removed lines

@@ -27,7 +27,7 @@ 
             'allow'   => true,
             'roles'   => ['@'],
           ], [
-            'actions' => [ 'change-email', ],
+            'actions' => ['change-email', ],
             'allow'   => true,
           ],
         ],
@@ -58,7 +58,7 @@ 
 
     if ($editProfileForm->load(Yii::$app->request->post())) {
       $saved_user = $editProfileForm->saveProfile();
-      if($saved_user) {
+      if ($saved_user) {
         Yii::$app->session->setFlash('success', 'New profile data saved!');
       }
     }
@@ -78,7 +78,7 @@ 
     $model = Yii::$container->get(\site\models\DeleteAccountForm::class, [Yii::$app->user->identity]);
 
     if ($model->load(Yii::$app->request->post()) && $model->validate()) {
-      if($model->deleteAccount()) {
+      if ($model->deleteAccount()) {
         $this->redirect(['site/index']);
       } else {
         Yii::$app->session->setFlash('error', 'Wrong password!');
@@ -92,7 +92,7 @@ 
     $model = Yii::$container->get(\site\models\ChangePasswordForm::class, [Yii::$app->user->identity]);
 
     if ($model->load(Yii::$app->request->post())) {
-      if($model->validate() && $model->changePassword()) {
+      if ($model->validate() && $model->changePassword()) {
         Yii::$app->session->setFlash('success', 'Password successfully changed');
       } else {
         Yii::$app->session->setFlash('error', 'Wrong password!');
@@ -116,14 +116,14 @@ 
   public function actionChangeEmail(string $token) {
     $user = Yii::$container->get(\common\interfaces\UserInterface::class)->findByChangeEmailToken($token);
 
-    if($user) {
+    if ($user) {
       $validator = new \yii\validators\EmailValidator();
-      if($validator->validate($user->desired_email, $error)) {
+      if ($validator->validate($user->desired_email, $error)) {
         $user->removeChangeEmailToken();
         $user->email = $user->desired_email;
         $user->desired_email = null;
         $user->save();
-        if(!Yii::$app->user->isGuest) {
+        if (!Yii::$app->user->isGuest) {
           Yii::$app->user->logout();
           Yii::$app->session->setFlash('success', 'Your email address was successfully changed. For security, we\'ve logged you out.');
         } else {
@@ -143,7 +143,7 @@ 
 
   public function actionExport() {
     header("Content-Type: text/csv");
-    header("Content-Disposition: attachment; filename=fsa-data-export-".Yii::$app->user->identity->email."-".date('Ymd').".csv");
+    header("Content-Disposition: attachment; filename=fsa-data-export-" . Yii::$app->user->identity->email . "-" . date('Ymd') . ".csv");
 
     $reader = Yii::$app->user->identity->getExportData();
     $fp = fopen('php://output', 'w');
@@ -159,7 +159,7 @@ 
 
     fputcsv($fp, $header);
     $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
-    while($row = $reader->read()) {
+    while ($row = $reader->read()) {
       $row = $user_behavior::decorate([$row]);
       $row = Yii::$app->user->identity->cleanExportData($row[0]);
       fputcsv($fp, $row);

common/mail/checkinReport.php

Spacing +6 added lines, -6 removed lines

@@ -125,14 +125,14 @@ 
                                                 <th style="Margin:0;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left">
 
 <?php
-if($questions) {
-  foreach($questions as $behavior_id => $behavior_questions) {
+if ($questions) {
+  foreach ($questions as $behavior_id => $behavior_questions) {
 ?>
 
                                                    <h4 style="Margin:0;Margin-bottom:10px;color:#37b98f;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:24px;font-weight:400;line-height:1.3;margin:0;margin-bottom:5px;padding:0 8px;text-align:left;word-wrap:normal"> <?= Html::encode($behavior_questions['question']['behavior_name']) ?> </h4>
 
 <?php
-    foreach($behavior_questions['answers'] as $key => $question) {  ?>
+    foreach ($behavior_questions['answers'] as $key => $question) {  ?>
       <p style="Margin:0;Margin-bottom:10px;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0 8px 4px 8px;text-align:left"><strong><?= Html::encode($question['title']) ?></strong> <?= Html::encode($question['answer']) ?></p>
 <?php
     }
@@ -189,12 +189,12 @@ 
                                                 <th style="Margin:0;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left">
 
 <?php
-if($user_behaviors) {
-  foreach($user_behaviors as $cat_key => $behaviors) { ?>
+if ($user_behaviors) {
+  foreach ($user_behaviors as $cat_key => $behaviors) { ?>
         <p style="Margin:0;Margin-bottom:10px;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0 8px 4px 8px;text-align:left">
           <strong style="color:#37b98f"><?= Html::encode($categories[$cat_key]) ?></strong>
 <?php
-    foreach($behaviors as $behavior) { ?>
+    foreach ($behaviors as $behavior) { ?>
         <br><?= Html::encode($behavior['name']) ?>
 <?php
     }

common/tests/unit/models/UserTest.php

Spacing +4 added lines, -4 removed lines

@@ -88,7 +88,7 @@ 
     $this->container = new \yii\di\Container;
     $this->container->set('common\interfaces\UserInterface', '\site\tests\_support\MockUser');
     $this->container->set('common\interfaces\UserBehaviorInterface', '\site\tests\_support\MockUserBehavior');
-    $this->container->set('common\interfaces\TimeInterface', function () {
+    $this->container->set('common\interfaces\TimeInterface', function() {
       return new \common\components\Time('America/Los_Angeles');
     });
 
@@ -134,7 +134,7 @@ 
   }
 
   public function testIsTokenCurrent() {
-    $this->specify('isTokenCurrent should function correctly', function () {
+    $this->specify('isTokenCurrent should function correctly', function() {
       $good_token = \Yii::$app
                       ->getSecurity()
                       ->generateRandomString() . '_' . time();
@@ -168,7 +168,7 @@ 
   public function testConfirmVerifyEmailToken() {
     $this->user->verify_email_token = 'hello_world';
     $this->user->confirmVerifyEmailToken();
-    expect('confirmVerifyEmailToken should append User::CONFIRMED_STRING to the end of the verify_email_token property', $this->assertEquals($this->user->verify_email_token, 'hello_world'.$this->user::CONFIRMED_STRING));
+    expect('confirmVerifyEmailToken should append User::CONFIRMED_STRING to the end of the verify_email_token property', $this->assertEquals($this->user->verify_email_token, 'hello_world' . $this->user::CONFIRMED_STRING));
   }
 
   public function testIsVerified() {
@@ -262,7 +262,7 @@ 
       ->disableOriginalConstructor()
       ->setMethods(['save', 'attributes', 'getCheckinBreakdown'])
       ->getMock();
-    $expected = require(__DIR__.'/../data/expected_getCheckinBreakdown.php');
+    $expected = require(__DIR__ . '/../data/expected_getCheckinBreakdown.php');
     $user_behavior->method('getCheckinBreakdown')->willReturn($expected);
 
     $user = $this->getMockBuilder(User::class)

common/tests/unit/models/QuestionTest.php

Indentation +2 added lines, -2 removed lines

@@ -211,8 +211,8 @@
 
   public function setUp() {
     $this->question = $this->getMockBuilder('\common\models\Question')
-         ->setMethods(['save', 'attributes'])
-         ->getMock();
+          ->setMethods(['save', 'attributes'])
+          ->getMock();
   }
 
   public function testParseQuestionData() {