common\unit\models\QuestionTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	182
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	testParseQuestionData()	0	31	4

<?php

namespace common\unit\models;

use Yii;
use Codeception\Specify;
use common\models\Question;

/**
 * Time test
 */

class QuestionTest extends \Codeception\Test\Unit {
  use Specify;

  private $question;
  private $questionData = [
    [
      'id' => 487,
      'user_id' => 1,
      'behavior_id' => 54,
      'user_behavior_id' => 2664,
      'question' => 1,
      'answer' => 'test1',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 4,
    ], [
      'id' => 488,
      'user_id' => 1,
      'behavior_id' => 54,
      'user_behavior_id' => 2664,
      'question' => 2,
      'answer' => 'test2',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 4,
    ], [
      'id' => 489,
      'user_id' => 1,
      'behavior_id' => 54,
      'user_behavior_id' => 2664,
      'question' => 3,
      'answer' => 'test3',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 4,
    ], [
      'id' => 490,
      'user_id' => 1,
      'behavior_id' => 132,
      'user_behavior_id' => 2665,
      'question' => 1,
      'answer' => 'test1',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 7,
    ], [
      'id' => 491,
      'user_id' => 1,
      'behavior_id' => 132,
      'user_behavior_id' => 2665,
      'question' => 2,
      'answer' => 'test2',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 7,
    ], [
      'id' => 492,
      'user_id' => 1,
      'behavior_id' => 132,
      'user_behavior_id' => 2665,
      'question' => 3,
      'answer' => 'test3',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 7,
    ], [
      'id' => 493,
      'user_id' => 1,
      'behavior_id' => NULL,
      'user_behavior_id' => 2666,
      'question' => 1,
      'answer' => 'test1',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 2,
    ], [
      'id' => 494,
      'user_id' => 1,
      'behavior_id' => NULL,
      'user_behavior_id' => 2666,
      'question' => 2,
      'answer' => 'test2',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 2,
    ], [
      'id' => 495,
      'user_id' => 1,
      'behavior_id' => NULL,
      'user_behavior_id' => 2666,
      'question' => 3,
      'answer' => 'test3',
      'date' => '2019-10-27 21:07:35',
      'category_id' => 2,
    ],
  ];
  private $userQuestions = [
    2664 => [
      'question' => [
        'user_behavior_id' => 2664,
        'behavior_name' => 'can\'t turn off thoughts',
      ],
      'answers' => [
        [
          'title' => 'How does it affect me? How do I act and feel?',
          'answer' => 'test1',
        ], [
          'title' => 'How does it affect the important people in my life?',
          'answer' => 'test2',
        ], [
          'title' => 'Why do I do this? What is the benefit for me?',
          'answer' => 'test3',
        ],
      ],
    ],
    2665 => [
      'question' => [
        'user_behavior_id' => 2665,
        'behavior_name' => 'aloneness',
      ],
      'answers' => [
        [
          'title' => 'How does it affect me? How do I act and feel?',
          'answer' => 'test1',
        ], [
          'title' => 'How does it affect the important people in my life?',
          'answer' => 'test2',
        ], [
          'title' => 'Why do I do this? What is the benefit for me?',
          'answer' => 'test3',
        ],
      ],
    ],
    2666=> [
      'question' => [
        'user_behavior_id' => 2666,
        'behavior_name' => 'some_custom_behavior',
      ],
      'answers' => [
        [
          'title' => 'How does it affect me? How do I act and feel?',
          'answer' => 'test1',
        ], [
          'title' => 'How does it affect the important people in my life?',
          'answer' => 'test2',
        ], [
          'title' => 'Why do I do this? What is the benefit for me?',
          'answer' => 'test3',
        ],
      ],
    ],
  ];

  public function setUp() {
    $this->question = $this->getMockBuilder('\common\models\Question')
         ->setMethods(['save', 'attributes'])
         ->getMock();
  }

  public function testParseQuestionData() {
    $questions = array_map(function ($d) {
      $q = $this->getMockBuilder('\common\models\Question')
         ->setMethods(['save', 'attributes'])
         ->getMock();
      $q->method('save')->willReturn(true);
      $q->method('attributes')
        ->willReturn([
          'id',
          'user_id',
          'behavior_id',
          'category_id',
          'user_behavior_id',
          'question',
          'answer',
          'date',
          'userBehavior',
        ]);
      foreach($d as $k => $v) {
        if($k === 'behavior_id' && $v === null) {
          $ub = new \StdClass();
          $ub->custom_behavior = 'some_custom_behavior';
          $q->userBehavior = $ub;

Accessing userBehavior on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        } else {
          $q->$k = $v;
        }
      }
      return $q;
    }, $this->questionData);
    expect('parseQuestionData should return the correct structure with expected data', $this->assertEquals($this->question->parseQuestionData($questions), $this->userQuestions));

Are you sure the usage of $this->assertEquals($this->question->parseQuestionData($questions), $this->userQuestions) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

    expect('parseQuestionData should return empty with the empty set', $this->assertEmpty($this->question->parseQuestionData([])));

Are you sure the usage of $this->assertEmpty($this->question->parseQuestionData(array())) targeting PHPUnit\Framework\Assert::assertEmpty() seems to always return null.

  }
}