site\tests\unit\models\ChangeEmailFormTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getUser()	0	11	1
A	testSimpleRulesShouldValidate()	0	10	1
B	testChangeEmail()	0	41	1

<?php

namespace site\tests\unit\models;

use Yii;
use \site\models\ChangeEmailForm;

class ChangeEmailFormTest extends \Codeception\Test\Unit {
  use \Codeception\Specify;

  public function testSimpleRulesShouldValidate() {
    $user = $this->getUser();
    $form = new ChangeEmailForm($user);

    $form->attributes = [];
    expect('with no values, the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = ['desired_email' => 'not_an_email'];
    expect('with a value that is not an email, the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = ['desired_email' => 'valid@email.com'];
    expect('with a valid email, the form should pass validation', $this->assertTrue($form->validate()));

Are you sure the usage of $this->assertTrue($form->validate()) targeting PHPUnit\Framework\Assert::assertTrue() seems to always return null.

  }

  public function testChangeEmail() {

    $this->specify('changeEmail() should return true and do nothing when the email is already taken', function() {
      $user = $this->getUser();
      $user
        ->expects($this->never())
        ->method('save');
      $desired_email = 'new_email@email.com';
      $user
        ->method('findByEmail')

The method method() does not exist on PHPUnit\Framework\MockObject\MockObject.

        ->willReturn(true); // true, as a stand-in for some valid user object

      $form = new ChangeEmailForm($user);
      $form->desired_email = $desired_email;
      $this->assertTrue($form->changeEmail(), 'should always return true');
      $this->assertNull($user->desired_email, 'should be null because we didn\'t set the new email');

Accessing desired_email on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

      $this->assertNotEquals($user->desired_email, $desired_email);
    });

    $this->specify('changeEmail() should return true, set values, and send an email when the email is available', function() {
      $user = $this->getUser();
      $desired_email = 'new_email@email.com';
      $user
        ->method('findByEmail')
        ->willReturn(null);
      $user->email = 'email@email.com';

Accessing email on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

      $form = new ChangeEmailForm($user);
      $form->desired_email = $desired_email;

      expect('changeEmail should return true', $this->assertTrue($form->changeEmail()));

Are you sure the usage of $this->assertTrue($form->changeEmail()) targeting PHPUnit\Framework\Assert::assertTrue() seems to always return null.

      expect('the user\'s desired email should now match what they entered in the form', $this->assertEquals($user->desired_email, $desired_email));

Accessing desired_email on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

Are you sure the usage of $this->assertEquals($user->desired_email, $desired_email) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

      $this->tester->seeEmailIsSent();

The property tester does not exist on site\tests\unit\models\ChangeEmailFormTest. Did you maybe forget to declare it?

      $emailMessage = $this->tester->grabLastSentEmail();
      expect('valid email is sent', $emailMessage)->isInstanceOf('yii\mail\MessageInterface');
      expect($emailMessage->getTo())->hasKey($desired_email);
      expect($emailMessage->getFrom())->hasKey(Yii::$app->params['supportEmail']);
      expect($emailMessage->getSubject())->equals(Yii::$app->name . ' -- your requested email change');
      expect($emailMessage->toString())->contains($user->email);
    });
  }

  private function getUser() {
    $user = $this->getmockbuilder('\common\models\user')
      ->disableoriginalconstructor()
      ->setmethods(['getisnewrecord', 'attributes', 'generatechangeemailtoken', 'findbyemail', 'save'])
      ->getmock();
    $user->method('attributes')->willreturn([
      'email',
      'desired_email',
      'change_email_token',
    ]);
    return $user;
  }
}