site\controllers\ProfileController

Complexity

Total Complexity

25

Size/Duplication

Total Lines	168
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	actionRequestChangeEmail()	0	12	4
B	actionChangeEmail()	0	24	4
B	actionExport()	0	26	2
B	actionIndex()	0	26	5
A	behaviors()	0	20	1
A	actions()	0	8	1
A	actionChangePassword()	0	12	4
A	actionDeleteAccount()	0	12	4

<?php
namespace site\controllers;


use Yii;
use common\models\Question;
use yii\web\Controller;
use yii\filters\VerbFilter;
use common\components\AccessControl;
use League\Csv\Writer;

The type League\Csv\Writer was not found. Maybe you did not declare it correctly or list all dependencies?

use yii\web\BadRequestHttpException;

/**
 * Profile controller
 */
class ProfileController extends Controller {
  /**
   * @inheritdoc
   */
  public function behaviors() {
    return [
      'access' => [
        'class' => AccessControl::class,
        'rules' => [
          [
            'actions' => ['index', 'error', 'delete-account', 'change-password', 'request-change-email', 'export'],
            'allow'   => true,
            'roles'   => ['@'],
          ], [
            'actions' => [ 'change-email', ],
            'allow'   => true,
          ],
        ],
      ],
      'verbs' => [
        'class' => VerbFilter::class,
        'actions' => [
          'deleteAccount' => ['post'],
          'changePassword' => ['post'],
        ],
      ],
    ];
  }

  /**
   * @inheritdoc
   */
  public function actions()
  {
    return [
      'error' => [
        'class' => 'yii\web\ErrorAction',
      ],
      'captcha' => [
        'class' => 'yii\captcha\CaptchaAction',
      ],
    ];
  }

  public function actionIndex() {
    $editProfileForm    = Yii::$container->get(\site\models\EditProfileForm::class, [Yii::$app->user->identity]);
    $changePasswordForm = Yii::$container->get(\site\models\ChangePasswordForm::class, [Yii::$app->user->identity]);
    $changeEmailForm = Yii::$container->get(\site\models\ChangeEmailForm::class, [Yii::$app->user->identity]);
    $deleteAccountForm  = Yii::$container->get(\site\models\DeleteAccountForm::class, [Yii::$app->user->identity]);
    $graph              = Yii::$container->get(\common\components\Graph::class, [Yii::$app->user->identity]);

    if (Yii::$app->request->isAjax && $editProfileForm->load($_POST)) {
      Yii::$app->response->format = 'json';
      return \yii\widgets\ActiveForm::validate($editProfileForm);
    }
    $editProfileForm->loadUser();

    if ($editProfileForm->load(Yii::$app->request->post())) {
      $saved_user = $editProfileForm->saveProfile();
      if($saved_user) {
        Yii::$app->getSession()->setFlash('success', 'New profile data saved!');
      }
    }

    return $this->render('index', [
      'profile'         => $editProfileForm,
      'change_password' => $changePasswordForm,
      'change_email'    => $changeEmailForm,
      'delete'          => $deleteAccountForm,
      'graph_url'       => $graph->getUrl(Yii::$app->user->identity->getIdHash()),

The method getIdHash() does not exist on null.

The method getIdHash() does not exist on yii\web\IdentityInterface. Did you maybe mean getId()?

    ]);
  }

  public function actionDeleteAccount() {
    $model = Yii::$container->get(\site\models\DeleteAccountForm::class, [Yii::$app->user->identity]);

    if ($model->load(Yii::$app->request->post()) && $model->validate()) {
      if($model->deleteAccount()) {
        $this->redirect(['site/index']);
      } else {
        Yii::$app->getSession()->setFlash('error', 'Wrong password!');
      }
    }

    $this->redirect(Yii::$app->request->getReferrer());
  }

  public function actionChangePassword() {
    $model = Yii::$container->get(\site\models\ChangePasswordForm::class, [Yii::$app->user->identity]);

    if ($model->load(Yii::$app->request->post())) {
      if($model->validate() && $model->changePassword()) {
        Yii::$app->getSession()->setFlash('success', 'Password successfully changed');
      } else {
        Yii::$app->getSession()->setFlash('error', 'Wrong password!');
      }
    }

    $this->redirect(['profile/index']);
  }

  public function actionRequestChangeEmail() {
    $model = Yii::$container->get(\site\models\ChangeEmailForm::class, [Yii::$app->user->identity]);

    if ($model->load(Yii::$app->request->post()) && $model->validate()) {
      if($model->changeEmail()) {
        Yii::$app->getSession()->setFlash('success', "We've sent an email to your requested email address to confirm. Please click on the verification link to continue.");
      } else {
        Yii::$app->getSession()->setFlash('error', 'Something went wrong!');
      }
    }

    $this->redirect(['profile/index']);
  }

  public function actionChangeEmail(string $token) {
    $user = \common\models\User::findByChangeEmailToken($token);

The method common\models\User::findByChangeEmailToken() is not static, but was called statically.

    if($user) {
      $validator = new \yii\validators\EmailValidator();
      if($validator->validate($user->desired_email, $error)) {
        $user->removeChangeEmailToken();
        $user->email = $user->desired_email;
        $user->desired_email = null;
        $user->save();
        if(!Yii::$app->user->isGuest) {
          Yii::$app->user->logout();

The method logout() does not exist on null.

          Yii::$app->session->setFlash('success', 'Your email address was successfully changed. For security, we\'ve logged you out.');

The method setFlash() does not exist on null.

        } else {
          Yii::$app->session->setFlash('success', 'Your email address was successfully changed.');
        }
        return $this->goHome();
      } else {
        // desired_email failed validation. Something sneaky might be happening here
        // log here
        throw new \Exception($error);
      }
    } else {
      // no user was found with that token
      throw new BadRequestHttpException("Wrong or expired change email token. If you aren't sure why this error occurs perhaps you've already confirmed your new email address change. Please try logging in with it.");
    }
  }

  public function actionExport() {
    header("Content-Type: text/csv");
    header("Content-Disposition: attachment; filename=fsa-data-export-".Yii::$app->user->identity->email."-".date('Ymd').".csv");

Accessing email on the interface yii\web\IdentityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    $reader = Yii::$app->user->identity->getExportData();

The method getExportData() does not exist on yii\web\IdentityInterface. It seems like you code against a sub-type of said class. However, the method does not exist in site\tests\_support\MockUser. Are you sure you never get one of those?

    $fp = fopen('php://output', 'w');

    $header = [
      'Date',
      'Behavior',
      'Category',
      Question::$QUESTIONS[1],
      Question::$QUESTIONS[2],
      Question::$QUESTIONS[3],
    ];

    fputcsv($fp, $header);

It seems like $fp can also be of type false; however, parameter $handle of fputcsv() does only seem to accept resource, maybe add an additional type check?

    $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
    while($row = $reader->read()) {
      $row = $user_behavior::decorateWithCategory([$row]);
      $row = Yii::$app->user->identity->cleanExportData($row);

The method cleanExportData() does not exist on yii\web\IdentityInterface. It seems like you code against a sub-type of said class. However, the method does not exist in site\tests\_support\MockUser. Are you sure you never get one of those?

      fputcsv($fp, $row[0]);
    }
    fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    die;

Using exit here is not recommended.

  }
}