CorWatts / fasterscale

common/models/Category.php

Spacing +7 added lines, -7 removed lines

@@ -12,13 +12,13 @@
 class Category extends \yii\base\BaseObject implements \common\interfaces\CategoryInterface {
 
   public static $categories = [
-    [ "id" => 1, "name" => "Restoration"],
-    [ "id" => 2, "name" => "Forgetting Priorities"],
-    [ "id" => 3, "name" => "Anxiety"],
-    [ "id" => 4, "name" => "Speeding Up"],
-    [ "id" => 5, "name" => "Ticked Off"],
-    [ "id" => 6, "name" => "Exhausted"],
-    [ "id" => 7, "name" => "Relapse/Moral Failure"],
+    ["id" => 1, "name" => "Restoration"],
+    ["id" => 2, "name" => "Forgetting Priorities"],
+    ["id" => 3, "name" => "Anxiety"],
+    ["id" => 4, "name" => "Speeding Up"],
+    ["id" => 5, "name" => "Ticked Off"],
+    ["id" => 6, "name" => "Exhausted"],
+    ["id" => 7, "name" => "Relapse/Moral Failure"],
   ];
 
   public static $colors = [

common/models/UserBehavior.php

Spacing +10 added lines, -10 removed lines

@@ -84,7 +84,7 @@ 
       ->groupBy('date, user_id')
       ->having('user_id = :user_id');
     $temp_dates = $query->all();
-    foreach($temp_dates as $temp_date) {
+    foreach ($temp_dates as $temp_date) {
       $past_checkin_dates[] = $this->time->convertUTCToLocal($temp_date['date']);
     }
 
@@ -126,13 +126,13 @@ 
   }
 
   public function getCheckinBreakdown(\DatePeriod $datetimes) {
-    $key = "scores_of_last_month_".Yii::$app->user->id."_".$this->time->getLocalDate();
+    $key = "scores_of_last_month_" . Yii::$app->user->id . "_" . $this->time->getLocalDate();
     $scores = Yii::$app->cache->get($key);
 
-    if($scores === false) {
+    if ($scores === false) {
       $scores = [];
       $count = 0;
-      foreach($datetimes as $datetime) {
+      foreach ($datetimes as $datetime) {
         $count += 1;
         $behaviors = self::decorateWithCategory($this->getBehaviorsWithCounts($datetime));
         $scores[$datetime->format('Y-m-d')] = $this->getBehaviorsByCategory($behaviors);
@@ -159,7 +159,7 @@ 
   public function getBehaviorsByCategory(array $decorated_behaviors) {
     $arr = array_reduce($decorated_behaviors, function($acc, $row) {
       $cat_id = $row['behavior']['category']['id'];
-      if(array_key_exists($cat_id, $acc)) {
+      if (array_key_exists($cat_id, $acc)) {
         $acc[$cat_id]['count'] += $row['count'];
       } else {
         $acc[$cat_id] = [
@@ -176,10 +176,10 @@ 
   }
 
   public static function decorate(array $uo, $with_category = false) {
-    foreach($uo as &$o) {
-      if($behavior = \common\models\Behavior::getBehavior('id', $o['behavior_id'])) {
+    foreach ($uo as &$o) {
+      if ($behavior = \common\models\Behavior::getBehavior('id', $o['behavior_id'])) {
         $o['behavior'] = $behavior;
-        if($with_category) {
+        if ($with_category) {
           $o['behavior']['category'] = \common\models\Category::getCategory('id', $o['behavior']['category_id']);
         }
       }
@@ -200,11 +200,11 @@ 
       ->having('user_id = :user_id')
       ->orderBy('count DESC');
 
-    if($limit instanceof \DateTime) {
+    if ($limit instanceof \DateTime) {
       list($start, $end) = $this->time->getUTCBookends($limit->format('Y-m-d'));
       $query->params += [':start_date' => $start, ':end_date' => $end];
       $query->where('user_id=:user_id AND date > :start_date AND date <= :end_date');
-    } else if(is_int($limit)) {
+    } else if (is_int($limit)) {
       $query->limit($limit);
     }
 

common/config/main.php

Spacing +3 added lines, -3 removed lines

@@ -10,8 +10,8 @@ 
       'common\interfaces\QuestionInterface' => \common\models\Question::class,
       'common\interfaces\BehaviorInterface' => \common\models\Behavior::class,
       'common\interfaces\CategoryInterface' => \common\models\Category::class,
-      'common\interfaces\TimeInterface' => function () {
-        if(Yii::$app->user->getIsGuest()) {
+      'common\interfaces\TimeInterface' => function() {
+        if (Yii::$app->user->getIsGuest()) {
           return new \common\components\Time('UTC');
         } else {
           return new \common\components\Time(Yii::$app->user->identity->timezone);
@@ -28,7 +28,7 @@ 
   ],
   'components' => [
     // by default, sessions are stored in a local file
-    'cache' => [ // DummyCache never actually caches anything
+    'cache' => [// DummyCache never actually caches anything
       'class'=> yii\caching\DummyCache::class,
     ],
     'mailer' => [

common/components/Time.php

Spacing +11 added lines, -11 removed lines

@@ -36,13 +36,13 @@ 
    * @return \DateTime the parsed time or the default value
    */
   public function parse($time, $default = false, string $format = 'Y-m-d') {
-    if(is_string($time)) {
+    if (is_string($time)) {
       $dt = DateTime::createFromFormat($format, $time, new DateTimeZone($this->timezone));
-      if($dt) {
+      if ($dt) {
         // for some reason, using createFromFromat adds in the time. The regular DateTime constructor _does not_ do this. We manually zero out the time here to make the DateTime objects match.
         $dt->setTime(0, 0, 0);
         $formatted = $dt->format($format);
-        if($formatted === $time && $this->inBounds($dt)) {
+        if ($formatted === $time && $this->inBounds($dt)) {
           return $dt;
         }
       }
@@ -62,7 +62,7 @@ 
     $test  = strtotime($dt->format('Y-m-d'));
     $now   = strtotime($this->getLocalDate());
 
-    if($first <= $test && $test <= $now) {
+    if ($first <= $test && $test <= $now) {
       return true;
     } else {
       return false;
@@ -86,7 +86,7 @@ 
   }
 
   public function getLocalTime($timezone = null) {
-    if($timezone === null)
+    if ($timezone === null)
       $timezone = $this->timezone;
 
     $timestamp = new DateTime("now", new DateTimeZone($timezone));
@@ -94,7 +94,7 @@ 
   }
 
   public function getLocalDate($timezone = null) {
-    if($timezone === null)
+    if ($timezone === null)
       $timezone = $this->timezone;
 
     return (new DateTime("now", new DateTimeZone($timezone)))
@@ -108,7 +108,7 @@ 
 
   public function getUTCBookends($local) {
     $local = trim($local);
-    if(strpos($local, " ")) {
+    if (strpos($local, " ")) {
       return false;
     }
 
@@ -130,9 +130,9 @@ 
    * @return string a date string
    */
   public function validate($date = null) {
-    if(is_null($date)) {
+    if (is_null($date)) {
       return $this->getLocalDate();
-    } else if($dt = $this->parse($date)) {
+    } else if ($dt = $this->parse($date)) {
       return $dt->format('Y-m-d');
     } else {
       return $this->getLocalDate();
@@ -151,12 +151,12 @@ 
     $dt = new DateTime("now", new DateTimeZone($this->timezone));
     $dt2 = new DateTime("now", new DateTimeZone($this->timezone));
     $end = $dt->add(new \DateInterval('P1D'))      // add a day, so the end date gets included in the intervals
-              ->add(new \DateInterval('PT2M'));    // to be sure we have everything
+              ->add(new \DateInterval('PT2M')); // to be sure we have everything
     $start = $dt2->add(new \DateInterval('PT2M')); // to be sure we have everything
     $start = $start->sub(new \DateInterval("P${period}D"));
     $periods = new \DatePeriod($start, new \DateInterval('P1D'), $end, \DatePeriod::EXCLUDE_START_DATE);
     $local_tz = new \DateTimeZone($this->timezone);
-    foreach($periods as $period) {
+    foreach ($periods as $period) {
       $period->setTimezone($local_tz);
     }
     return $periods;

common/components/Graph.php

Spacing +10 added lines, -10 removed lines

@@ -28,7 +28,7 @@ 
   public function getFilepath() {
     $path = Yii::getAlias('@graphImgPath');
     $filename = $this->user->getIdHash() . ".png";
-    return $path. '/' . $filename;
+    return $path . '/' . $filename;
   }
 
   /**
@@ -61,14 +61,14 @@ 
    * @return string the encoded image
    */
   public function create(array $checkins, bool $toDisk = false) {
-    if($toDisk) {
+    if ($toDisk) {
       // wipe out the current image, if it exists
       $this->destroy();
     }
 
     $accum = [];
-    foreach($checkins as $checkin_sum) {
-      for($i = 1; $i <= 7; $i ++) {
+    foreach ($checkins as $checkin_sum) {
+      for ($i = 1; $i <= 7; $i++) {
         $accum[$i][] = array_key_exists($i, $checkin_sum) ? $checkin_sum[$i]['count'] : 0;
       }
     }
@@ -87,10 +87,10 @@ 
 
     // Setup dates as labels on the X-axis
     $graph->xaxis->SetTickLabels(array_keys($checkins));
-    $graph->xaxis->HideTicks(false,false);
+    $graph->xaxis->HideTicks(false, false);
     $graph->yaxis->scale->SetAutoMin(0);
     $graph->yaxis->HideLine(false);
-    $graph->yaxis->HideTicks(false,false);
+    $graph->yaxis->HideTicks(false, false);
     $graph->xaxis->SetLabelAngle(45);
     $graph->xaxis->SetFont(FF_ARIAL, FS_NORMAL, 10);
     $graph->yaxis->SetFont(FF_ARIAL, FS_NORMAL, 15);
@@ -99,7 +99,7 @@ 
 
     // Create the bar plots
     $plots = [];
-    foreach($accum as $category_key => $category_data) {
+    foreach ($accum as $category_key => $category_data) {
       $bplot = new BarPlot($category_data);
       $color = $category::$colors[$category_key]['color'];
 
@@ -115,7 +115,7 @@ 
 
     // $graph->legend->SetFrameWeight(1);
     $graph->legend->SetColumns(3);
-    $graph->legend->SetColor('#4E4E4E','#00A78A');
+    $graph->legend->SetColor('#4E4E4E', '#00A78A');
 
     $graph->title->SetFont(FF_ARIAL, FS_BOLD, 20);
     $graph->title->Set("Behaviors broken down by Category");
@@ -145,9 +145,9 @@ 
     imagepng($img);
     $img_data = ob_get_clean();
 
-    if($toDisk) {
+    if ($toDisk) {
       $filepath = $this->getFilepath(); 
-      if(!is_dir(dirname($filepath))) {
+      if (!is_dir(dirname($filepath))) {
         mkdir(dirname($filepath), 0766, true);
       }
 

common/tests/unit/components/GraphTest.php

Spacing +7 added lines, -7 removed lines

@@ -14,8 +14,8 @@ 
   use \Codeception\Specify;
 
   private $user;
-  private $filepath = __DIR__.'/../../_output/test_graph.png';
-  private $filepath_extra = __DIR__.'/../../_output/charts/test_graph.png';
+  private $filepath = __DIR__ . '/../../_output/test_graph.png';
+  private $filepath_extra = __DIR__ . '/../../_output/charts/test_graph.png';
 
   public function setUp() {
     $this->user = $this->getMockBuilder('\site\tests\_support\MockUser')
@@ -36,7 +36,7 @@ 
       ->willReturn('random1DH4sh');
     $graph = new Graph($this->user);
 
-    expect('the expected graph image filepath will be returned', $this->assertEquals(dirname(dirname(dirname(dirname(__DIR__)))).'/site/web/charts/random1DH4sh.png', $graph->getFilepath()));
+    expect('the expected graph image filepath will be returned', $this->assertEquals(dirname(dirname(dirname(dirname(__DIR__)))) . '/site/web/charts/random1DH4sh.png', $graph->getFilepath()));
   }
 
   public function testGetUrl() {
@@ -57,7 +57,7 @@ 
       ->method('getFilepath')
       ->willReturn($this->filepath);
 
-    if(!file_exists($this->filepath) && preg_match('%/_output/test_graph.png$%', $this->filepath)) {
+    if (!file_exists($this->filepath) && preg_match('%/_output/test_graph.png$%', $this->filepath)) {
       touch($this->filepath);
       expect('just a check to be sure $filepath is sane', $this->assertStringEndsWith('/_output/test_graph.png', $this->filepath));
       expect('the generated file should exist', $this->assertFileExists($this->filepath));
@@ -89,7 +89,7 @@ 
     expect('the generated file should be readable', $this->assertFileExists($this->filepath_extra));
 
     // cleanup
-    if(file_exists($this->filepath_extra) && preg_match('%/_output/charts/test_graph.png%', $this->filepath_extra)) {
+    if (file_exists($this->filepath_extra) && preg_match('%/_output/charts/test_graph.png%', $this->filepath_extra)) {
       // just in case something is weird, we don't want to straight rm this file
       unlink($this->filepath_extra);
       rmdir(dirname($this->filepath_extra));
@@ -97,7 +97,7 @@ 
   }
 }
 
-function checkinBreakdown () {
+function checkinBreakdown() {
   return [
       '2019-01-31' => [],
       '2019-02-01' => [],
@@ -230,7 +230,7 @@ 
       '2019-02-27' => [],
       '2019-02-28' => [],
       '2019-03-01' => [
-        2 => [ 'name' => 'Forgetting Priorities',
+        2 => ['name' => 'Forgetting Priorities',
         'count' => 6,
         'color' => '#4CA100',
         'highlight' => '#61B219',

site/models/EditProfileForm.php

Indentation +3 added lines, -3 removed lines

@@ -53,8 +53,8 @@ 
   }
 
   /**
-     * @codeCoverageIgnore
-     */
+   * @codeCoverageIgnore
+   */
   public function attributeLabels() {
     return [
       'partner_email1' => "Partner Email #1",
@@ -86,7 +86,7 @@ 
         // generate scores graph image
         $time = Yii::$container->get(\common\interfaces\TimeInterface::class);
         $checkins_last_month = (Yii::$container->get(\common\interfaces\UserBehaviorInterface::class))
-                                               ->getCheckInBreakdown($time->getDateTimesInPeriod());
+                                                ->getCheckInBreakdown($time->getDateTimesInPeriod());
 
         // if they haven't done a check-in in the last month this
         // will explode because $checkinss_last_month is an empty

Spacing +5 added lines, -5 removed lines

@@ -77,10 +77,10 @@ 
       $graph = Yii::$container
         ->get(\common\components\Graph::class, [$this->user]);
 
-      if($this->timezone) {
+      if ($this->timezone) {
         $user->timezone = $this->timezone;
       }
-      if($this->expose_graph) {
+      if ($this->expose_graph) {
         $user->expose_graph = true;
 
         // generate scores graph image
@@ -91,7 +91,7 @@ 
         // if they haven't done a check-in in the last month this
         // will explode because $checkinss_last_month is an empty
         // array
-        if($checkins_last_month) {
+        if ($checkins_last_month) {
           $graph->create($checkins_last_month, true);
         }
       } else {
@@ -99,12 +99,12 @@ 
         // remove scores graph image
         $graph->destroy();
       }
-      if($this->send_email) {
+      if ($this->send_email) {
         $user->send_email = true;
       } else {
         $user->send_email = false;
       }
-      if($this->send_email) {
+      if ($this->send_email) {
         $user->partner_email1  = $this->partner_email1;
         $user->partner_email2  = $this->partner_email2;
         $user->partner_email3  = $this->partner_email3;

site/models/CheckinForm.php

Spacing +9 added lines, -9 removed lines

@@ -64,10 +64,10 @@ 
   }
 
   public function setBehaviors($behaviors) {
-    foreach($behaviors as $category_id => $category_data) {
+    foreach ($behaviors as $category_id => $category_data) {
       $attribute = "behaviors$category_id";
 			$this->$attribute = [];
-      foreach($category_data['behaviors'] as $behavior) {
+      foreach ($category_data['behaviors'] as $behavior) {
         $this->{$attribute}[] = $behavior['id'];
       }
     }   
@@ -75,8 +75,8 @@ 
 
   public function validateBehaviors($attribute, $params) {
     if (!$this->hasErrors()) {
-      foreach($this->$attribute as $behavior) {
-        if(!is_numeric($behavior)) {
+      foreach ($this->$attribute as $behavior) {
+        if (!is_numeric($behavior)) {
           $this->addError($attribute, 'One of your behaviors is not an integer!');
         }
       }
@@ -110,17 +110,17 @@ 
 
     // delete cached scores
     $time = Yii::$container->get(\common\interfaces\TimeInterface::class);
-    $key = "scores_of_last_month_".Yii::$app->user->id."_".$time->getLocalDate();
+    $key = "scores_of_last_month_" . Yii::$app->user->id . "_" . $time->getLocalDate();
     Yii::$app->cache->delete($key);
   }
 
   public function save() {
-    if(empty($this->compiled_behaviors)) {
+    if (empty($this->compiled_behaviors)) {
       $this->commpiled_behaviors = $this->compileBehaviors();
     }
 
     $rows = [];
-    foreach($this->compiled_behaviors as $behavior_id) {
+    foreach ($this->compiled_behaviors as $behavior_id) {
       $temp = [
         Yii::$app->user->id,
         (int)$behavior_id,
@@ -139,11 +139,11 @@ 
       )->execute();
 
     // if the user has publicised their score graph, create the image
-    if(Yii::$app->user->identity->expose_graph) {
+    if (Yii::$app->user->identity->expose_graph) {
       $time = Yii::$container->get(\common\interfaces\TimeInterface::class);
       $checkins_last_month = $this->user_behavior->getCheckInBreakdown($time->getDateTimesInPeriod());
 
-      if($checkins_last_month) {
+      if ($checkins_last_month) {
         Yii::$container
           ->get(\common\components\Graph::class, [Yii::$app->user->identity])
           ->create($checkins_last_month, true);

site/tests/unit/models/EditProfileFormTest.php

Indentation +22 added lines, -22 removed lines

@@ -6,22 +6,22 @@ 
 use \site\models\EditProfileForm;
 
 class EditProfileFormTest extends \Codeception\Test\Unit {
-	public $graph;
-	public $values = [
-			'timezone' => 'America/Los_Angeles',
+  public $graph;
+  public $values = [
+      'timezone' => 'America/Los_Angeles',
       'send_email' => true,
-			'partner_email1' => 'partner1@example.com',
-			'partner_email2' => 'partner2@example.com',
-			'partner_email3' => 'partner3@example.com',
-			'expose_graph' => true,
-		];
+      'partner_email1' => 'partner1@example.com',
+      'partner_email2' => 'partner2@example.com',
+      'partner_email3' => 'partner3@example.com',
+      'expose_graph' => true,
+    ];
 
-	public function setUp() {
-		$this->graph = $this->getMockBuilder(common\components\Graph::class)
-			->setMethods(['create', 'destroy'])
-			->getMock();
-		parent::setUp();
-	}
+  public function setUp() {
+    $this->graph = $this->getMockBuilder(common\components\Graph::class)
+      ->setMethods(['create', 'destroy'])
+      ->getMock();
+    parent::setUp();
+  }
 
   public function testLoadUser() {
     $user = $this->getUser();
@@ -51,20 +51,20 @@ 
     $form->attributes = $this->values;
     expect('saveProfile should return the user', $this->assertEquals($user, $form->saveProfile()));
     return true;
-		expect('saveProfile should set the user\'s attributes to be the form values', $this->assertEquals($this->values, $user->attributes));
+    expect('saveProfile should set the user\'s attributes to be the form values', $this->assertEquals($this->values, $user->attributes));
 
     $form->send_email = 'not_a_boolean';
     expect('saveProfile should return the user with the partner-related settings equal to null', $this->assertNull($form->saveProfile()));
 
-		$null_vals = [
-			'partner_email1'  => null,
-			'partner_email2'  => null,
-			'partner_email3'  => null,
+    $null_vals = [
+      'partner_email1'  => null,
+      'partner_email2'  => null,
+      'partner_email3'  => null,
       'send_email'      => null,
-			'timezone'        => 'America/Los_Angeles',
-		];
+      'timezone'        => 'America/Los_Angeles',
+    ];
     $form->send_email = false;
-		$ret = $form->saveProfile();
+    $ret = $form->saveProfile();
     expect('saveProfile should return the user with the partner-related settings equal to null', $this->assertEquals($null_vals, $user->attributes));
 
     $form->send_email = 'not_a_boolean';

Spacing +3 added lines, -3 removed lines

@@ -41,11 +41,11 @@
 
     // Set up dependency injections
     Yii::$container
-      ->set(\common\interfaces\TimeInterface::class, function () { return new \common\components\Time('UTC'); });
+      ->set(\common\interfaces\TimeInterface::class, function() { return new \common\components\Time('UTC'); });
     Yii::$container
-      ->set(\common\components\Graph::class, function () { return $this->graph; });
+      ->set(\common\components\Graph::class, function() { return $this->graph; });
     Yii::$container
-      ->set(\common\interfaces\UserBehaviorInterface::class, function () { return new FakeUserBehavior(); });
+      ->set(\common\interfaces\UserBehaviorInterface::class, function() { return new FakeUserBehavior(); });
 
     // Actually begin testing
     $form->attributes = $this->values;