ContactFormTest::testSendEmail() - Code Metrics - Inspection of "Adds tests for ContactForm" - CorWatts/fasterscale - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( deefe5...bad3f4 )

by Corey

created 2018-05-28 18:00 UTC

ContactFormTest::testSendEmail() A

↳ Parent: ContactFormTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	15
nc	1
nop	0

<?php

namespace site\tests\unit\models;

use Yii;
use \site\models\ContactForm;

class ContactFormTest extends \Codeception\Test\Unit {

  public function testRules() {
    $form = new ContactForm();

    $form->attributes = [];
    expect('with no values, the form should not pass validation', $this->assertFalse($form->validate()));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

    $form->attributes = [
      'name' => 'Corey',
      'email' => 'not_an-email',
      'subject' => 'a question',
      'body' => 'hello there'
    ];
    expect('with a value that is not an email, the form should not pass validation', $this->assertFalse($form->validate()));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    $form->attributes = [
      'name' => 'Corey',
      'email' => '  [email protected]  ',
      'subject' => 'a question',
      'body' => 'hello there'
    ];
    expect('with a valid email, the form should pass validation', $this->assertTrue($form->validate()));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
  }

  public function testSendEmail() {
    $form = new ContactForm();

    $form->attributes = [
      'name' => 'Corey',
      'email' => '  [email protected]  ',
      'subject' => 'a question',
      'body' => 'hello there'
    ];

    $form->validate();
    $form->sendEmail('[email protected]');

    $this->tester->seeEmailIsSent();

    $emailMessage = $this->tester->grabLastSentEmail();
    expect('valid email is sent', $emailMessage)->isInstanceOf('yii\mail\MessageInterface');
    expect($emailMessage->getTo())->hasKey('[email protected]');
    expect($emailMessage->getFrom())->hasKey('[email protected]');
    expect($emailMessage->getSubject())->equals('[FSA Contact] a question');
    expect($emailMessage->toString())->contains('hello there');
  }
}



1			<?php
2
3			namespace site\tests\unit\models;
4
5			use Yii;
6			use \site\models\ContactForm;
7
8			class ContactFormTest extends \Codeception\Test\Unit {
9
10			public function testRules() {
11			$form = new ContactForm();
12
13			$form->attributes = [];
14			expect('with no values, the form should not pass validation', $this->assertFalse($form->validate()));
			0 ignored issues – show Bug introduced 2018-05-28 18:00 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertFalse($form->validate())` targeting `PHPUnit\Framework\Assert::assertFalse()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
15
16			$form->attributes = [
17			'name' => 'Corey',
18			'email' => 'not_an-email',
19			'subject' => 'a question',
20			'body' => 'hello there'
21			];
22			expect('with a value that is not an email, the form should not pass validation', $this->assertFalse($form->validate()));
			0 ignored issues – show Bug introduced 2018-05-28 18:00 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertFalse($form->validate())` targeting `PHPUnit\Framework\Assert::assertFalse()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
23			$form->attributes = [
24			'name' => 'Corey',
25			'email' => ' [email protected] ',
26			'subject' => 'a question',
27			'body' => 'hello there'
28			];
29			expect('with a valid email, the form should pass validation', $this->assertTrue($form->validate()));
			0 ignored issues – show Bug introduced 2018-05-28 18:00 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertTrue($form->validate())` targeting `PHPUnit\Framework\Assert::assertTrue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
30			}
31
32			public function testSendEmail() {
33			$form = new ContactForm();
34
35			$form->attributes = [
36			'name' => 'Corey',
37			'email' => ' [email protected] ',
38			'subject' => 'a question',
39			'body' => 'hello there'
40			];
41
42			$form->validate();
43			$form->sendEmail('[email protected]');
44
45			$this->tester->seeEmailIsSent();
			0 ignored issues – show Bug Best Practice introduced 2018-05-28 18:00 UTC by Report Bug Copy Issue Report The property `tester` does not exist on `site\tests\unit\models\ContactFormTest`. Did you maybe forget to declare it? Loading history...
46			$emailMessage = $this->tester->grabLastSentEmail();
47			expect('valid email is sent', $emailMessage)->isInstanceOf('yii\mail\MessageInterface');
48			expect($emailMessage->getTo())->hasKey('[email protected]');
49			expect($emailMessage->getFrom())->hasKey('[email protected]');
50			expect($emailMessage->getSubject())->equals('[FSA Contact] a question');
51			expect($emailMessage->toString())->contains('hello there');
52			}
53			}
54
55

CorWatts / fasterscale

Push — master ( deefe5...bad3f4 )

ContactFormTest::testSendEmail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like