Completed
Push — master ( dda5a0...2d250b )
by Corey
03:06
created
common/models/LoginForm.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,10 +60,10 @@
 block discarded – undo
60 60
    */
61 61
   public function login()
62 62
   {
63
-    if($this->validate()) {
63
+    if ($this->validate()) {
64 64
       $user = $this->getUser();
65
-      if($user->isVerified()) {
66
-        return Yii::$app->user->login($user, $this->rememberMe ? 3600 * 24 * 30 : 0);
65
+      if ($user->isVerified()) {
66
+        return Yii::$app->user->login($user, $this->rememberMe ? 3600*24*30 : 0);
67 67
       } else {
68 68
         Yii::$app->session->setFlash('warning', 'You must verify your account before you can proceed. Please check your email inbox for a verification email and follow the instructions.');
69 69
       }
Please login to merge, or discard this patch.
common/models/Category.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,13 +12,13 @@
 block discarded – undo
12 12
 class Category extends \yii\base\BaseObject implements \common\interfaces\CategoryInterface {
13 13
 
14 14
   public static $categories = [
15
-    [ "id" => 1, "name" => "Restoration"],
16
-    [ "id" => 2, "name" => "Forgetting Priorities"],
17
-    [ "id" => 3, "name" => "Anxiety"],
18
-    [ "id" => 4, "name" => "Speeding Up"],
19
-    [ "id" => 5, "name" => "Ticked Off"],
20
-    [ "id" => 6, "name" => "Exhausted"],
21
-    [ "id" => 7, "name" => "Relapse/Moral Failure"],
15
+    ["id" => 1, "name" => "Restoration"],
16
+    ["id" => 2, "name" => "Forgetting Priorities"],
17
+    ["id" => 3, "name" => "Anxiety"],
18
+    ["id" => 4, "name" => "Speeding Up"],
19
+    ["id" => 5, "name" => "Ticked Off"],
20
+    ["id" => 6, "name" => "Exhausted"],
21
+    ["id" => 7, "name" => "Relapse/Moral Failure"],
22 22
   ];
23 23
 
24 24
   public static $colors = [
Please login to merge, or discard this patch.
common/config/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -10,8 +10,8 @@  discard block
 block discarded – undo
10 10
       'common\interfaces\QuestionInterface' => \common\models\Question::class,
11 11
       'common\interfaces\BehaviorInterface' => \common\models\Behavior::class,
12 12
       'common\interfaces\CategoryInterface' => \common\models\Category::class,
13
-      'common\interfaces\TimeInterface' => function () {
14
-        if(Yii::$app->user->getIsGuest()) {
13
+      'common\interfaces\TimeInterface' => function() {
14
+        if (Yii::$app->user->getIsGuest()) {
15 15
           return new \common\components\Time('UTC');
16 16
         } else {
17 17
           return new \common\components\Time(Yii::$app->user->identity->timezone);
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
   ],
29 29
   'components' => [
30 30
     // by default, sessions are stored in a local file
31
-    'cache' => [ // DummyCache never actually caches anything
31
+    'cache' => [// DummyCache never actually caches anything
32 32
       'class'=> yii\caching\DummyCache::class,
33 33
     ],
34 34
     'mailer' => [
Please login to merge, or discard this patch.
common/tests/unit/components/GraphTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
   use \Codeception\Specify;
15 15
 
16 16
   private $user;
17
-  private $filepath = __DIR__.'/../../_output/test_graph.png';
18
-  private $filepath_extra = __DIR__.'/../../_output/charts/test_graph.png';
17
+  private $filepath = __DIR__ . '/../../_output/test_graph.png';
18
+  private $filepath_extra = __DIR__ . '/../../_output/charts/test_graph.png';
19 19
 
20 20
   public function setUp() {
21 21
     $this->user = $this->getMockBuilder('\site\tests\_support\MockUser')
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
       ->willReturn('random1DH4sh');
37 37
     $graph = new Graph($this->user);
38 38
 
39
-    expect('the expected graph image filepath will be returned', $this->assertEquals(dirname(dirname(dirname(dirname(__DIR__)))).'/site/web/charts/random1DH4sh.png', $graph->getFilepath()));
39
+    expect('the expected graph image filepath will be returned', $this->assertEquals(dirname(dirname(dirname(dirname(__DIR__)))) . '/site/web/charts/random1DH4sh.png', $graph->getFilepath()));
40 40
   }
41 41
 
42 42
   public function testGetUrl() {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
       ->method('getFilepath')
58 58
       ->willReturn($this->filepath);
59 59
 
60
-    if(!file_exists($this->filepath) && preg_match('%/_output/test_graph.png$%', $this->filepath)) {
60
+    if (!file_exists($this->filepath) && preg_match('%/_output/test_graph.png$%', $this->filepath)) {
61 61
       touch($this->filepath);
62 62
       expect('just a check to be sure $filepath is sane', $this->assertStringEndsWith('/_output/test_graph.png', $this->filepath));
63 63
       expect('the generated file should exist', $this->assertFileExists($this->filepath));
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
     expect('the generated file should be readable', $this->assertFileExists($this->filepath_extra));
90 90
 
91 91
     // cleanup
92
-    if(file_exists($this->filepath_extra) && preg_match('%/_output/charts/test_graph.png%', $this->filepath_extra)) {
92
+    if (file_exists($this->filepath_extra) && preg_match('%/_output/charts/test_graph.png%', $this->filepath_extra)) {
93 93
       // just in case something is weird, we don't want to straight rm this file
94 94
       unlink($this->filepath_extra);
95 95
       rmdir(dirname($this->filepath_extra));
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
   }
98 98
 }
99 99
 
100
-function checkinBreakdown () {
100
+function checkinBreakdown() {
101 101
   return [
102 102
       '2019-01-31' => [],
103 103
       '2019-02-01' => [],
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
       '2019-02-27' => [],
231 231
       '2019-02-28' => [],
232 232
       '2019-03-01' => [
233
-        2 => [ 'name' => 'Forgetting Priorities',
233
+        2 => ['name' => 'Forgetting Priorities',
234 234
         'count' => 6,
235 235
         'color' => '#4CA100',
236 236
         'highlight' => '#61B219',
Please login to merge, or discard this patch.
site/tests/unit/models/EditProfileFormTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -41,11 +41,11 @@
 block discarded – undo
41 41
 
42 42
     // Set up dependency injections
43 43
     Yii::$container
44
-      ->set(\common\interfaces\TimeInterface::class, function () { return new \common\components\Time('UTC'); });
44
+      ->set(\common\interfaces\TimeInterface::class, function() { return new \common\components\Time('UTC'); });
45 45
     Yii::$container
46
-      ->set(\common\components\Graph::class, function () { return $this->graph; });
46
+      ->set(\common\components\Graph::class, function() { return $this->graph; });
47 47
     Yii::$container
48
-      ->set(\common\interfaces\UserBehaviorInterface::class, function () { return new FakeUserBehavior(); });
48
+      ->set(\common\interfaces\UserBehaviorInterface::class, function() { return new FakeUserBehavior(); });
49 49
 
50 50
     // Actually begin testing
51 51
     $form->attributes = $this->values;
Please login to merge, or discard this patch.
common/tests/unit/data/behaviorsWithCounts.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -337,7 +337,7 @@
 block discarded – undo
337 337
   ], [
338 338
   ], [
339 339
   ], [
340
-  ], [ [
340
+  ], [[
341 341
       'user_id' => 1,
342 342
       'behavior_id' => 117,
343 343
       'count' => 1,
Please login to merge, or discard this patch.
common/tests/unit/models/UserBehaviorTest.php 2 patches
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -105,19 +105,19 @@  discard block
 block discarded – undo
105 105
     expect('decorate should add Behavior data and Category data to an array of UserBehaviors',
106 106
       $this->assertEquals(
107 107
         $this->user_behavior->decorateWithCategory($this->singleSimpleBehaviorNoBehavior),
108
-         [['id' => 396,
109
-           'user_id' => 2,
110
-           'behavior_id' => 107,
111
-           'date' => '2016-06-17 04:12:43',
112
-           'behavior' => [
113
-             'id' => 107,
114
-             'name' => 'numb',
115
-             'category_id' => 6,
116
-             'category' => [
117
-               'id' => 6,
118
-               'name' => 'Exhausted',
119
-             ]
120
-           ]]]));
108
+          [['id' => 396,
109
+            'user_id' => 2,
110
+            'behavior_id' => 107,
111
+            'date' => '2016-06-17 04:12:43',
112
+            'behavior' => [
113
+              'id' => 107,
114
+              'name' => 'numb',
115
+              'category_id' => 6,
116
+              'category' => [
117
+                'id' => 6,
118
+                'name' => 'Exhausted',
119
+              ]
120
+            ]]]));
121 121
   }
122 122
 
123 123
   public function testGetBehaviorsByCategory() {
@@ -198,6 +198,6 @@  discard block
 block discarded – undo
198 198
     $bhvrs = require(__DIR__.'/../data/behaviorsWithCounts.php');
199 199
     $expected = require(__DIR__.'/../data/expected_getCheckinBreakdown.php');
200 200
     $this->user_behavior->method('getBehaviorsWithCounts')->willReturn(...$bhvrs);
201
-		expect('asdf', $this->assertEquals($expected, $this->user_behavior->getCheckinBreakdown()));
201
+    expect('asdf', $this->assertEquals($expected, $this->user_behavior->getCheckinBreakdown()));
202 202
   }
203 203
 }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
   ]; 
34 34
   public function setUp() {
35 35
     // pull in test data
36
-    $data = require(__DIR__.'/../data/checkinData.php');
36
+    $data = require(__DIR__ . '/../data/checkinData.php');
37 37
     $this->singleBhvr = $data['singleBhvr'];
38 38
     $this->manyBhvrs = $data['manyBhvrs'];
39 39
     $this->allBhvrs = $data['allBhvrs'];
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     $this->container->set('common\interfaces\UserInterface', '\site\tests\_support\MockUser');
44 44
     $this->container->set('common\interfaces\QuestionInterface', '\site\tests\_support\MockQuestion');
45 45
     $this->container->set('common\interfaces\BehaviorInterface', 'common\models\Behavior');
46
-    $this->container->set('common\interfaces\TimeInterface', function () {
46
+    $this->container->set('common\interfaces\TimeInterface', function() {
47 47
         return new \common\components\Time('America/Los_Angeles');
48 48
       });
49 49
 
@@ -195,8 +195,8 @@  discard block
 block discarded – undo
195 195
                             ->setMethods(['getIsNewRecord', 'save', 'getBehaviorsByDate', 'getBehaviorsWithCounts'])
196 196
                             ->getMock();
197 197
 
198
-    $bhvrs = require(__DIR__.'/../data/behaviorsWithCounts.php');
199
-    $expected = require(__DIR__.'/../data/expected_getCheckinBreakdown.php');
198
+    $bhvrs = require(__DIR__ . '/../data/behaviorsWithCounts.php');
199
+    $expected = require(__DIR__ . '/../data/expected_getCheckinBreakdown.php');
200 200
     $this->user_behavior->method('getBehaviorsWithCounts')->willReturn(...$bhvrs);
201 201
 		expect('asdf', $this->assertEquals($expected, $this->user_behavior->getCheckinBreakdown()));
202 202
   }
Please login to merge, or discard this patch.
common/mail/checkinReport.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -124,14 +124,14 @@  discard block
 block discarded – undo
124 124
                                                 <th style="Margin:0;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left">
125 125
 
126 126
 <?php
127
-if($questions) {
128
-  foreach($questions as $behavior_id => $behavior_questions) {
127
+if ($questions) {
128
+  foreach ($questions as $behavior_id => $behavior_questions) {
129 129
 ?>
130 130
 
131 131
                                                    <h4 style="Margin:0;Margin-bottom:10px;color:#37b98f;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:24px;font-weight:400;line-height:1.3;margin:0;margin-bottom:5px;padding:0 8px;text-align:left;word-wrap:normal"> <?= $behavior_questions['question']['title'] ?> </h4>
132 132
 
133 133
 <?php
134
-    foreach($behavior_questions['answers'] as $key => $question) {  ?>
134
+    foreach ($behavior_questions['answers'] as $key => $question) {  ?>
135 135
       <p style="Margin:0;Margin-bottom:10px;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0 8px 4px 8px;text-align:left"><strong><?=$question['title']?></strong> <?=$question['answer']?></p>
136 136
 <?php
137 137
     }
@@ -188,12 +188,12 @@  discard block
 block discarded – undo
188 188
                                                 <th style="Margin:0;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left">
189 189
 
190 190
 <?php
191
-if($user_behaviors) {
192
-  foreach($user_behaviors as $user_behavior) { ?>
191
+if ($user_behaviors) {
192
+  foreach ($user_behaviors as $user_behavior) { ?>
193 193
         <p style="Margin:0;Margin-bottom:10px;color:#0a0a0a;font-family:Arial,Verdana,Helvetica,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0 8px 4px 8px;text-align:left">
194 194
           <strong style="color:#37b98f"><?= $user_behavior['category_name'] ?></strong>
195 195
 <?php
196
-    foreach($user_behavior['behaviors'] as $behavior) { ?>
196
+    foreach ($user_behavior['behaviors'] as $behavior) { ?>
197 197
         <br><?= $behavior['name'] ?>
198 198
 <?php
199 199
     }
Please login to merge, or discard this patch.
common/components/Graph.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
   public function getFilepath() {
29 29
     $path = Yii::getAlias('@graphImgPath');
30 30
     $filename = $this->user->getIdHash() . ".png";
31
-    return $path. '/' . $filename;
31
+    return $path . '/' . $filename;
32 32
   }
33 33
 
34 34
   /**
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
    * @return string the encoded image
62 62
    */
63 63
   public function create(array $checkins, bool $toDisk = false) {
64
-    if($toDisk) {
64
+    if ($toDisk) {
65 65
       // wipe out the current image, if it exists
66 66
       $this->destroy();
67 67
     }
@@ -81,11 +81,11 @@  discard block
 block discarded – undo
81 81
 
82 82
     // Setup dates as labels on the X-axis
83 83
     $graph->xaxis->SetTickLabels(array_keys($checkins));
84
-    $graph->xaxis->HideTicks(false,false);
84
+    $graph->xaxis->HideTicks(false, false);
85 85
 
86 86
     $graph->yaxis->scale->SetAutoMin(0);
87 87
     $graph->yaxis->HideLine(false);
88
-    $graph->yaxis->HideTicks(false,false);
88
+    $graph->yaxis->HideTicks(false, false);
89 89
     $graph->xaxis->SetLabelAngle(45);
90 90
     $graph->xaxis->SetFont(FF_ARIAL, FS_NORMAL, 10);
91 91
     $graph->yaxis->SetFont(FF_ARIAL, FS_NORMAL, 15);
@@ -93,8 +93,8 @@  discard block
 block discarded – undo
93 93
 
94 94
     // format the data into something nicer
95 95
     $accum = [];
96
-    foreach($checkins as $checkin_sum) {
97
-      for($i = 1; $i <= 7; $i ++) {
96
+    foreach ($checkins as $checkin_sum) {
97
+      for ($i = 1; $i <= 7; $i++) {
98 98
         $accum[$i][] = array_key_exists($i, $checkin_sum) ? $checkin_sum[$i]['count'] : 0;
99 99
       }
100 100
     }
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     // Create the bar plots
103 103
     $plots = [];
104 104
     $category = Yii::$container->get(\common\interfaces\CategoryInterface::class);
105
-    foreach($accum as $category_key => $category_data) {
105
+    foreach ($accum as $category_key => $category_data) {
106 106
       $bplot = new BarPlot($category_data);
107 107
       $color = $category::$colors[$category_key]['color'];
108 108
 
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
     $graph->Add($gbbplot);
118 118
 
119 119
     $graph->legend->SetColumns(3);
120
-    $graph->legend->SetPos(0.5,0.98,'center','bottom'); // position it at the center, just above the bottom edge
120
+    $graph->legend->SetPos(0.5, 0.98, 'center', 'bottom'); // position it at the center, just above the bottom edge
121 121
 
122 122
     $img = $graph->Stroke(_IMG_HANDLER);
123 123
 
@@ -125,9 +125,9 @@  discard block
 block discarded – undo
125 125
     imagepng($img);
126 126
     $img_data = ob_get_clean();
127 127
 
128
-    if($toDisk) {
128
+    if ($toDisk) {
129 129
       $filepath = $this->getFilepath(); 
130
-      if(!is_dir(dirname($filepath))) {
130
+      if (!is_dir(dirname($filepath))) {
131 131
         mkdir(dirname($filepath), 0766, true);
132 132
       }
133 133
 
Please login to merge, or discard this patch.