UserBehaviorTest::testDecorate() - Code Metrics - Inspection of "WIP: Rip out score" - CorWatts/fasterscale - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#163)

by Corey

created 2019-02-10 16:20 UTC

UserBehaviorTest::testDecorate() A

↳ Parent: UserBehaviorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	19
c	0
b	0
f	0
rs	9.7333
cc	1
nc	1
nop	0

<?php

namespace common\unit\models;

use Yii;
use Codeception\Specify;

date_default_timezone_set('UTC');

/**
 * Time test
 */

class UserBehaviorTest extends \Codeception\Test\Unit {
  use Specify;

  public $singleSimpleBehaviorNoBehavior = [
    [
      'id' => 396,
      'user_id' => 2,
      'behavior_id' => 107,
      'date' => '2016-06-17 04:12:43',
    ],
  ]; 

  public $badSingleSimpleBehaviorNoBehavior = [
    [
      'id' => 396,
      'user_id' => 2,
      'behavior_id' => 99999,
      'date' => '2016-06-17 04:12:43',
    ],
  ]; 
  public function setUp() {
    // pull in test data
    $data = require(__DIR__.'/../data/checkinData.php');
    $this->singleBhvr = $data['singleBhvr'];

    $this->manyBhvrs = $data['manyBhvrs'];

    $this->allBhvrs = $data['allBhvrs'];

    $this->multipleDates = $data['multipleDates'];


    $this->container = new \yii\di\Container;

    $this->container->set('common\interfaces\UserInterface', '\site\tests\_support\MockUser');
    $this->container->set('common\interfaces\QuestionInterface', '\site\tests\_support\MockQuestion');
    $this->container->set('common\interfaces\BehaviorInterface', 'common\models\Behavior');
    $this->container->set('common\interfaces\TimeInterface', function () {
        return new \common\components\Time('America/Los_Angeles');
      });

    $time = $this->container->get('common\interfaces\TimeInterface');
    $behavior = $this->container->get('common\interfaces\BehaviorInterface');
    $user = $this->container->get('common\interfaces\UserInterface');


    $this->user_behavior = $this

                            ->getMockBuilder("common\models\UserBehavior")
                            ->setConstructorArgs([$behavior, $time])
                            ->setMethods(['getIsNewRecord', 'save', 'getBehaviorsByDate', 'getBehaviorsWithCounts'])
                            ->getMock();
    parent::setUp();
  }

  protected function tearDown() {
    $this->user_behavior = null;

    parent::tearDown();
  }

  public function testRules() {
    expect('rules', $this->assertEquals($this->user_behavior->rules(), [
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      [['user_id', 'behavior_id', 'date'], 'required'],
      [['user_id', 'behavior_id'], 'integer'],
    ]));
  }

  public function testAttributeLabels() {
    expect('attributeLabels', $this->assertEquals($this->user_behavior->attributelabels(), [
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      'id'        => 'ID',
      'date'      => 'Date',
      'user_id'   => 'User ID',
      'behavior_id' => 'Behavior ID',
    ]));
  }

  public function testDecorate() {
    expect('decorate should add Behavior data to an array of UserBehaviors', $this->assertEquals($this->user_behavior->decorate($this->singleSimpleBehaviorNoBehavior),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                    [['id' => 396,
                      'user_id' => 2,
                      'behavior_id' => 107,
                      'date' => '2016-06-17 04:12:43',
                      'behavior' => [
                        'id' => 107,
                        'name' => 'numb',
                        'category_id' => 6,
                      ]]]));

    expect('decorate SHOULD NOT add Behavior data when the provided behavior_id is invalid',
      $this->assertEquals(
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->user_behavior->decorate($this->badSingleSimpleBehaviorNoBehavior),
        [['id' => 396,
          'user_id' => 2,
          'behavior_id' => 99999,
          'date' => '2016-06-17 04:12:43']]));
  }

  public function testDecorateWithCategory() {
    expect('decorate should add Behavior data and Category data to an array of UserBehaviors',
      $this->assertEquals(
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->user_behavior->decorateWithCategory($this->singleSimpleBehaviorNoBehavior),
         [['id' => 396,
           'user_id' => 2,
           'behavior_id' => 107,
           'date' => '2016-06-17 04:12:43',
           'behavior' => [
             'id' => 107,
             'name' => 'numb',
             'category_id' => 6,
             'category' => [
               'id' => 6,
               'name' => 'Exhausted',
             ]
           ]]]));
  }

  public function testGetBehaviorsByCategory() {
    expect('getBehaviorsByCategory to return the empty array if the user has not logged any behaviors', $this->assertEquals([], $this->user_behavior->getBehaviorsByCategory($this->user_behavior::decorateWithCategory([]))));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    expect('getBehaviorsByCategory to return the empty array if the user has not logged any behaviors', $this->assertEquals([
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      1 => [
        'name' => 'Restoration',
        'count' => 5,
        'color' => '#008000',
        'highlight' => '#199919'
      ],
      2 => [
        'name' => 'Forgetting Priorities',
        'count' => 4,
        'color' => '#4CA100',
        'highlight' => '#61B219'
      ],
      4 => [
        'name' => 'Speeding Up',
        'count' => 3,
        'color' => '#E5E500',
        'highlight' => '#E5E533'
      ]
    ], $this->user_behavior->getBehaviorsByCategory($this->user_behavior::decorateWithCategory([
        [
          'user_id' => 1,
          'behavior_id' => 1,
          'count' => 5
        ], [
          'user_id' => 1,
          'behavior_id' => 20,
          'count' => 4
        ], [
          'user_id' => 1,
          'behavior_id' => 50,
          'count' => 3
        ]
      ]))));
  }
}


1			<?php
2
3			namespace common\unit\models;
4
5			use Yii;
6			use Codeception\Specify;
7
8			date_default_timezone_set('UTC');
9
10			/**
11			* Time test
12			*/
13
14			class UserBehaviorTest extends \Codeception\Test\Unit {
15			use Specify;
16
17			public $singleSimpleBehaviorNoBehavior = [
18			[
19			'id' => 396,
20			'user_id' => 2,
21			'behavior_id' => 107,
22			'date' => '2016-06-17 04:12:43',
23			],
24			];
25
26			public $badSingleSimpleBehaviorNoBehavior = [
27			[
28			'id' => 396,
29			'user_id' => 2,
30			'behavior_id' => 99999,
31			'date' => '2016-06-17 04:12:43',
32			],
33			];
34			public function setUp() {
35			// pull in test data
36			$data = require(__DIR__.'/../data/checkinData.php');
37			$this->singleBhvr = $data['singleBhvr'];
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `singleBhvr` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
38			$this->manyBhvrs = $data['manyBhvrs'];
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `manyBhvrs` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
39			$this->allBhvrs = $data['allBhvrs'];
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `allBhvrs` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
40			$this->multipleDates = $data['multipleDates'];
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `multipleDates` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
41
42			$this->container = new \yii\di\Container;
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `container` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
43			$this->container->set('common\interfaces\UserInterface', '\site\tests\_support\MockUser');
44			$this->container->set('common\interfaces\QuestionInterface', '\site\tests\_support\MockQuestion');
45			$this->container->set('common\interfaces\BehaviorInterface', 'common\models\Behavior');
46			$this->container->set('common\interfaces\TimeInterface', function () {
47			return new \common\components\Time('America/Los_Angeles');
48			});
49
50			$time = $this->container->get('common\interfaces\TimeInterface');
51			$behavior = $this->container->get('common\interfaces\BehaviorInterface');
52			$user = $this->container->get('common\interfaces\UserInterface');
			0 ignored issues – show Unused Code introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The assignment to `$user` is dead and can be removed. Loading history...
53
54			$this->user_behavior = $this
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `user_behavior` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
55			->getMockBuilder("common\models\UserBehavior")
56			->setConstructorArgs([$behavior, $time])
57			->setMethods(['getIsNewRecord', 'save', 'getBehaviorsByDate', 'getBehaviorsWithCounts'])
58			->getMock();
59			parent::setUp();
60			}
61
62			protected function tearDown() {
63			$this->user_behavior = null;
			0 ignored issues – show Bug Best Practice introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report The property `user_behavior` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
64			parent::tearDown();
65			}
66
67			public function testRules() {
68			expect('rules', $this->assertEquals($this->user_behavior->rules(), [
			0 ignored issues – show Bug introduced 2019-02-07 15:51 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals($thi...vior_id'), 'integer')))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
69			[['user_id', 'behavior_id', 'date'], 'required'],
70			[['user_id', 'behavior_id'], 'integer'],
71			]));
72			}
73
74			public function testAttributeLabels() {
75			expect('attributeLabels', $this->assertEquals($this->user_behavior->attributelabels(), [
			0 ignored issues – show Bug introduced 2019-02-07 15:51 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals($thi..._id' => 'Behavior ID'))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
76			'id' => 'ID',
77			'date' => 'Date',
78			'user_id' => 'User ID',
79			'behavior_id' => 'Behavior ID',
80			]));
81			}
82
83			public function testDecorate() {
84			expect('decorate should add Behavior data to an array of UserBehaviors', $this->assertEquals($this->user_behavior->decorate($this->singleSimpleBehaviorNoBehavior),
			0 ignored issues – show Bug introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals($thi... 'category_id' => 6))))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
85			[['id' => 396,
86			'user_id' => 2,
87			'behavior_id' => 107,
88			'date' => '2016-06-17 04:12:43',
89			'behavior' => [
90			'id' => 107,
91			'name' => 'numb',
92			'category_id' => 6,
93			]]]));
94
95			expect('decorate SHOULD NOT add Behavior data when the provided behavior_id is invalid',
96			$this->assertEquals(
			0 ignored issues – show Bug introduced 2018-04-09 21:16 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals($thi...2016-06-17 04:12:43')))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
97			$this->user_behavior->decorate($this->badSingleSimpleBehaviorNoBehavior),
98			[['id' => 396,
99			'user_id' => 2,
100			'behavior_id' => 99999,
101			'date' => '2016-06-17 04:12:43']]));
102			}
103
104			public function testDecorateWithCategory() {
105			expect('decorate should add Behavior data and Category data to an array of UserBehaviors',
106			$this->assertEquals(
			0 ignored issues – show Bug introduced 2018-05-15 07:40 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals($thi...me' => 'Exhausted')))))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
107			$this->user_behavior->decorateWithCategory($this->singleSimpleBehaviorNoBehavior),
108			[['id' => 396,
109			'user_id' => 2,
110			'behavior_id' => 107,
111			'date' => '2016-06-17 04:12:43',
112			'behavior' => [
113			'id' => 107,
114			'name' => 'numb',
115			'category_id' => 6,
116			'category' => [
117			'id' => 6,
118			'name' => 'Exhausted',
119			]
120			]]]));
121			}
122
123			public function testGetBehaviorsByCategory() {
124			expect('getBehaviorsByCategory to return the empty array if the user has not logged any behaviors', $this->assertEquals([], $this->user_behavior->getBehaviorsByCategory($this->user_behavior::decorateWithCategory([]))));
			0 ignored issues – show Bug introduced 2019-02-07 15:51 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals(arra...WithCategory(array())))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
125			expect('getBehaviorsByCategory to return the empty array if the user has not logged any behaviors', $this->assertEquals([
			0 ignored issues – show Bug introduced 2019-02-07 15:51 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->assertEquals(arra...> 50, 'count' => 3)))))` targeting `PHPUnit\Framework\Assert::assertEquals()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
126			1 => [
127			'name' => 'Restoration',
128			'count' => 5,
129			'color' => '#008000',
130			'highlight' => '#199919'
131			],
132			2 => [
133			'name' => 'Forgetting Priorities',
134			'count' => 4,
135			'color' => '#4CA100',
136			'highlight' => '#61B219'
137			],
138			4 => [
139			'name' => 'Speeding Up',
140			'count' => 3,
141			'color' => '#E5E500',
142			'highlight' => '#E5E533'
143			]
144			], $this->user_behavior->getBehaviorsByCategory($this->user_behavior::decorateWithCategory([
145			[
146			'user_id' => 1,
147			'behavior_id' => 1,
148			'count' => 5
149			], [
150			'user_id' => 1,
151			'behavior_id' => 20,
152			'count' => 4
153			], [
154			'user_id' => 1,
155			'behavior_id' => 50,
156			'count' => 3
157			]
158			]))));
159			}
160			}
161

CorWatts / fasterscale

Pull Request — master (#163)

UserBehaviorTest::testDecorate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like