CustomBehaviorForm::rules() - Code Metrics - Inspection of "Fixes 68: Adds custom behaviors" - CorWatts/fasterscale - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#178)

by Corey

created 2019-11-07 04:12 UTC

CustomBehaviorForm::rules() A

↳ Parent: CustomBehaviorForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	5
c	1
b	0
f	0
dl	0
loc	6
rs	10
cc	1
nc	1
nop	0

<?php
namespace site\models;

use common\models\User;
use yii\base\Model;
use Yii;

/**
 * custom behavior form
 */
class CustomBehaviorForm extends Model {
  public $name;
  public $category_id;

  private $user;
  private $categories;

  /**
   * Creates a form model
   *
   * @param  object $user
   * @param  array  $config name-value pairs that will be used to initialize the object properties
   */
  public function __construct(\common\interfaces\UserInterface $user, \common\interfaces\CategoryInterface $category, $config = []) {
    $this->user = $user;
    $this->categories = $category->categories;

    parent::__construct($config);
  }

  /**
   * @inheritdoc
   */
  public function rules() {
    return [
      [['name', 'category_id'], 'required'],
      ['name', 'filter', 'filter' => 'trim'],
      ['category_id', 'integer'],
      ['category_id', 'in', 'range'=>array_keys($this->categories)],

    ];
  }

  /**
   * @codeCoverageIgnore
   */
  public function attributeLabels() {
    return [
      'name'        => 'Behavior Name',
      'category_id' => 'Behavior Category',
      ];
  }


  public function save() {
    $custom_behavior = Yii::$container->get(\common\interfaces\CustomBehaviorInterface::class);
    $custom_behavior->name = $this->name;
    $custom_behavior->user_id = $this->user->id;

    $custom_behavior->category_id = $this->category_id;
    return $custom_behavior->save();
  }
}


1			<?php
2			namespace site\models;
3
4			use common\models\User;
5			use yii\base\Model;
6			use Yii;
7
8			/**
9			* custom behavior form
10			*/
11			class CustomBehaviorForm extends Model {
12			public $name;
13			public $category_id;
14
15			private $user;
16			private $categories;
17
18			/**
19			* Creates a form model
20			*
21			* @param object $user
22			* @param array $config name-value pairs that will be used to initialize the object properties
23			*/
24			public function __construct(\common\interfaces\UserInterface $user, \common\interfaces\CategoryInterface $category, $config = []) {
25			$this->user = $user;
26			$this->categories = $category->categories;
			0 ignored issues – show Bug introduced 2019-09-29 22:32 UTC by Report Bug Copy Issue Report Accessing `categories` on the interface `common\interfaces\CategoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
27			parent::__construct($config);
28			}
29
30			/**
31			* @inheritdoc
32			*/
33			public function rules() {
34			return [
35			[['name', 'category_id'], 'required'],
36			['name', 'filter', 'filter' => 'trim'],
37			['category_id', 'integer'],
38			['category_id', 'in', 'range'=>array_keys($this->categories)],
39
40			];
41			}
42
43			/**
44			* @codeCoverageIgnore
45			*/
46			public function attributeLabels() {
47			return [
48			'name' => 'Behavior Name',
49			'category_id' => 'Behavior Category',
50			];
51			}
52
53
54			public function save() {
55			$custom_behavior = Yii::$container->get(\common\interfaces\CustomBehaviorInterface::class);
56			$custom_behavior->name = $this->name;
57			$custom_behavior->user_id = $this->user->id;
			0 ignored issues – show Bug introduced 2019-09-29 22:32 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `common\interfaces\UserInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
58			$custom_behavior->category_id = $this->category_id;
59			return $custom_behavior->save();
60			}
61			}
62

CorWatts / fasterscale

Pull Request — master (#178)

CustomBehaviorForm::rules() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like