site\controllers\CheckinController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	11	1
B	actionView()	0	30	3
A	actionIndex()	0	21	4
B	actionQuestions()	0	32	6
A	actionReport()	0	8	1

<?php

namespace site\controllers;

use Yii;
use common\models\Category;
use common\models\Behavior;
use common\interfaces\UserInterface;
use common\interfaces\UserBehaviorInterface;
use common\Interfaces\TimeInterface;
use yii\di\Container;
use yii\base\InvalidParamException;
use yii\web\BadRequestHttpException;
use yii\web\Controller;
use yii\filters\VerbFilter;
use common\components\AccessControl;
use yii\helpers\ArrayHelper as AH;

class CheckinController extends \yii\web\Controller
{
  public function behaviors()
  {
    return [
      'access' => [
        'class' => AccessControl::class,
        'only' => ['index', 'view', 'questions', 'report'],
        'rules' => [
          [
            'actions' => ['index', 'view', 'questions', 'report'],
            'allow' => true,
            'roles' => ['@'],
          ],
        ],
      ],
    ];
  }
  public function actionIndex() {
    $form = Yii::$container->get(\site\models\CheckinForm::class);
    if ($form->load(Yii::$app->request->post()) && $form->validate()) {
      $form->compiled_behaviors = $form->compileBehaviors();

      if(sizeof($form->compiled_behaviors) === 0) {
        return $this->redirect(['view']);
      }

      // we only store one data set per day, so wipe out previously saved ones
      $form->deleteToday();
      $form->save();

      return $this->redirect(['questions']);
    } else {
      $category = Yii::$container->get(\common\interfaces\CategoryInterface::class);
      $behavior = Yii::$container->get(\common\interfaces\BehaviorInterface::class);
      return $this->render('index', [
        'categories'    => $category::$categories,
        'model'         => $form,
        'behaviorsList' => AH::index($behavior::$behaviors, null, "category_id")
      ]);
    }
  }

  public function actionQuestions()
  {
    $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
    $date = Yii::$container->get(\common\interfaces\TimeInterface::class)->getLocalDate();

    $user_behaviors = $user_behavior->getUserBehaviorsWithCategory($date);
    if(count($user_behaviors) === 0) {
      return $this->redirect(['view']);
    }

    $form = Yii::$container->get(\site\models\QuestionForm::class);
    if ($form->load(Yii::$app->request->post()) && $form->validate()) {
      // we only store one data set per day so clear out any previously saved ones
      $form->deleteToday();

      $behaviors = $user_behavior->findAll($form->getUserBehaviorIds());
      if($result = $form->saveAnswers($behaviors)) {

The assignment to $result is dead and can be removed.

        if(Yii::$app->user->identity->send_email) {

Accessing send_email on the interface yii\web\IdentityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

          Yii::$app->user->identity->sendEmailReport($date);

The method sendEmailReport() does not exist on null.

The method sendEmailReport() does not exist on yii\web\IdentityInterface. It seems like you code against a sub-type of said class. However, the method does not exist in site\tests\_support\MockUser. Are you sure you never get one of those?

          Yii::$app->session->setFlash('success', 'Your check-in is complete. A notification has been sent to your report partners.');

The method setFlash() does not exist on null.

        } else {
          Yii::$app->session->setFlash('success', 'Your check-in is complete.');
        }

        return $this->redirect(['view']);
      }
    }

    return $this->render('questions', [
      'model' => $form,
      'behaviors' => $user_behaviors
    ]);	
  }

  public function actionView(string $date = null)
  {
    $time = Yii::$container->get(\common\interfaces\TimeInterface::class);
    if(is_null($date)) {
      $date = $time->getLocalDate();
    } else if($dt = $time->parse($date)) {
      $date = $dt->format('Y-m-d');
    } else {
      $date = $time->getLocalDate();
    }
    $dt = $time->parse($date);
    list($start, $end) = $time->getUTCBookends($date);

This list assign is not used and could be removed.

    $user          = Yii::$container->get(\common\interfaces\UserInterface::class);
    $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
    $category      = Yii::$container->get(\common\interfaces\CategoryInterface::class);
    $behavior      = Yii::$container->get(\common\interfaces\BehaviorInterface::class);

    $form = Yii::$container->get(\site\models\CheckinForm::class);
    $form->setBehaviors($user->getUserBehaviors($date));

    return $this->render('view', [
      'model'              => $form,
      'actual_date'        => $date,
      'categories'         => $category::$categories,
      'behaviorsList'      => AH::index($behavior::$behaviors, 'name', "category_id"),
      'past_checkin_dates' => $user_behavior->getPastCheckinDates(),
      'answer_pie'         => $user_behavior->getBehaviorsByCategory($dt),
      'questions'          => $user->getUserQuestions($date),
      'isToday'            => $time->getLocalDate() === $date,
    ]);
  }

  public function actionReport() {
    $user_behavior = Yii::$container->get(\common\interfaces\UserBehaviorInterface::class);
    $user_rows  = $user_behavior->getTopBehaviors();
    $answer_pie = $user_behavior->getBehaviorsByCategory();

    return $this->render('report', [
      'top_behaviors' => $user_rows,
      'answer_pie' => $answer_pie,
    ]);
  }
}