site\tests\unit\models\CustomBehaviorFormTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testRules()	0	41	1
A	setUp()	0	4	1
A	testSave()	0	34	1

<?php

namespace site\tests\unit\models;

use Yii;
use \site\models\CustomBehaviorForm;
use \yii\di\Container;
use \common\models\Category;

class CustomBehaviorFormTest extends \Codeception\Test\Unit {

  private $user;
  private $category;

The private property $category is not used, and could be removed.

  public function setUp() {
    $this->container = new Container;

The property container does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    $this->container->set(\common\interfaces\UserInterface::class, '\site\tests\_support\MockUser');
    $this->user = $this->container->get(\common\interfaces\UserInterface::class);
  }

  public function testRules() {
    $category = new Category();
    $form = new CustomBehaviorForm($this->user, $category);

    $form->attributes = [];
    expect('with no values, the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = [
      'name' => 'Clapping hands and smiling',
      'category_id' => 'definitely not a category id',
    ];
    expect('with an invalid category_id the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = [
      'category_id' => 'definitely not a category id',
    ];
    expect('without a name the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = [
      'name' => 'Clapping hands and smiling',
      'category_id' => 42,
    ];
    expect('with an invalid category_id the form should not pass validation', $this->assertFalse($form->validate()));

Are you sure the usage of $this->assertFalse($form->validate()) targeting PHPUnit\Framework\Assert::assertFalse() seems to always return null.

    $form->attributes = [
      'name' => 'Clapping hands and smiling',
      'category_id' => 6,
    ];
    expect('with a name and valid category_id, the form should validate', $this->assertTrue($form->validate()));

Are you sure the usage of $this->assertTrue($form->validate()) targeting PHPUnit\Framework\Assert::assertTrue() seems to always return null.

    $form->attributes = [
      'name' => 'Clapping hands and smiling',
      'category_id' => 6,
    ];
    expect('with a name and valid category_id, the form should validate', $this->assertTrue($form->validate()));

Are you sure the usage of $this->assertTrue($form->validate()) targeting PHPUnit\Framework\Assert::assertTrue() seems to always return null.

    $form->attributes = [
      'name' => '       Clapping hands and smiling .. -- aa       ',
      'category_id' => 6,
    ];
    $form->validate();
    expect('the form should trim the name when validating', $this->assertEquals('Clapping hands and smiling .. -- aa', $form->name));

Are you sure the usage of $this->assertEquals('Clapping hands and smiling .. -- aa', $form->name) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

  }

  public function testSave() {
    $category = new Category();
    $user_id = 123;
    $this->user->id = $user_id;

    $custom_behavior = $this->getMockBuilder(\common\models\CustomBehavior::class)
      ->setmethods(['getisnewrecord', 'attributes', 'save'])
      ->getmock();
    $custom_behavior
      ->method('attributes')
      ->willReturn([
        'id',
        'user_id',
        'category_id',
        'name',
        'created_at',
        'updated_at',
      ]);
    $custom_behavior
      ->expects($this->once())
      ->method('save')
      ->willReturn($custom_behavior);

    Yii::$container->set(\common\interfaces\CustomBehaviorInterface::class, $custom_behavior);
    $form = new CustomBehaviorForm($this->user, $category);
    $name = 'a new custom behavior';
    $category_id = 4;
    $form->name = $name;
    $form->category_id = $category_id;

    $result = $form->save();
    expect('should have name correctly set', $this->assertEquals($result->name, $name));

Are you sure the usage of $this->assertEquals($result->name, $name) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

    expect('should have category_id correctly set', $this->assertEquals($result->category_id, $category_id));

Are you sure the usage of $this->assertEquals($result->category_id, $category_id) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

    expect('should have name correctly set', $this->assertEquals($result->user_id, $user_id));

Are you sure the usage of $this->assertEquals($result->user_id, $user_id) targeting PHPUnit\Framework\Assert::assertEquals() seems to always return null.

  }
}