ControleOnline\Service\ConfigService

Complexity

Total Complexity

12

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	addConfig()	0	17	5
A	getConfig()	0	5	3
A	discoveryConfig()	0	14	3

<?php

namespace ControleOnline\Service;

use ControleOnline\Entity\Config;
use ControleOnline\Entity\People;

The type ControleOnline\Entity\People was not found. Maybe you did not declare it correctly or list all dependencies?

use ControleOnline\Entity\PeopleDomain;

The type ControleOnline\Entity\PeopleDomain was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Component\HttpFoundation\RequestStack;

The type Symfony\Component\HttpFoundation\RequestStack was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Component\HttpFoundation\Request;

The type Symfony\Component\HttpFoundation\Request was not found. Maybe you did not declare it correctly or list all dependencies?

use InvalidArgumentException;
use Doctrine\ORM\EntityManagerInterface;

The type Doctrine\ORM\EntityManagerInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use phpDocumentor\Reflection\PseudoTypes\Numeric_;

The type phpDocumentor\Reflection\PseudoTypes\Numeric_ was not found. Maybe you did not declare it correctly or list all dependencies?

use phpDocumentor\Reflection\Types\Integer;

The type phpDocumentor\Reflection\Types\Integer was not found. Maybe you did not declare it correctly or list all dependencies?

class ConfigService
{
    private $request;
    public function __construct(
        private EntityManagerInterface $manager,
        private RequestStack $requestStack
    ) {
        $this->request = $requestStack->getCurrentRequest();
    }

    public function getConfig(People $people, $key, $json = false)
    {
        $config = $this->discoveryConfig($people, $key, false);
        $value =  $config ? $config->getConfigValue() : null;
        return $json ? json_decode($value) : $value;

It seems like $value can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

    }

    private function discoveryConfig(People $people, $key, $create = true): ?Config
    {
        $config =   $this->manager->getRepository(Config::class)->findOneBy([
            'people' => $people,
            'configKey' => $key
        ]);
        if ($config)
            return $config;
        if ($create) {
            $config = new Config();
            $config->setConfigKey($key);
            $config->setPeople($people);
        }
        return null;
    }

    public function addConfig(People $people, string $key, array $values)
    {
        $config = $this->discoveryConfig($people, $key);
        $newValue = json_decode($config->getConfigValue()) || [];
        if (!is_array($newValue))

The condition is_array($newValue) is always false.

            $newValue = [$newValue];

        if (is_array($values))

The condition is_array($values) is always true.

            foreach ($values as $key => $value)
                $newValue[$key] = $value;
        else
            $newValue[] = $values;

        $config->setConfigValue(json_encode($newValue));
        $this->manager->persist($config);
        $this->manager->flush();
        return $config;
    }
}