DeviceService::addDeviceConfigs() - Code Metrics - Inspection of "Update" - ControleOnline/api-platform-common - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bf46cc...bf9f11 )

by Luiz Kim

created 2025-04-04 03:11 UTC

DeviceService::addDeviceConfigs() A

↳ Parent: DeviceService

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	10
rs	10
cc	2
nc	2
nop	3

<?php

namespace ControleOnline\Service;

use ControleOnline\Entity\Device;
use ControleOnline\Entity\DeviceConfig;
use ControleOnline\Entity\People;
filter:
    dependency_paths: ["lib/*"]
use Doctrine\ORM\EntityManagerInterface;
filter:
    dependency_paths: ["lib/*"]

class DeviceService
{
    public function __construct(
        private EntityManagerInterface $manager,
    ) {}


    public function discoveryDevice($deviceId)
    {
        $device = $this->manager->getRepository(Device::class)->findOneBy([
            'device' => $deviceId
        ]);
        if (! $device) {
            $device = new Device();
            $device->setDevice($deviceId);
        }

        return $device;
    }
    public function discoveryDeviceConfig(Device $device, People $people)
    {
        $device_config = $this->manager->getRepository(DeviceConfig::class)->findOneBy([
            'device' => $device,
            'people' => $people
        ]);
        if (! $device_config) {
            $device_config = new DeviceConfig();
            $device_config->setDevice($device);
            $device_config->setPeople($people);
        }

        return $device_config;
    }

    public function addDeviceConfigs(People $people, array $configs, $deviceId)
    {
        $device = $this->discoveryDevice($deviceId);
        $device_config = $this->discoveryDeviceConfig($device,  $people);
        foreach ($configs as $key => $config)
            $device_config->addConfigs($key,  $config);

        $this->manager->persist($device_config);
        $this->manager->flush();
        return $device;
    }
}


1			<?php
2
3			namespace ControleOnline\Service;
4
5			use ControleOnline\Entity\Device;
6			use ControleOnline\Entity\DeviceConfig;
7			use ControleOnline\Entity\People;
			0 ignored issues – show Bug introduced 2025-04-04 03:13 UTC by Report Bug Copy Issue Report The type `ControleOnline\Entity\People` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use Doctrine\ORM\EntityManagerInterface;
			0 ignored issues – show Bug introduced 2025-04-04 03:13 UTC by Report Bug Copy Issue Report The type `Doctrine\ORM\EntityManagerInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9
10			class DeviceService
11			{
12			public function __construct(
13			private EntityManagerInterface $manager,
14			) {}
15
16
17			public function discoveryDevice($deviceId)
18			{
19			$device = $this->manager->getRepository(Device::class)->findOneBy([
20			'device' => $deviceId
21			]);
22			if (! $device) {
23			$device = new Device();
24			$device->setDevice($deviceId);
25			}
26
27			return $device;
28			}
29			public function discoveryDeviceConfig(Device $device, People $people)
30			{
31			$device_config = $this->manager->getRepository(DeviceConfig::class)->findOneBy([
32			'device' => $device,
33			'people' => $people
34			]);
35			if (! $device_config) {
36			$device_config = new DeviceConfig();
37			$device_config->setDevice($device);
38			$device_config->setPeople($people);
39			}
40
41			return $device_config;
42			}
43
44			public function addDeviceConfigs(People $people, array $configs, $deviceId)
45			{
46			$device = $this->discoveryDevice($deviceId);
47			$device_config = $this->discoveryDeviceConfig($device, $people);
48			foreach ($configs as $key => $config)
49			$device_config->addConfigs($key, $config);
50
51			$this->manager->persist($device_config);
52			$this->manager->flush();
53			return $device;
54			}
55			}
56

ControleOnline / api-platform-common

Push — master ( bf46cc...bf9f11 )

DeviceService::addDeviceConfigs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like