Harborn-digital /
timechimp-bundle
| Conditions | 19 |
| Paths | > 20000 |
| Total Lines | 60 |
| Code Lines | 39 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 380 |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 36 | { |
||
| 37 | if (!is_object($data)) { |
||
| 38 | throw new InvalidArgumentException(sprintf('Given $data is not an object (%s given). We need an object in order to continue denormalize method.', gettype($data))); |
||
| 39 | } |
||
| 40 | $object = new \ConnectHolland\TimechimpBundle\Api\Client\Model\User(); |
||
| 41 | if (property_exists($data, 'id')) { |
||
| 42 | $object->setId($data->{'id'}); |
||
| 43 | } |
||
| 44 | if (property_exists($data, 'userName')) { |
||
| 45 | $object->setUserName($data->{'userName'}); |
||
| 46 | } |
||
| 47 | if (property_exists($data, 'displayName')) { |
||
| 48 | $object->setDisplayName($data->{'displayName'}); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'accountType')) { |
||
| 51 | $object->setAccountType($data->{'accountType'}); |
||
| 52 | } |
||
| 53 | if (property_exists($data, 'isLocked')) { |
||
| 54 | $object->setIsLocked($data->{'isLocked'}); |
||
| 55 | } |
||
| 56 | if (property_exists($data, 'picture')) { |
||
| 57 | $object->setPicture($data->{'picture'}); |
||
| 58 | } |
||
| 59 | if (property_exists($data, 'tagNames')) { |
||
| 60 | $values = []; |
||
| 61 | foreach ($data->{'tagNames'} as $value) { |
||
| 62 | $values[] = $value; |
||
| 63 | } |
||
| 64 | $object->setTagNames($values); |
||
| 65 | } |
||
| 66 | if (property_exists($data, 'language')) { |
||
| 67 | $object->setLanguage($data->{'language'}); |
||
| 68 | } |
||
| 69 | if (property_exists($data, 'contractHours')) { |
||
| 70 | $object->setContractHours($data->{'contractHours'}); |
||
| 71 | } |
||
| 72 | if (property_exists($data, 'contractHourlyRate')) { |
||
| 73 | $object->setContractHourlyRate($data->{'contractHourlyRate'}); |
||
| 74 | } |
||
| 75 | if (property_exists($data, 'contractCostHourlyRate')) { |
||
| 76 | $object->setContractCostHourlyRate($data->{'contractCostHourlyRate'}); |
||
| 77 | } |
||
| 78 | if (property_exists($data, 'contractStartDate')) { |
||
| 79 | $object->setContractStartDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'contractStartDate'})); |
||
|
Bug
introduced
by
|
|||
| 80 | } |
||
| 81 | if (property_exists($data, 'contractEndDate')) { |
||
| 82 | $object->setContractEndDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'contractEndDate'})); |
||
| 83 | } |
||
| 84 | if (property_exists($data, 'created')) { |
||
| 85 | $object->setCreated(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'created'})); |
||
| 86 | } |
||
| 87 | if (property_exists($data, 'teamName')) { |
||
| 88 | $object->setTeamName($data->{'teamName'}); |
||
| 89 | } |
||
| 90 | if (property_exists($data, 'employeeNumber')) { |
||
| 91 | $object->setEmployeeNumber($data->{'employeeNumber'}); |
||
| 92 | } |
||
| 93 | |||
| 94 | return $object; |
||
| 95 | } |
||
| 156 |
Loading history...