Harborn-digital /
timechimp-bundle
| Conditions | 19 |
| Paths | > 20000 |
| Total Lines | 59 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 380 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 36 | { |
||
| 37 | if (!is_object($data)) { |
||
| 38 | throw new InvalidArgumentException(sprintf('Given $data is not an object (%s given). We need an object in order to continue denormalize method.', gettype($data))); |
||
| 39 | } |
||
| 40 | $object = new \ConnectHolland\TimechimpBundle\Api\Client\Model\Expense(); |
||
| 41 | if (property_exists($data, 'id')) { |
||
| 42 | $object->setId($data->{'id'}); |
||
| 43 | } |
||
| 44 | if (property_exists($data, 'customerId')) { |
||
| 45 | $object->setCustomerId($data->{'customerId'}); |
||
| 46 | } |
||
| 47 | if (property_exists($data, 'customerName')) { |
||
| 48 | $object->setCustomerName($data->{'customerName'}); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'projectId')) { |
||
| 51 | $object->setProjectId($data->{'projectId'}); |
||
| 52 | } |
||
| 53 | if (property_exists($data, 'projectName')) { |
||
| 54 | $object->setProjectName($data->{'projectName'}); |
||
| 55 | } |
||
| 56 | if (property_exists($data, 'categoryName')) { |
||
| 57 | $object->setCategoryName($data->{'categoryName'}); |
||
| 58 | } |
||
| 59 | if (property_exists($data, 'categoryId')) { |
||
| 60 | $object->setCategoryId($data->{'categoryId'}); |
||
| 61 | } |
||
| 62 | if (property_exists($data, 'userId')) { |
||
| 63 | $object->setUserId($data->{'userId'}); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'userDisplayName')) { |
||
| 66 | $object->setUserDisplayName($data->{'userDisplayName'}); |
||
| 67 | } |
||
| 68 | if (property_exists($data, 'date')) { |
||
| 69 | $object->setDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'date'})); |
||
|
Bug
introduced
by
|
|||
| 70 | } |
||
| 71 | if (property_exists($data, 'notes')) { |
||
| 72 | $object->setNotes($data->{'notes'}); |
||
| 73 | } |
||
| 74 | if (property_exists($data, 'attachment')) { |
||
| 75 | $object->setAttachment($data->{'attachment'}); |
||
| 76 | } |
||
| 77 | if (property_exists($data, 'quantity')) { |
||
| 78 | $object->setQuantity($data->{'quantity'}); |
||
| 79 | } |
||
| 80 | if (property_exists($data, 'rate')) { |
||
| 81 | $object->setRate($data->{'rate'}); |
||
| 82 | } |
||
| 83 | if (property_exists($data, 'tax')) { |
||
| 84 | $object->setTax($data->{'tax'}); |
||
| 85 | } |
||
| 86 | if (property_exists($data, 'billable')) { |
||
| 87 | $object->setBillable($data->{'billable'}); |
||
| 88 | } |
||
| 89 | if (property_exists($data, 'status')) { |
||
| 90 | $object->setStatus($data->{'status'}); |
||
| 91 | } |
||
| 92 | |||
| 93 | return $object; |
||
| 94 | } |
||
| 154 |
Loading history...