Harborn-digital /
timechimp-bundle
| Conditions | 70 |
| Paths | > 20000 |
| Total Lines | 93 |
| Code Lines | 72 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 4970 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\Expense(); |
||
| 40 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 41 | $object->setId($data->{'id'}); |
||
| 42 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 43 | $object->setId(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'customerId') && $data->{'customerId'} !== null) { |
||
| 46 | $object->setCustomerId($data->{'customerId'}); |
||
| 47 | } elseif (property_exists($data, 'customerId') && $data->{'customerId'} === null) { |
||
| 48 | $object->setCustomerId(null); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'customerName') && $data->{'customerName'} !== null) { |
||
| 51 | $object->setCustomerName($data->{'customerName'}); |
||
| 52 | } elseif (property_exists($data, 'customerName') && $data->{'customerName'} === null) { |
||
| 53 | $object->setCustomerName(null); |
||
| 54 | } |
||
| 55 | if (property_exists($data, 'projectId') && $data->{'projectId'} !== null) { |
||
| 56 | $object->setProjectId($data->{'projectId'}); |
||
| 57 | } elseif (property_exists($data, 'projectId') && $data->{'projectId'} === null) { |
||
| 58 | $object->setProjectId(null); |
||
| 59 | } |
||
| 60 | if (property_exists($data, 'projectName') && $data->{'projectName'} !== null) { |
||
| 61 | $object->setProjectName($data->{'projectName'}); |
||
| 62 | } elseif (property_exists($data, 'projectName') && $data->{'projectName'} === null) { |
||
| 63 | $object->setProjectName(null); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'categoryName') && $data->{'categoryName'} !== null) { |
||
| 66 | $object->setCategoryName($data->{'categoryName'}); |
||
| 67 | } elseif (property_exists($data, 'categoryName') && $data->{'categoryName'} === null) { |
||
| 68 | $object->setCategoryName(null); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'categoryId') && $data->{'categoryId'} !== null) { |
||
| 71 | $object->setCategoryId($data->{'categoryId'}); |
||
| 72 | } elseif (property_exists($data, 'categoryId') && $data->{'categoryId'} === null) { |
||
| 73 | $object->setCategoryId(null); |
||
| 74 | } |
||
| 75 | if (property_exists($data, 'userId') && $data->{'userId'} !== null) { |
||
| 76 | $object->setUserId($data->{'userId'}); |
||
| 77 | } elseif (property_exists($data, 'userId') && $data->{'userId'} === null) { |
||
| 78 | $object->setUserId(null); |
||
| 79 | } |
||
| 80 | if (property_exists($data, 'userDisplayName') && $data->{'userDisplayName'} !== null) { |
||
| 81 | $object->setUserDisplayName($data->{'userDisplayName'}); |
||
| 82 | } elseif (property_exists($data, 'userDisplayName') && $data->{'userDisplayName'} === null) { |
||
| 83 | $object->setUserDisplayName(null); |
||
| 84 | } |
||
| 85 | if (property_exists($data, 'date') && $data->{'date'} !== null) { |
||
| 86 | $object->setDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'date'})); |
||
|
Bug
introduced
by
|
|||
| 87 | } elseif (property_exists($data, 'date') && $data->{'date'} === null) { |
||
| 88 | $object->setDate(null); |
||
| 89 | } |
||
| 90 | if (property_exists($data, 'notes') && $data->{'notes'} !== null) { |
||
| 91 | $object->setNotes($data->{'notes'}); |
||
| 92 | } elseif (property_exists($data, 'notes') && $data->{'notes'} === null) { |
||
| 93 | $object->setNotes(null); |
||
| 94 | } |
||
| 95 | if (property_exists($data, 'attachment') && $data->{'attachment'} !== null) { |
||
| 96 | $object->setAttachment($data->{'attachment'}); |
||
| 97 | } elseif (property_exists($data, 'attachment') && $data->{'attachment'} === null) { |
||
| 98 | $object->setAttachment(null); |
||
| 99 | } |
||
| 100 | if (property_exists($data, 'quantity') && $data->{'quantity'} !== null) { |
||
| 101 | $object->setQuantity($data->{'quantity'}); |
||
| 102 | } elseif (property_exists($data, 'quantity') && $data->{'quantity'} === null) { |
||
| 103 | $object->setQuantity(null); |
||
| 104 | } |
||
| 105 | if (property_exists($data, 'rate') && $data->{'rate'} !== null) { |
||
| 106 | $object->setRate($data->{'rate'}); |
||
| 107 | } elseif (property_exists($data, 'rate') && $data->{'rate'} === null) { |
||
| 108 | $object->setRate(null); |
||
| 109 | } |
||
| 110 | if (property_exists($data, 'tax') && $data->{'tax'} !== null) { |
||
| 111 | $object->setTax($data->{'tax'}); |
||
| 112 | } elseif (property_exists($data, 'tax') && $data->{'tax'} === null) { |
||
| 113 | $object->setTax(null); |
||
| 114 | } |
||
| 115 | if (property_exists($data, 'billable') && $data->{'billable'} !== null) { |
||
| 116 | $object->setBillable($data->{'billable'}); |
||
| 117 | } elseif (property_exists($data, 'billable') && $data->{'billable'} === null) { |
||
| 118 | $object->setBillable(null); |
||
| 119 | } |
||
| 120 | if (property_exists($data, 'status') && $data->{'status'} !== null) { |
||
| 121 | $object->setStatus($data->{'status'}); |
||
| 122 | } elseif (property_exists($data, 'status') && $data->{'status'} === null) { |
||
| 123 | $object->setStatus(null); |
||
| 124 | } |
||
| 125 | |||
| 126 | return $object; |
||
| 127 | } |
||
| 221 |
Loading history...