BaseTabellaDecoder::parseParameters() - Code Metrics - Inspection of "fix phpcbf" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.1 ( 1244ae...15ef68 )

by Andrea

created 2018-11-15 14:50 UTC

BaseTabellaDecoder::parseParameters() C

↳ Parent: BaseTabellaDecoder

Complexity

Conditions	9
Paths	256

Size

Total Lines	23
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	9

Importance

Changes

Metric	Value
eloc	21
dl	0
loc	23
ccs	21
cts	21
cp	1
rs	6.5222
c	0
b	0
f	0
cc	9
nc	256
nop	0
crap	9

<?php

namespace Fi\CoreBundle\Utils\Tabella;

use \Doctrine\Common\Collections\Expr\Comparison;
use Fi\CoreBundle\Utils\Tabella\ParametriTabella;

class BaseTabellaDecoder
{

    protected $parametri;
    protected $entityname;
    protected $tablename;
    protected $colonnedatabase;
    protected $modellocolonne;
    protected $paginacorrente;
    protected $righeperpagina;
    protected $estraituttirecords;
    protected $prefiltri;
    protected $filtri;
    protected $wheremanuale;
    protected $colonneordinamento;
    protected $opzionitabellacore;
    protected $configurazionecolonnetabella;
    private $aliasGenerati;
    private $decodificaAlias;

    protected function parseParameters()
    {
        $this->tablename = ParametriTabella::getParameter($this->parametri['tablename']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->entityname = ParametriTabella::getParameter($this->parametri['entityclass']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->entityname = str_replace("FiCoreBundle", "CoreBundle", $this->entityname);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->permessi = json_decode(ParametriTabella::getParameter($this->parametri['permessi']));
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->modellocolonne = isset($this->parametri['modellocolonne']) ?
$a = "a";
$ab = "ab";
$abc = "abc";
                json_decode(ParametriTabella::getParameter($this->parametri['modellocolonne']), true) : array();
        $this->paginacorrente = ParametriTabella::getParameter($this->parametri['paginacorrente']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->paginetotali = ParametriTabella::getParameter($this->parametri['paginetotali']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->righeperpagina = isset($this->parametri['righeperpagina']) ?
$a = "a";
$ab = "ab";
$abc = "abc";
                ParametriTabella::getParameter($this->parametri['righeperpagina']) : 15;
        $this->estraituttirecords = isset($this->parametri['estraituttirecords']) &&
                ParametriTabella::getParameter($this->parametri['estraituttirecords'])==="1" ?
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                true : false;
        $this->colonneordinamento = isset($this->parametri['colonneordinamento']) ?
                json_decode(ParametriTabella::getParameter($this->parametri['colonneordinamento']), true) : array();
        $this->prefiltri = isset($this->parametri['prefiltri']) ?
$a = "a";
$ab = "ab";
$abc = "abc";
                json_decode(ParametriTabella::getParameter($this->parametri['prefiltri']), true) : array();
        $this->filtri = isset($this->parametri['filtri']) ?
$a = "a";
$ab = "ab";
$abc = "abc";
                json_decode(ParametriTabella::getParameter($this->parametri['filtri']), true) : array();
        $this->wheremanuale = isset($this->parametri['wheremanuale']) ? ParametriTabella::getParameter($this->parametri['wheremanuale']) : null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->user = $this->parametri['user'];
$a = "a";
$ab = "ab";
$abc = "abc";
    }
    protected function getDescrizioneFiltro(&$descrizionefiltri, $filtrocorrente, $criteria)
    {
        if ($filtrocorrente["prefiltro"] === false) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $descrizionefiltri = $descrizionefiltri . ", " . $criteria->getDescrizioneFiltro();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
    }
    protected function getFieldValue($fieldvalue)
    {
        if (isset($fieldvalue["date"])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            //StdClassUtils::arrayToObject($fieldvalue, DatetimeTabella::class);

            return new \Datetime($fieldvalue["date"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            return $fieldvalue;
        }
    }
    protected function getOperator($operator)
    {

        switch (strtoupper($operator)) {
            case "LIKE":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::CONTAINS;
                break;
            case "IN":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::IN;
                break;
            case "NOT IN":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::NIN;
                break;
            default:
                break;
        }

        return $operator;
    }
    protected function bonificanomecampo($nomecampo)
    {
        $parti = explode(".", $nomecampo);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $campo = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        for ($index = 0; $index < count($parti); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if ($index == count($parti) - 1) {
                $campo .= "." . lcfirst($parti[$index]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            } else {
                $campo .= "." . ucfirst($parti[$index]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
        return substr($campo, 1);
    }
    protected function generaAlias($nometabella, $nomepadre = false, $ancestors = array())
    {
        $nometabellapulito = preg_replace('/[^a-z0-9\.]/i', '', $nometabella);
        $primalettera = strtolower(substr($nometabellapulito, 0, 1));
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($nomepadre && !in_array($nomepadre, $ancestors)) {
            $ancestors[] = $nomepadre;
        }
        if (!in_array($nometabella, $ancestors)) {
            $ancestors[] = $nometabella;
        }

        if (isset($this->aliasGenerati[$primalettera])) {
            $risposta = $primalettera . $this->aliasGenerati[$primalettera];
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->aliasGenerati[$primalettera] = $this->aliasGenerati[$primalettera] + 1;
        } else {
            $risposta = $primalettera;
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->aliasGenerati[$primalettera] = 1;
        }

        $this->decodificaAlias[ucfirst(implode(".", $ancestors))] = array("alias" => $risposta);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        return $risposta;
    }
    protected function findAliasByTablename($tablename)
    {
        if (!array_key_exists($tablename, $this->decodificaAlias)) {
            $ex = "Fifree: table or association " . $tablename . " not found, did you mean one of these:\n" .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    implode("\n", array_keys($this->decodificaAlias)) .
                    " ?";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            throw new \Exception($ex);
        }
        return $this->getAliasGenerato($tablename);
    }
    protected function findFieldnameByAlias($nomecampo)
    {
        if (!array_key_exists($nomecampo, $this->configurazionecolonnetabella)) {
            $ex = "Fifree: field or association " . $nomecampo . " not found, did you mean one of these:\n" .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    implode("\n", array_keys($this->configurazionecolonnetabella)) .
                    " ?";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            throw new \Exception($ex);
        }
        return $this->configurazionecolonnetabella[$nomecampo];
    }
    
    public function getAliasGenerato($tablename)
    {
        return $this->decodificaAlias[$tablename]["alias"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Utils\Tabella;
4
5		use \Doctrine\Common\Collections\Expr\Comparison;
6		use Fi\CoreBundle\Utils\Tabella\ParametriTabella;
7
8		class BaseTabellaDecoder
9		{
10
11		protected $parametri;
12		protected $entityname;
13		protected $tablename;
14		protected $colonnedatabase;
15		protected $modellocolonne;
16		protected $paginacorrente;
17		protected $righeperpagina;
18		protected $estraituttirecords;
19		protected $prefiltri;
20		protected $filtri;
21		protected $wheremanuale;
22		protected $colonneordinamento;
23		protected $opzionitabellacore;
24		protected $configurazionecolonnetabella;
25		private $aliasGenerati;
26		private $decodificaAlias;
27	11
28		protected function parseParameters()
29	11	{
30	11	$this->tablename = ParametriTabella::getParameter($this->parametri['tablename']);
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31	11	$this->entityname = ParametriTabella::getParameter($this->parametri['entityclass']);
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32	11	$this->entityname = str_replace("FiCoreBundle", "CoreBundle", $this->entityname);
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `FiCoreBundle` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `CoreBundle` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
33	11	$this->permessi = json_decode(ParametriTabella::getParameter($this->parametri['permessi']));
		0 ignored issues – show Bug Best Practice introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The property `permessi` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history... Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	11	$this->modellocolonne = isset($this->parametri['modellocolonne']) ?
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35	11	json_decode(ParametriTabella::getParameter($this->parametri['modellocolonne']), true) : array();
36	11	$this->paginacorrente = ParametriTabella::getParameter($this->parametri['paginacorrente']);
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37	11	$this->paginetotali = ParametriTabella::getParameter($this->parametri['paginetotali']);
		0 ignored issues – show Bug Best Practice introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The property `paginetotali` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history... Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
38	11	$this->righeperpagina = isset($this->parametri['righeperpagina']) ?
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
39	11	ParametriTabella::getParameter($this->parametri['righeperpagina']) : 15;
40	11	$this->estraituttirecords = isset($this->parametri['estraituttirecords']) &&
41	11	ParametriTabella::getParameter($this->parametri['estraituttirecords'])==="1" ?
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-15 15:53 UTC by Report Bug Copy Issue Report The string literal `1` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
42	11	true : false;
43	11	$this->colonneordinamento = isset($this->parametri['colonneordinamento']) ?
44	11	json_decode(ParametriTabella::getParameter($this->parametri['colonneordinamento']), true) : array();
45	11	$this->prefiltri = isset($this->parametri['prefiltri']) ?
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
46	11	json_decode(ParametriTabella::getParameter($this->parametri['prefiltri']), true) : array();
47	11	$this->filtri = isset($this->parametri['filtri']) ?
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48	3	json_decode(ParametriTabella::getParameter($this->parametri['filtri']), true) : array();
49		$this->wheremanuale = isset($this->parametri['wheremanuale']) ? ParametriTabella::getParameter($this->parametri['wheremanuale']) : null;
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
50	3	$this->user = $this->parametri['user'];
		0 ignored issues – show Bug Best Practice introduced 2018-11-15 15:53 UTC by Report Bug Copy Issue Report The property `user` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history... Coding Style introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
51	2	}
52		protected function getDescrizioneFiltro(&$descrizionefiltri, $filtrocorrente, $criteria)
53	3	{
54	3	if ($filtrocorrente["prefiltro"] === false) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `prefiltro` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
55		$descrizionefiltri = $descrizionefiltri . ", " . $criteria->getDescrizioneFiltro();
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `,` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
56	3	}
57		}
58	1	protected function getFieldValue($fieldvalue)
59		{
60	3	if (isset($fieldvalue["date"])) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `date` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
61		//StdClassUtils::arrayToObject($fieldvalue, DatetimeTabella::class);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
62		return new \Datetime($fieldvalue["date"]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `date` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
63	3	} else {
64		return $fieldvalue;
65		}
66	3	}
67	3	protected function getOperator($operator)
68	1	{
69	1
70	3	switch (strtoupper($operator)) {
71	1	case "LIKE":
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-13 22:44 UTC by Report Bug Copy Issue Report The string literal `LIKE` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72	1	$operator = Comparison::CONTAINS;
73	3	break;
74	1	case "IN":
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-13 22:44 UTC by Report Bug Copy Issue Report The string literal `IN` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
75	1	$operator = Comparison::IN;
76		break;
77	3	case "NOT IN":
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-13 22:44 UTC by Report Bug Copy Issue Report The string literal `NOT IN` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
78		$operator = Comparison::NIN;
79		break;
80	3	default:
81		break;
82	5	}
83
84	5	return $operator;
85	5	}
86	5	protected function bonificanomecampo($nomecampo)
87	5	{
88	5	$parti = explode(".", $nomecampo);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report The string literal `.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
89		$campo = "";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
90	5	for ($index = 0; $index < count($parti); $index++) {
		0 ignored issues – show Performance Best Practice introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
91		if ($index == count($parti) - 1) {
92		$campo .= "." . lcfirst($parti[$index]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report The string literal `.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
93	5	} else {
94		$campo .= "." . ucfirst($parti[$index]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-12 17:06 UTC by Report Bug Copy Issue Report The string literal `.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
95	11	}
96		}
97	11	return substr($campo, 1);
98	11	}
99	11	protected function generaAlias($nometabella, $nomepadre = false, $ancestors = array())
100		{
101		$nometabellapulito = preg_replace('/[^a-z0-9\.]/i', '', $nometabella);
102	11	$primalettera = strtolower(substr($nometabellapulito, 0, 1));
		0 ignored issues – show Coding Style introduced 2018-11-08 22:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
103	11	if ($nomepadre && !in_array($nomepadre, $ancestors)) {
104		$ancestors[] = $nomepadre;
105		}
106	11	if (!in_array($nometabella, $ancestors)) {
107	2	$ancestors[] = $nometabella;
108	2	}
109
110	11	if (isset($this->aliasGenerati[$primalettera])) {
111	11	$risposta = $primalettera . $this->aliasGenerati[$primalettera];
		0 ignored issues – show Coding Style introduced 2018-11-08 22:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 27 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
112		$this->aliasGenerati[$primalettera] = $this->aliasGenerati[$primalettera] + 1;
113		} else {
114	11	$risposta = $primalettera;
		0 ignored issues – show Coding Style introduced 2018-11-08 22:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 27 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
115		$this->aliasGenerati[$primalettera] = 1;
116	11	}
117
118	3	$this->decodificaAlias[ucfirst(implode(".", $ancestors))] = array("alias" => $risposta);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `alias` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
119
120	3	return $risposta;
121		}
122		protected function findAliasByTablename($tablename)
123		{
124		if (!array_key_exists($tablename, $this->decodificaAlias)) {
125		$ex = "Fifree: table or association " . $tablename . " not found, did you mean one of these:\n" .
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `Fifree: table or association` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
126	3	implode("\n", array_keys($this->decodificaAlias)) .
127		" ?";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `?` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
128	3	throw new \Exception($ex);
129		}
130	3	return $this->getAliasGenerato($tablename);
131		}
132		protected function findFieldnameByAlias($nomecampo)
133		{
134		if (!array_key_exists($nomecampo, $this->configurazionecolonnetabella)) {
135		$ex = "Fifree: field or association " . $nomecampo . " not found, did you mean one of these:\n" .
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `Fifree: field or association` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
136	3	implode("\n", array_keys($this->configurazionecolonnetabella)) .
137		" ?";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-09 23:06 UTC by Report Bug Copy Issue Report The string literal `?` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
138		throw new \Exception($ex);
139	9	}
140		return $this->configurazionecolonnetabella[$nomecampo];
141	9	}
142
143		public function getAliasGenerato($tablename)
144		{
145		return $this->decodificaAlias[$tablename]["alias"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-08 22:25 UTC by Report Bug Copy Issue Report The string literal `alias` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
146		}
147		}
148

ComuneFI / FifreeCoreBundle

Push — 4.1 ( 1244ae...15ef68 )

BaseTabellaDecoder::parseParameters() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like