FiCrudController::index() - Code Metrics - Inspection of "add controller tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — 4.1 ( e0bb47...f67e6e )

by Andrea
created 2018-11-10 00:25 UTC
FiCrudController::index() A

↳ Parent: FiCrudController
Complexity

Conditions	3
Paths	3
Size

Total Lines	71
Code Lines	40
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	39
CRAP Score	3.001
Importance

Changes
Metric	Value
eloc	40
dl	0
loc	71
ccs	39
cts	41
cp	0.9512
rs	9.28
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3.001
How to fix Long Method

<?php
namespace Fi\CoreBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Fi\CoreBundle\Utils\Tabella\ParametriTabella;

class FiCrudController extends AbstractController
{

    /**
     * Lists all tables entities.
     */
    public function index(Request $request, \Symfony\Component\Asset\Packages $assetsmanager)
    {
        $bundle = $this->getBundle();
        $bundle = $this->getBundle();
        $controller = $this->getController();
        $controller = $this->getController();
        $idpassato = $request->get('id');
$a = "a";
$ab = "ab";
$abc = "abc";

        if (!$this->getPermessi()->canRead()) {
        if (!$this->/** @scrutinizer ignore-call */ getPermessi()->canRead()) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $template = $bundle . ':' . $controller . ':' . $this->getThisFunctionName() . '.html.twig';
        $template = $bundle . ':' . $controller . ':' . $this->/** @scrutinizer ignore-call */ getThisFunctionName() . '.html.twig';
        if (!$this->get('templating')->exists($template)) {
            $template = $controller . '/Crud/' . $this->getThisFunctionName() . '.html.twig';
        }

        $entityclassnotation = $this->getEntityClassNotation();
        $entityclassnotation = $this->getEntityClassNotation();
        $entityclass = $this->getEntityClassName();
        $entityclass = $this->getEntityClassName();

        $formclass = str_replace("Entity", "Form", $entityclass);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $modellocolonne = array(
            /*

              $controller . ".nominativo" => array(
              "nometabella" => $controller,
              "nomecampo" => "nominativo",
              "etichetta" => "Nominativo",
              "ordine" => 10,
              "larghezza" => 200,
              "escluso" => false
              ),
              $controller . ".datanascita" => array(
              "nometabella" => $controller,
              "nomecampo" => "datanascita",
              "etichetta" => "Data di nascita",
              "ordine" => 20,
              "larghezza" => 100,
              "escluso" => false
              ),

             */
        );

        $colonneordinamento = array($controller . '.id' => "DESC");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $filtri = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $prefiltri = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityutils = new \Fi\CoreBundle\Utils\Entity\EntityUtils($this->get("doctrine")->getManager());
$a = "a";
$ab = "ab";
$abc = "abc";
        $tablenamefromentity = $entityutils->getTableFromEntity($entityclass);
        $colonneordinamento = array($tablenamefromentity . '.id' => "DESC");
$a = "a";
$ab = "ab";
$abc = "abc";
        $parametritabella = array("em" => ParametriTabella::setParameter("default"),
$a = "a";
$ab = "ab";
$abc = "abc";
            'tablename' => ParametriTabella::setParameter($tablenamefromentity),
            'nomecontroller' => ParametriTabella::setParameter($controller),
            'bundle' => ParametriTabella::setParameter($bundle),
            'entityname' => ParametriTabella::setParameter($entityclassnotation),
            'entityclass' => ParametriTabella::setParameter($entityclass),
            'formclass' => ParametriTabella::setParameter($formclass),
            'modellocolonne' => ParametriTabella::setParameter(json_encode($modellocolonne)),
            'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi())),
            'urltabella' => ParametriTabella::setParameter($assetsmanager->getUrl('/') . $controller . '/' . 'tabella'),
            'baseurl' => ParametriTabella::setParameter($assetsmanager->getUrl('/')),
            'idpassato' => ParametriTabella::setParameter($idpassato),
            'titolotabella' => ParametriTabella::setParameter("Elenco " . $controller),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'paginacorrente' => ParametriTabella::setParameter("1"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'paginetotali' => ParametriTabella::setParameter(""),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'righetotali' => ParametriTabella::setParameter("0"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'righeperpagina' => ParametriTabella::setParameter("15"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'colonneordinamento' => ParametriTabella::setParameter(json_encode($colonneordinamento)),
            'filtri' => ParametriTabella::setParameter(json_encode($filtri)),
            'prefiltri' => ParametriTabella::setParameter(json_encode($prefiltri)),
            'traduzionefiltri' => ParametriTabella::setParameter(""),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );

        return $this->render($template, array('parametritabella' => $parametritabella,));
    }

        /**
         * Displays a form to create a new table entity.
         */
    public function new(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canCreate()) {
            throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $template = $bundle . ':' . $controller . ':' . $this->getThisFunctionName() . '.html.twig';
        if (!$this->get('templating')->exists($template)) {
            $template = $controller . '/Crud/' . $this->getThisFunctionName() . '.html.twig';
        }
        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $entityclass();
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formclass . 'Type';
        $form = $this->createForm($formType, $entity, array('attr' => array(
$a = "a";
$ab = "ab";
$abc = "abc";
        'id' => 'formdati' . $controller,
        ),
        'action' => $this->generateUrl($controller . '_new'),
        ));

        $form->handleRequest($request);

        $twigparms = array(
        'form' => $form->createView(),
        'nomecontroller' => ParametriTabella::setParameter($controller)
        );

        if ($form->isSubmitted()) {
            if ($form->isValid()) {
                $entity = $form->getData();

                $entityManager = $this->getDoctrine()->getManager();
                $entityManager->persist($entity);
                $entityManager->flush();
                return new Response(
                    $this->renderView($template, $twigparms),
                    200
                );
            } else {
                //Quando non passa la validazione
                return new Response(
                    $this->renderView($template, $twigparms),
                    400
                );
            }
        } else {
            //Quando viene richiesta una "nuova" new
            return new Response(
                $this->renderView($template, $twigparms),
                200
            );
        }
    }

    /**
     * Displays a form to edit an existing table entity.
     */
    public function edit(Request $request, $id)
    public function edit(/** @scrutinizer ignore-unused */ Request $request, $id)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!$this->getPermessi()->canUpdate()) {
            throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $template = $bundle . ':' . $controller . ':' . $this->getThisFunctionName() . '.html.twig';
        if (!$this->get('templating')->exists($template)) {
            $template = $controller . '/Crud/' . $this->getThisFunctionName() . '.html.twig';
        }

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";

        $formType = $formclass . 'Type';

        $elencomodifiche = $this->elencoModifiche($controller, $id);

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' del record con id ' . $id . '.');
        }

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
            ),
            'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
            )
        );

        $deleteForm = $this->createDeleteForm($id);

        return $this->render(
            $template,
            array(
                'entity' => $entity,
                'nomecontroller' => ParametriTabella::setParameter($controller),
                'edit_form' => $editForm->createView(),
                'delete_form' => $deleteForm->createView(),
                'elencomodifiche' => $elencomodifiche,
                )
        );
    }

    /**
     * Edits an existing table entity.
     */
    public function update(Request $request, $id)
    {
//TODO: Da rivedere
        /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canUpdate()) {
            throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $template = $bundle . ':' . $controller . ':' . $this->getThisFunctionName() . '.html.twig';
        if (!$this->get('templating')->exists($template)) {
            $template = $controller . '/' . $this->getThisFunctionName() . '.html.twig';
        }

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formclass . 'Type';
$a = "a";
$ab = "ab";
$abc = "abc";

        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $repoStorico = $em->getRepository("CoreBundle:Storicomodifiche");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $entity = $em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
        }

        $deleteForm = $this->createDeleteForm($id);

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
            ),
            'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
            )
        );

        $editForm->submit($request->request->get($editForm->getName()));

        if ($editForm->isValid()) {
            $originalData = $em->getUnitOfWork()->getOriginalEntityData($entity);

            $em->persist($entity);
            $em->flush();

            $newData = $em->getUnitOfWork()->getOriginalEntityData($entity);
            $changes = $repoStorico->isRecordChanged($controller, $originalData, $newData);

            if ($changes) {
                $repoStorico->saveHistory($controller, $changes, $id, $this->getUser());
            }

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $id)));
            }
        }

        return $this->render(
            $template,
            array(
                'entity' => $entity,
                'edit_form' => $editForm->createView(),
                'delete_form' => $deleteForm->createView(),
                'nomecontroller' => $controller,
                )
        );
    }

    /**
     * Edits an existing table entity.
     */
    public function aggiorna(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canUpdate()) {
            throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $entityclass = $this->getEntityClassName();

        $id = $request->get('id');

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' con id ' . $id . '.');
        }

        throw $this->createNotFoundException("Implementare a seconda dell'esigenza il metodo 'aggiorna' del controller "
            . $bundle
            . '/'
            . "Controller/" . $controller . "Controller");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    /**
     * Deletes a table entity.
     */
    public function delete(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        if (!$this->getPermessi()->canDelete()) {
            throw new AccessDeniedException("Non si hanno i permessi per eliminare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $entityclass = $this->getEntityClassName();


        try {
            $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
            $qb = $em->createQueryBuilder();
$a = "a";
$ab = "ab";
$abc = "abc";
            $ids = explode(', ', $request->get('id'));
            $qb->delete($entityclass, 'u')
                ->andWhere('u.id IN (:ids)')
                ->setParameter('ids', $ids);

            $query = $qb->getQuery();
            $query->execute();
        } catch (\Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode('501');
            return $response;
        } catch (\Exception $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode('200');
            return $response;
        }

        return new Response('Operazione eseguita con successo');
    }

    /**
     * Creates a form to delete a table entity by id.
     *
     * @param mixed $id The entity id
     *
     * @return \Symfony\Component\Form\Form The form
     */
    protected function createDeleteForm($id)
    {
        return $this->createFormBuilder(array('id' => $id))
                ->add('id', get_class(new \Symfony\Component\Form\Extension\Core\Type\HiddenType()))
                ->getForm();
    }

    protected function elencoModifiche($controller, $id)
    {
        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $risultato = $em->getRepository('CoreBundle:Storicomodifiche')->findBy(
            array(
                'nometabella' => $controller,
                'idtabella' => $id,
            )
        );

        return $risultato;
    }
}

ComuneFI / FifreeCoreBundle

Push — 4.1 ( e0bb47...f67e6e )

FiCrudController::index() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
