Fi\CoreBundle\DependencyInjection\DatabaseUtility

Complexity

Total Complexity

26

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Test Coverage

Coverage

95.31%

Importance

Changes	9
Bugs	2	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	isDateChanged()	0	14	7
A	__construct()	0	4	1
A	getFieldType()	0	7	1
A	isSchemaChanged()	0	21	1
B	isArrayChanged()	0	12	7
A	isRecordChanged()	0	14	5
A	truncateTable()	0	16	4

<?php

namespace Fi\CoreBundle\DependencyInjection;

use DateTime;
use Doctrine\ORM\EntityManager;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\DependencyInjection\ContainerInterface as Container;

class DatabaseUtility
{

    private $container;
    /* @var $em EntityManager */

The doc comment $em at position 0 could not be parsed: Unknown type name '$em' at position 0 in $em.

    private $em;

    public function __construct(Container $container)
    {
        $this->container = $container;
        $this->em = $this->container->get("doctrine")->getManager();
    }

    public function getFieldType($entity, $field)
    {
        $metadata = $this->em->getClassMetadata(get_class($entity));
        $fieldMetadata = $metadata->fieldMappings[$field];

        $fieldType = $fieldMetadata['type'];
        return $fieldType;
    }

    public function isRecordChanged($entity, $fieldname, $oldvalue, $newvalue)
    {
        $fieldtype = $this->getFieldType(new $entity(), $fieldname);
        if ($fieldtype === 'boolean') {
            return $oldvalue !== $newvalue;
        }
        if ($fieldtype === 'datetime' || $fieldtype === 'date') {
            return $this->isDateChanged($oldvalue, $newvalue);
        }
        if (is_array($oldvalue)) {
            return $this->isArrayChanged($oldvalue, $newvalue);
        }

        return ($oldvalue !== $newvalue);
    }

    public function isDateChanged($oldvalue, $newvalue)
    {
        $datenewvalue = new DateTime();
        $datenewvalue->setTimestamp($newvalue);
        $twoboth = !$oldvalue && !$newvalue;
        if ($twoboth) {
            return false;
        }
        $onlyonenull = (!$oldvalue && $newvalue) || ($oldvalue && !$newvalue);

Consider adding parentheses for clarity. Current Interpretation: $onlyonenull = (! $oldvalue && $newvalue || $oldvalue && ! $newvalue), Probably Intended Meaning: $onlyonenull = ! $oldvalue && ($newvalue || $oldvalue && ! $newvalue)

        if ($onlyonenull) {
            return true;
        }
        $changed = ($oldvalue != $datenewvalue);
        return $changed;
    }

    public function isArrayChanged($oldvalue, $newvalue)
    {
        $twoboth = !$oldvalue && !$newvalue;
        if ($twoboth) {
            return false;
        }
        $onlyonenull = (!$oldvalue && $newvalue) || ($oldvalue && !$newvalue);

Consider adding parentheses for clarity. Current Interpretation: $onlyonenull = (! $oldvalue && $newvalue || $oldvalue && ! $newvalue), Probably Intended Meaning: $onlyonenull = ! $oldvalue && ($newvalue || $oldvalue && ! $newvalue)

        if ($onlyonenull) {
            return true;
        }
        $numdiff = array_diff($oldvalue, $newvalue);
        return count($numdiff) > 0;
    }

    public function truncateTable($entityclass, $cascade = false)
    {
        $cmd = $this->em->getClassMetadata($entityclass);
        $connection = $this->em->getConnection();
        $dbPlatform = $connection->getDatabasePlatform();
        $dbtype = $connection->getDriver()->getDatabasePlatform()->getName();
        $cascademysql = $cascade && $dbtype === 'mysql';
        if ($cascademysql) {
            $connection->query('SET FOREIGN_KEY_CHECKS=0');
        }
        $q = $dbPlatform->getTruncateTableSql($cmd->getTableName(), $cascade);
        $connection->executeUpdate($q);
        if ($cascademysql) {
            $connection->query('SET FOREIGN_KEY_CHECKS=1');
        }
        $this->em->clear();
    }

    public function isSchemaChanged()
    {
        $kernel = $this->container->get("kernel");
        $application = new Application($kernel);

It seems like $kernel can also be of type null; however, parameter $kernel of Symfony\Bundle\FrameworkBundle\Console\Application::__construct() does only seem to accept Symfony\Component\HttpKernel\KernelInterface, maybe add an additional type check?

        $application->setAutoExit(false);

        $input = new ArrayInput(array(
            'command' => 'doctrine:schema:update',
            '--dump-sql' => true,
            '--no-debug' => true,
            '--env' => $kernel->getEnvironment(),
        ));

        // You can use NullOutput() if you don't need the output
        $output = new BufferedOutput();
        $application->run($input, $output);

        // return the output, don't use if you used NullOutput()
        $content = $output->fetch();
        $changed = strpos($content, 'Nothing to update');
        return ($changed!==0);
    }
}