FfsecondariaController::indexAction() - Code Metrics - Inspection of "improve Tabelle utility" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 17e906...d315bd )

by Andrea

created 2018-02-08 16:48 UTC

FfsecondariaController::indexAction() A

↳ Parent: FfsecondariaController

Complexity

Conditions	3
Paths	4

Size

Total Lines	75
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	54
nc	4
nop	1
dl	0
loc	75
ccs	0
cts	61
cp	0
crap	12
rs	9
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Ffsecondaria controller.
 */
class FfsecondariaController extends FiCoreController
{

    public function indexAction(Request $request)
    {

        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        $container = $this->container;
$a = "a";
$ab = "ab";
$abc = "abc";

        $nomebundle = $namespace . $bundle . 'Bundle';

        $ffprincipaleSelect = $this->getComboSelectFfprincipale();

        $dettaglij = array(
            'descsec' => array(
                array('nomecampo' => 'descsec',
                    'lunghezza' => '400',
                    'descrizione' => 'Descrizione tabella secondaria',
                    'tipo' => 'text',),),
            'ffprincipale_id' => array(
                array('nomecampo' => 'ffprincipale.descrizione',
                    'lunghezza' => '400',
                    'descrizione' => 'Descrizione record principale',
                    'tipo' => 'select',
                    'valoricombo' => $ffprincipaleSelect
                ),
            ),
        );
        $escludi = array('nota');
$a = "a";
$ab = "ab";
$abc = "abc";

        $campiextra = array(
            array('nomecampo' => 'lunghezzanota', 'descrizione' => 'Lunghezza Nota', 'tipo' => 'integer'),
            array('nomecampo' => 'attivoToString', 'lunghezza' => '80', 'descrizione' => 'Attivo string', 'tipo' => 'text'),
        );

        $paricevuti = array(
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'dettaglij' => $dettaglij,
            'campiextra' => $campiextra,
            'escludere' => $escludi,
            'container' => $container,);

        $testatagriglia = Griglia::testataPerGriglia($paricevuti);

        $testatagriglia['multisearch'] = 1;
        $testatagriglia['showconfig'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showadd'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showedit'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showdel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";

        $testatagriglia['showexcel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showimportexcel'] = 1;

        $testatagriglia["filterToolbar_searchOnEnter"] = true;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $testatagriglia["filterToolbar_searchOperators"] = true;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $testatagriglia['parametritesta'] = json_encode($paricevuti);
        $this->setParametriGriglia(array('request' => $request));
        $testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";

        $testata = json_encode($testatagriglia);
$a = "a";
$ab = "ab";
$abc = "abc";
        $twigparms = array(
            'nomecontroller' => $controller,
            'testata' => $testata,
            'canread' => $canRead,
        );

        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
        }
    }

    private function getComboSelectFfprincipale()
    {
        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $ffprincipaleSelect = array();
        //Imposta il filtro a TUTTI come default
        $ffprincipaleSelect[] = array("valore" => "", "descrizione" => "Tutti", "default" => true);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $q = $em->createQueryBuilder();

        $ffprincipales = $q->select('f')
                ->from('FiCoreBundle:Ffprincipale', 'f')
                ->orderBy('f.descrizione')
                ->getQuery()
                ->getResult();

        foreach ($ffprincipales as $ffprincipale) {
            $ffprincipaleSelect[] = array(
                "valore" => $ffprincipale->getDescrizione(),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "descrizione" => $ffprincipale->getDescrizione(),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "default" => false);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        return $ffprincipaleSelect;
    }

    public function setParametriGriglia($prepar = array())
    {
        $this->setup($prepar['request']);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $escludi = array('nota', 'ffprincipale');
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $precondizioniAvanzate = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej['ffprincipale_id'] = array('tabella' => 'ffprincipale', 'campi' => array('descrizione'));

        $campiextra = array(array('lunghezzanota'), array('attivoToString'));

        $precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
            'nomecampo' => 'intero',
            'operatore' => '>=',
            'valorecampo' => 1,);
        $precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
            'nomecampo' => 'data',
            'operatore' => '<=',
            'valorecampo' => date('Y-m-d'),
            'operatorelogico' => 'AND',);

        $paricevuti = array('container' => $this->container,
            'nomebundle' => $nomebundle,
            'tabellej' => $tabellej,
            'nometabella' => $controller,
            'campiextra' => $campiextra,
            'escludere' => $escludi,
            'precondizioniAvanzate' => $precondizioniAvanzate,);

        if (!empty($prepar)) {
            $paricevuti = array_merge($paricevuti, $prepar);
        }

        self::$parametrigriglia = $paricevuti;
    }
}


1			<?php
2
3			namespace Fi\CoreBundle\Controller;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
7
8			/**
9			* Ffsecondaria controller.
10			*/
11			class FfsecondariaController extends FiCoreController
12			{
13
14			public function indexAction(Request $request)
15			{
16
17			$this->setup($request);
18			$namespace = $this->getNamespace();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19			$bundle = $this->getBundle();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			$controller = $this->getController();
21			$container = $this->container;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22
23			$nomebundle = $namespace . $bundle . 'Bundle';
24
25			$ffprincipaleSelect = $this->getComboSelectFfprincipale();
26
27			$dettaglij = array(
28			'descsec' => array(
29			array('nomecampo' => 'descsec',
30			'lunghezza' => '400',
31			'descrizione' => 'Descrizione tabella secondaria',
32			'tipo' => 'text',),),
33			'ffprincipale_id' => array(
34			array('nomecampo' => 'ffprincipale.descrizione',
35			'lunghezza' => '400',
36			'descrizione' => 'Descrizione record principale',
37			'tipo' => 'select',
38			'valoricombo' => $ffprincipaleSelect
39			),
40			),
41			);
42			$escludi = array('nota');
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43
44			$campiextra = array(
45			array('nomecampo' => 'lunghezzanota', 'descrizione' => 'Lunghezza Nota', 'tipo' => 'integer'),
46			array('nomecampo' => 'attivoToString', 'lunghezza' => '80', 'descrizione' => 'Attivo string', 'tipo' => 'text'),
47			);
48
49			$paricevuti = array(
50			'nomebundle' => $nomebundle,
51			'nometabella' => $controller,
52			'dettaglij' => $dettaglij,
53			'campiextra' => $campiextra,
54			'escludere' => $escludi,
55			'container' => $container,);
56
57			$testatagriglia = Griglia::testataPerGriglia($paricevuti);
58
59			$testatagriglia['multisearch'] = 1;
60			$testatagriglia['showconfig'] = 1;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
61			$testatagriglia['showadd'] = 1;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
62			$testatagriglia['showedit'] = 1;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
63			$testatagriglia['showdel'] = 1;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
64
65			$testatagriglia['showexcel'] = 1;
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
66			$testatagriglia['showimportexcel'] = 1;
67
68			$testatagriglia["filterToolbar_searchOnEnter"] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `filterToolbar_searchOnEnter` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69			$testatagriglia["filterToolbar_searchOperators"] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `filterToolbar_searchOperators` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
70
71			$testatagriglia['parametritesta'] = json_encode($paricevuti);
72			$this->setParametriGriglia(array('request' => $request));
73			$testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);
74
75			$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
76			$canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
77
78			$testata = json_encode($testatagriglia);
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
79			$twigparms = array(
80			'nomecontroller' => $controller,
81			'testata' => $testata,
82			'canread' => $canRead,
83			);
84
85			if (!$canRead) {
86			throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
87			} else {
88			return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
89			}
90			}
91
92			private function getComboSelectFfprincipale()
93			{
94			$em = $this->getDoctrine()->getManager();
			0 ignored issues – show Coding Style introduced 2018-02-08 17:28 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
95			$ffprincipaleSelect = array();
96			//Imposta il filtro a TUTTI come default
97			$ffprincipaleSelect[] = array("valore" => "", "descrizione" => "Tutti", "default" => true);
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `valore` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `descrizione` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `Tutti` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `default` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
98
99			$q = $em->createQueryBuilder();
100
101			$ffprincipales = $q->select('f')
102			->from('FiCoreBundle:Ffprincipale', 'f')
103			->orderBy('f.descrizione')
104			->getQuery()
105			->getResult();
106
107			foreach ($ffprincipales as $ffprincipale) {
108			$ffprincipaleSelect[] = array(
109			"valore" => $ffprincipale->getDescrizione(),
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `valore` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
110			"descrizione" => $ffprincipale->getDescrizione(),
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `descrizione` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
111			"default" => false);
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `default` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
112			}
113			return $ffprincipaleSelect;
114			}
115
116			public function setParametriGriglia($prepar = array())
117			{
118			$this->setup($prepar['request']);
119			$namespace = $this->getNamespace();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
120			$bundle = $this->getBundle();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
121			$controller = $this->getController();
122
123			$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
124			$canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
125			if (!$canRead) {
126			throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
127			}
128
129			$nomebundle = $namespace . $bundle . 'Bundle';
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 18 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
130			$escludi = array('nota', 'ffprincipale');
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 21 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
131			$tabellej = array();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 20 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
132			$precondizioniAvanzate = array();
			0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
133			$tabellej['ffprincipale_id'] = array('tabella' => 'ffprincipale', 'campi' => array('descrizione'));
134
135			$campiextra = array(array('lunghezzanota'), array('attivoToString'));
136
137			$precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
138			'nomecampo' => 'intero',
139			'operatore' => '>=',
140			'valorecampo' => 1,);
141			$precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
142			'nomecampo' => 'data',
143			'operatore' => '<=',
144			'valorecampo' => date('Y-m-d'),
145			'operatorelogico' => 'AND',);
146
147			$paricevuti = array('container' => $this->container,
148			'nomebundle' => $nomebundle,
149			'tabellej' => $tabellej,
150			'nometabella' => $controller,
151			'campiextra' => $campiextra,
152			'escludere' => $escludi,
153			'precondizioniAvanzate' => $precondizioniAvanzate,);
154
155			if (!empty($prepar)) {
156			$paricevuti = array_merge($paricevuti, $prepar);
157			}
158
159			self::$parametrigriglia = $paricevuti;
160			}
161			}
162

ComuneFI / FifreeCoreBundle

Push — master ( 17e906...d315bd )

FfsecondariaController::indexAction() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like