GeneratorHelper - Code Metrics - Inspection of "fix windows generator entity" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2a39ec...3b6c56 )

by Andrea

created 2018-11-17 22:45 UTC

GeneratorHelper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	178
Duplicated Lines	0 %

Test Coverage

Coverage

70.59%

Importance

Changes

Metric	Value
wmc	21
eloc	107
dl	0
loc	178
ccs	60
cts	85
cp	0.7059
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getDestinationEntityYmlPath()	3	1
A	getScriptGenerator()	12	3
A	getExportJsonFile()	10	2
B	checktables()	46	7
A	checkprerequisiti()	49	5
A	getJsonMwbGenerator()	28	1
A	removeExportJsonFile()	5	1

<?php

namespace Fi\PannelloAmministrazioneBundle\DependencyInjection;

use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;
use MwbExporter\Model\Table;

class GeneratorHelper
{

    private $container;
    private $apppaths;

    public function __construct($container)
    {
        $this->container = $container;
        $this->apppaths = $container->get("pannelloamministrazione.projectpath");
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    public function getDestinationEntityYmlPath()
    {
        return str_replace('/', "\/", str_replace('\\', '/', realpath($this->apppaths->getSrcPath() . '/../src/Entity/')));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    public function checktables($destinationPath, $wbFile, $output)
    {
        $finder = new Finder();
        $fs = new Filesystem();
$a = "a";
$ab = "ab";
$abc = "abc";

        $pathdoctrineyml = $destinationPath;

        //Si converte il nome file tabella.orm.yml se ha undercore
        $finder->in($pathdoctrineyml)->files()->name('*_*');
        $table = new Table();

        foreach ($finder as $file) {
            $oldfilename = $file->getPathName();
            $newfilename = $pathdoctrineyml . DIRECTORY_SEPARATOR . $table->beautify($file->getFileName());
            $fs->rename($oldfilename, $newfilename, true);
        }

        //Si cercano file con nomi errati
        $finderwrong = new Finder();
        $finderwrong->in($pathdoctrineyml)->files()->name('*_*');
        $wrongfilename = array();
        if (count($finderwrong) > 0) {
            foreach ($finderwrong as $file) {
                $wrongfilename[] = $file->getFileName();
                $fs->remove($pathdoctrineyml . DIRECTORY_SEPARATOR . $file->getFileName());
            }
        }
        $finderwrongcapitalize = new Finder();
        $finderwrongcapitalize->in($pathdoctrineyml)->files()->name('*.yml');
        foreach ($finderwrongcapitalize as $file) {
            if (!ctype_upper(substr($file->getFileName(), 0, 1))) {
                $wrongfilename[] = $file->getFileName();
                $fs->remove($pathdoctrineyml . DIRECTORY_SEPARATOR . $file->getFileName());
            }
        }

        if (count($wrongfilename) > 0) {
            $errout = '<error>Ci sono tabelle nel file ' . $wbFile . ' con nomi non consentiti:' .
                    implode(',', $wrongfilename) .
                    '. I nomi tabella devono essere : con la prima lettera maiuscola,underscore ammesso,doppio underscore non ammesso</error>';

            $output->writeln($errout);

            return -1;
        } else {
            return 0;
        }
    }

    public function checkprerequisiti($mwbfile, $output)
    {
        $fs = new Filesystem();

        $wbFile = $this->apppaths->getDocPath() . DIRECTORY_SEPARATOR . $mwbfile;
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundlePath = $this->apppaths->getSrcPath();

        $viewsPath = $bundlePath .
$a = "a";
$ab = "ab";
$abc = "abc";
                DIRECTORY_SEPARATOR . 'templates' . DIRECTORY_SEPARATOR;
        $entityPath = $bundlePath .
                DIRECTORY_SEPARATOR . 'Entity' . DIRECTORY_SEPARATOR;
        $formPath = $bundlePath .
$a = "a";
$ab = "ab";
$abc = "abc";
                DIRECTORY_SEPARATOR . 'Form' . DIRECTORY_SEPARATOR;

        $scriptGenerator = $this->getScriptGenerator();

        $destinationPath = $this->getDestinationEntityYmlPath();
        $output->writeln('Creazione entities yml in ' . $destinationPath . ' da file ' . $mwbfile);

        if (!$fs->exists($bundlePath)) {
            $output->writeln('<error>Non esiste la cartella del bundle ' . $bundlePath . '</error>');

            return -1;
        }

        /* Creazione cartelle se non esistono nel bundle per l'esportazione */
        $fs->mkdir($destinationPath);
        $fs->mkdir($entityPath);
        $fs->mkdir($formPath);
        $fs->mkdir($viewsPath);

        if (!$fs->exists($wbFile)) {
            $output->writeln("<error>Nella cartella 'doc' non è presente il file " . $mwbfile . '!');

            return -1;
        }

        if (!$fs->exists($scriptGenerator)) {
            $output->writeln('<error>Non è presente il comando ' . $scriptGenerator . ' per esportare il modello!</error>');

            return -1;
        }
        if (!$fs->exists($destinationPath)) {
            $output->writeln("<error>Non esiste la cartella per l'esportazione " . $destinationPath . ', controllare il nome del Bundle!</error>');

            return -1;
        }

        return 0;
    }

    public function getScriptGenerator()
    {
        $scriptGenerator = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $scriptGenerator = $this->apppaths->getVendorBinPath() . DIRECTORY_SEPARATOR . 'mysql-workbench-schema-export';
        if (!file_exists($scriptGenerator)) {
            $scriptGenerator = dirname(dirname(__FILE__)) . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR .
                    'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'mysql-workbench-schema-export';
        }
        if (!$scriptGenerator) {
            throw new \Exception("mysql-workbench-schema-export non trovato", -100);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        return $scriptGenerator;
    }

    public function getExportJsonFile()
    {
        $fs = new Filesystem();
$a = "a";
$ab = "ab";
$abc = "abc";
        $cachedir = $this->apppaths->getCachePath();
$a = "a";
$ab = "ab";
$abc = "abc";
        $exportJson = $cachedir . DIRECTORY_SEPARATOR . 'export.json';
        if ($fs->exists($exportJson)) {
            $fs->remove($exportJson);
        }

        return $exportJson;
    }

    public function removeExportJsonFile()
    {
        $this->getExportJsonFile();

        return true;
    }

    public static function getJsonMwbGenerator()
    {
        $jsonTemplate = <<<EOF
{"export": "doctrine2-annotation",
    "zip": false,
    "dir": "[dir]",
    "params":
            {"indentation": 4,
                "useTabs": false, 
                "filename": "%entity%.%extension%",
                "skipPluralNameChecking": true,
                "backupExistingFile": false,
                "addGeneratorInfoAsComment": false,
                "useLoggedStorage": false,
                "enhanceManyToManyDetection": true,
                "logToConsole": false,
                "logFile": "",
                "bundleNamespace": "App",
                "entityNamespace": "Entity",
                "repositoryNamespace": "App\\\\Entity",
                "useAutomaticRepository": false,
                "generateExtendableEntity": true,
                "extendableEntityHasDiscriminator": false,
                "extendTableNameWithSchemaName": false
            }
}
EOF;
        return $jsonTemplate;
    }
}


1		<?php
2
3		namespace Fi\PannelloAmministrazioneBundle\DependencyInjection;
4
5		use Symfony\Component\Filesystem\Filesystem;
6		use Symfony\Component\Finder\Finder;
7		use MwbExporter\Model\Table;
8
9		class GeneratorHelper
10		{
11
12		private $container;
13		private $apppaths;
14
15	2	public function __construct($container)
16		{
17	2	$this->container = $container;
18	2	$this->apppaths = $container->get("pannelloamministrazione.projectpath");
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione.projectpath` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19	2	}
20
21	2	public function getDestinationEntityYmlPath()
22		{
23	2	return str_replace('/', "\/", str_replace('\\', '/', realpath($this->apppaths->getSrcPath() . '/../src/Entity/')));
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-10-11 10:03 UTC by Report Bug Copy Issue Report The string literal `\/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
24		}
25
26	2	public function checktables($destinationPath, $wbFile, $output)
27		{
28	2	$finder = new Finder();
29	2	$fs = new Filesystem();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30
31	2	$pathdoctrineyml = $destinationPath;
32
33		//Si converte il nome file tabella.orm.yml se ha undercore
34	2	$finder->in($pathdoctrineyml)->files()->name('_');
35	2	$table = new Table();
36
37	2	foreach ($finder as $file) {
38		$oldfilename = $file->getPathName();
39		$newfilename = $pathdoctrineyml . DIRECTORY_SEPARATOR . $table->beautify($file->getFileName());
40		$fs->rename($oldfilename, $newfilename, true);
41		}
42
43		//Si cercano file con nomi errati
44	2	$finderwrong = new Finder();
45	2	$finderwrong->in($pathdoctrineyml)->files()->name('_');
46	2	$wrongfilename = array();
47	2	if (count($finderwrong) > 0) {
48		foreach ($finderwrong as $file) {
49		$wrongfilename[] = $file->getFileName();
50		$fs->remove($pathdoctrineyml . DIRECTORY_SEPARATOR . $file->getFileName());
51		}
52		}
53	2	$finderwrongcapitalize = new Finder();
54	2	$finderwrongcapitalize->in($pathdoctrineyml)->files()->name('*.yml');
55	2	foreach ($finderwrongcapitalize as $file) {
56		if (!ctype_upper(substr($file->getFileName(), 0, 1))) {
57		$wrongfilename[] = $file->getFileName();
58		$fs->remove($pathdoctrineyml . DIRECTORY_SEPARATOR . $file->getFileName());
59		}
60		}
61
62	2	if (count($wrongfilename) > 0) {
63		$errout = '<error>Ci sono tabelle nel file ' . $wbFile . ' con nomi non consentiti:' .
64		implode(',', $wrongfilename) .
65		'. I nomi tabella devono essere : con la prima lettera maiuscola,underscore ammesso,doppio underscore non ammesso</error>';
66
67		$output->writeln($errout);
68
69		return -1;
70		} else {
71	2	return 0;
72		}
73		}
74
75	2	public function checkprerequisiti($mwbfile, $output)
76		{
77	2	$fs = new Filesystem();
78
79	2	$wbFile = $this->apppaths->getDocPath() . DIRECTORY_SEPARATOR . $mwbfile;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80	2	$bundlePath = $this->apppaths->getSrcPath();
81
82		$viewsPath = $bundlePath .
		0 ignored issues – show Coding Style introduced 2018-03-22 22:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
83	2	DIRECTORY_SEPARATOR . 'templates' . DIRECTORY_SEPARATOR;
84		$entityPath = $bundlePath .
85	2	DIRECTORY_SEPARATOR . 'Entity' . DIRECTORY_SEPARATOR;
86		$formPath = $bundlePath .
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
87	2	DIRECTORY_SEPARATOR . 'Form' . DIRECTORY_SEPARATOR;
88
89	2	$scriptGenerator = $this->getScriptGenerator();
90
91	2	$destinationPath = $this->getDestinationEntityYmlPath();
92	2	$output->writeln('Creazione entities yml in ' . $destinationPath . ' da file ' . $mwbfile);
93
94	2	if (!$fs->exists($bundlePath)) {
95		$output->writeln('<error>Non esiste la cartella del bundle ' . $bundlePath . '</error>');
96
97		return -1;
98		}
99
100		/* Creazione cartelle se non esistono nel bundle per l'esportazione */
101	2	$fs->mkdir($destinationPath);
102	2	$fs->mkdir($entityPath);
103	2	$fs->mkdir($formPath);
104	2	$fs->mkdir($viewsPath);
105
106	2	if (!$fs->exists($wbFile)) {
107		$output->writeln("<error>Nella cartella 'doc' non è presente il file " . $mwbfile . '!');
108
109		return -1;
110		}
111
112	2	if (!$fs->exists($scriptGenerator)) {
113		$output->writeln('<error>Non è presente il comando ' . $scriptGenerator . ' per esportare il modello!</error>');
114
115		return -1;
116		}
117	2	if (!$fs->exists($destinationPath)) {
118		$output->writeln("<error>Non esiste la cartella per l'esportazione " . $destinationPath . ', controllare il nome del Bundle!</error>');
119
120		return -1;
121		}
122
123	2	return 0;
124		}
125
126	2	public function getScriptGenerator()
127		{
128	2	$scriptGenerator = "";
		0 ignored issues – show Unused Code introduced 2018-10-11 08:19 UTC by Report Bug Copy Issue Report The assignment to `$scriptGenerator` is dead and can be removed. Loading history... Coding Style Comprehensibility introduced 2018-10-11 08:19 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
129	2	$scriptGenerator = $this->apppaths->getVendorBinPath() . DIRECTORY_SEPARATOR . 'mysql-workbench-schema-export';
130	2	if (!file_exists($scriptGenerator)) {
131		$scriptGenerator = dirname(dirname(__FILE__)) . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR .
132		'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'mysql-workbench-schema-export';
133		}
134	2	if (!$scriptGenerator) {
135		throw new \Exception("mysql-workbench-schema-export non trovato", -100);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `mysql-workbench-schema-export non trovato` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
136		}
137	2	return $scriptGenerator;
138		}
139
140	2	public function getExportJsonFile()
141		{
142	2	$fs = new Filesystem();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
143	2	$cachedir = $this->apppaths->getCachePath();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
144	2	$exportJson = $cachedir . DIRECTORY_SEPARATOR . 'export.json';
145	2	if ($fs->exists($exportJson)) {
146	2	$fs->remove($exportJson);
147		}
148
149	2	return $exportJson;
150		}
151
152	2	public function removeExportJsonFile()
153		{
154	2	$this->getExportJsonFile();
155
156	2	return true;
157		}
158
159	2	public static function getJsonMwbGenerator()
160		{
161		$jsonTemplate = <<<EOF
162	2	{"export": "doctrine2-annotation",
163		"zip": false,
164		"dir": "[dir]",
165		"params":
166		{"indentation": 4,
167		"useTabs": false,
168		"filename": "%entity%.%extension%",
169		"skipPluralNameChecking": true,
170		"backupExistingFile": false,
171		"addGeneratorInfoAsComment": false,
172		"useLoggedStorage": false,
173		"enhanceManyToManyDetection": true,
174		"logToConsole": false,
175		"logFile": "",
176		"bundleNamespace": "App",
177		"entityNamespace": "Entity",
178		"repositoryNamespace": "App\\\\Entity",
179		"useAutomaticRepository": false,
180		"generateExtendableEntity": true,
181		"extendableEntityHasDiscriminator": false,
182		"extendTableNameWithSchemaName": false
183		}
184		}
185		EOF;
186	2	return $jsonTemplate;
187		}
188		}
189

ComuneFI / FifreeCoreBundle

Push — master ( 2a39ec...3b6c56 )

GeneratorHelper A

Complexity

Size/Duplication

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like