BaseTabellaDecoder - Code Metrics - Inspection of "refactor" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — 4.1 ( 15ef68...fe3b41 )

by Andrea
created 2018-11-15 19:17 UTC
BaseTabellaDecoder A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	139
Duplicated Lines	0 %
Test Coverage

Coverage
88.89%
Importance

Changes
Metric	Value
wmc	25
eloc	90
dl	0
loc	139
ccs	72
cts	81
cp	0.8889
rs	10
c	0
b	0
f	0
10 Methods

Rating	Name	Size	Complexity
A	generaAlias()	22	5
A	findAliasByTablename()	9	2
A	getDescrizioneFiltro()	4	2
A	getTabellaParameter()	9	2
A	bonificanomecampo()	12	3
A	getAliasGenerato()	3	1
A	findFieldnameByAlias()	9	2
A	getFieldValue()	7	2
A	parseParameters()	17	2
A	getOperator()	18	4
<?php

namespace Fi\CoreBundle\Utils\Tabella;

use \Doctrine\Common\Collections\Expr\Comparison;
use Fi\CoreBundle\Utils\Tabella\ParametriTabella;

class BaseTabellaDecoder
{
    protected $entityname;
    protected $tablename;
    protected $colonnedatabase;
    protected $modellocolonne;
    protected $paginacorrente;
    protected $righeperpagina;
    protected $estraituttirecords;
    protected $prefiltri;
    protected $filtri;
    protected $wheremanuale;
    protected $colonneordinamento;
    protected $opzionitabellacore;
    protected $configurazionecolonnetabella;
    private $aliasGenerati;
    private $decodificaAlias;

    protected function parseParameters()
    {
        $this->tablename = $this->getTabellaParameter("tablename");
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->entityname = $this->getTabellaParameter("entityclass");
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->entityname = str_replace("FiCoreBundle", "CoreBundle", $this->entityname);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->permessi = json_decode($this->getTabellaParameter("permessi"));
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->modellocolonne = json_decode($this->getTabellaParameter('modellocolonne', array()), true);
        $this->modellocolonne = json_decode(/** @scrutinizer ignore-type */ $this->getTabellaParameter('modellocolonne', array()), true);
        $this->paginacorrente = $this->getTabellaParameter("paginacorrente");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->paginetotali = $this->getTabellaParameter("paginetotali");
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->righeperpagina = $this->getTabellaParameter('righeperpagina', 15);

        $this->estraituttirecords = $this->getTabellaParameter('estraituttirecords', 0) === "1" ? true : false;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->colonneordinamento = json_decode($this->getTabellaParameter('colonneordinamento', array()), true);
        $this->prefiltri = json_decode($this->getTabellaParameter('prefiltri', array()), true);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->filtri = json_decode($this->getTabellaParameter('filtri', array()), true);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->wheremanuale = $this->getTabellaParameter("wheremanuale", null);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->user = $this->parametri["user"];
$a = "a";
$ab = "ab";
$abc = "abc";
    }
    protected function getTabellaParameter($name, $default = null)
    {
        $risposta = null;
        if (isset($this->parametri[$name])) {
            $risposta = ParametriTabella::getParameter($this->parametri[$name]);
        } else {
            $risposta = $default;
        }
        return $risposta;
    }
    protected function getDescrizioneFiltro(&$descrizionefiltri, $filtrocorrente, $criteria)
    {
        if ($filtrocorrente["prefiltro"] === false) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $descrizionefiltri = $descrizionefiltri . ", " . $criteria->getDescrizioneFiltro();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
    }
    protected function getFieldValue($fieldvalue)
    {
        if (isset($fieldvalue["date"])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            //StdClassUtils::arrayToObject($fieldvalue, DatetimeTabella::class);

            return new \Datetime($fieldvalue["date"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            return $fieldvalue;
        }
    }
    protected function getOperator($operator)
    {

        switch (strtoupper($operator)) {
            case "LIKE":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::CONTAINS;
                break;
            case "IN":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::IN;
                break;
            case "NOT IN":
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $operator = Comparison::NIN;
                break;
            default:
                break;
        }

        return $operator;
    }
    protected function bonificanomecampo($nomecampo)
    {
        $parti = explode(".", $nomecampo);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $campo = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        for ($index = 0; $index < count($parti); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if ($index == count($parti) - 1) {
                $campo .= "." . lcfirst($parti[$index]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            } else {
                $campo .= "." . ucfirst($parti[$index]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
        return substr($campo, 1);
    }
    protected function generaAlias($nometabella, $nomepadre = false, $ancestors = array())
    {
        $nometabellapulito = preg_replace('/[^a-z0-9\.]/i', '', $nometabella);
        $primalettera = strtolower(substr($nometabellapulito, 0, 1));
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($nomepadre && !in_array($nomepadre, $ancestors)) {
            $ancestors[] = $nomepadre;
        }
        if (!in_array($nometabella, $ancestors)) {
            $ancestors[] = $nometabella;
        }

        if (isset($this->aliasGenerati[$primalettera])) {
            $risposta = $primalettera . $this->aliasGenerati[$primalettera];
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->aliasGenerati[$primalettera] = $this->aliasGenerati[$primalettera] + 1;
        } else {
            $risposta = $primalettera;
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->aliasGenerati[$primalettera] = 1;
        }

        $this->decodificaAlias[ucfirst(implode(".", $ancestors))] = array("alias" => $risposta);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        return $risposta;
    }
    protected function findAliasByTablename($tablename)
    {
        if (!array_key_exists($tablename, $this->decodificaAlias)) {
            $ex = "Fifree: table or association " . $tablename . " not found, did you mean one of these:\n" .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    implode("\n", array_keys($this->decodificaAlias)) .
                    " ?";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            throw new \Exception($ex);
        }
        return $this->getAliasGenerato($tablename);
    }
    protected function findFieldnameByAlias($nomecampo)
    {
        if (!array_key_exists($nomecampo, $this->configurazionecolonnetabella)) {
            $ex = "Fifree: field or association " . $nomecampo . " not found, did you mean one of these:\n" .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    implode("\n", array_keys($this->configurazionecolonnetabella)) .
                    " ?";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            throw new \Exception($ex);
        }
        return $this->configurazionecolonnetabella[$nomecampo];
    }
    public function getAliasGenerato($tablename)
    {
        return $this->decodificaAlias[$tablename]["alias"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
}

ComuneFI / FifreeCoreBundle

Push — 4.1 ( 15ef68...fe3b41 )

BaseTabellaDecoder A

Complexity

Size/Duplication

Test Coverage

Importance

10 Methods

Duplication Side-by-Side

Filter issues like
