Fifree2configuratorexportCommand::entityExists() - Code Metrics - Inspection of "fix import fifree configuration" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6f8d59...e8056d )

by Andrea

created 2018-02-12 19:55 UTC

Fifree2configuratorexportCommand::entityExists() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.576

Importance

Changes

Metric	Value
cc	3
eloc	3
nc	3
nop	1
dl	0
loc	8
ccs	3
cts	5
cp	0.6
crap	3.576
rs	9.4285
c	0
b	0
f	0

<?php

namespace Fi\CoreBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Yaml\Yaml;
use Symfony\Component\Filesystem\Filesystem;
use Doctrine\Common\Persistence\Proxy;

class Fifree2configuratorexportCommand extends ContainerAwareCommand
{

    private $entities = array();

    protected function configure()
    {
        $this
                ->setName('fifree2:configuratorexport')
                ->setDescription('Configuratore per Fifree')
                ->setHelp('Esporta la configurazione di fifree')
                ->addArgument('entity', InputArgument::REQUIRED, 'Entity da esportare')
                ->addOption('append', null, InputOption::VALUE_NONE, 'Append per export');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $fs = new Filesystem;
$a = "a";
$ab = "ab";
$abc = "abc";
        $append = $input->getOption('append');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->em = $this->getContainer()->get("doctrine")->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->output = $output;

        $entity = $input->getArgument('entity');
$a = "a";
$ab = "ab";
$abc = "abc";

        try {
            //$fixturefile = $this->getContainer()->get('kernel')->locateResource('@FiCoreBundle/Resources/config/fixtures.yml');

            $fixturefile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . "fixtures.yml";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if (!$append) {
                $fs->remove($fixturefile);
            }
            return $this->export($fixturefile, $entity);
        } catch (\Exception $exc) {
            echo $exc->getMessage() . " at line " . $exc->getLine();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
    }

    protected function export($fixturefile, $entity)
    {
        $entityclass = "Fi\\CoreBundle\\Entity\\" . $entity;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $ret = $this->exportEntity($fixturefile, $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($ret == 0) {
            foreach ($this->entities as $entity) {

                $this->output->writeln("<info>Esporto " . $entity . " su file</info>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $this->exportEntityToFile($fixturefile, $entity);
            }
            $this->exportEntityToFile($fixturefile, $entityclass);
            return 0;
        }
        return 1;
    }

    private function exportEntity($fixturefile, $entityclass)
    {
        $dbutility = $this->getContainer()->get("ficorebundle.database.utility");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->output->writeln("<info>Export Entity: " . $entityclass . "</info>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($dbutility->entityExists($entityclass)) {
            $hasEntityCollegate = $dbutility->entityHasJoinTables($entityclass);
            if ($hasEntityCollegate) {
                $this->output->writeln("<info>Entity " . $entityclass . " ha tabelle in join</info>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $entityCollegata = $dbutility->getEntityJoinTables($entityclass);
                foreach ($entityCollegata as $key => $tabella) {
                    $this->entities[] = $key;
                    $this->output->writeln("<info>Prima esporto " . $key . " -> " . $tabella["entity"]["fieldName"] . "</info>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->exportEntity($fixturefile, $key);
                }
            }
        } else {
            $this->output->writeln("<error>Entity not found: " . $entityclass . " </error>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return 1;
        }
        return 0;
    }

    private function exportEntityToFile($fixturefile, $entityclass)
    {
        $entityDump = array();


        $query = $this->em->createQueryBuilder()
                ->select('p')
                ->from($entityclass, 'p')
                ->getQuery()
        ;
        $repo = $query->getArrayResult();
$a = "a";
$ab = "ab";
$abc = "abc";


        //$repo = $this->em->getRepository($entityclass)->findAll();

        $this->output->writeln("<info>Trovate " . count($repo) . " records per l'entity " . $entityclass . "</info>");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        foreach ($repo as $row) {
            $entityDump[$entityclass][] = $row;
        }
        $yml = Yaml::dump($entityDump);
        file_put_contents($fixturefile, $yml, FILE_APPEND);
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Command;
4
5		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6		use Symfony\Component\Console\Input\InputInterface;
7		use Symfony\Component\Console\Output\OutputInterface;
8		use Symfony\Component\Console\Input\InputOption;
9		use Symfony\Component\Console\Input\InputArgument;
10		use Symfony\Component\Yaml\Yaml;
11		use Symfony\Component\Filesystem\Filesystem;
12		use Doctrine\Common\Persistence\Proxy;
13
14		class Fifree2configuratorexportCommand extends ContainerAwareCommand
15		{
16
17		private $entities = array();
18
19	4	protected function configure()
20		{
21	4	$this
22	4	->setName('fifree2:configuratorexport')
23	4	->setDescription('Configuratore per Fifree')
24	4	->setHelp('Esporta la configurazione di fifree')
25	4	->addArgument('entity', InputArgument::REQUIRED, 'Entity da esportare')
26	4	->addOption('append', null, InputOption::VALUE_NONE, 'Append per export');
27	4	}
28
29	1	protected function execute(InputInterface $input, OutputInterface $output)
30		{
31	1	$fs = new Filesystem;
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32	1	$append = $input->getOption('append');
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33	1	$this->em = $this->getContainer()->get("doctrine")->getManager();
		0 ignored issues – show Bug Best Practice introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The property `em` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history... Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `doctrine` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
34	1	$this->output = $output;
		0 ignored issues – show Bug Best Practice introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The property `output` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
35	1	$entity = $input->getArgument('entity');
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36
37		try {
38		//$fixturefile = $this->getContainer()->get('kernel')->locateResource('@FiCoreBundle/Resources/config/fixtures.yml');
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
39	1	$fixturefile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . "fixtures.yml";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-12 09:11 UTC by Report Bug Copy Issue Report The string literal `fixtures.yml` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
40	1	if (!$append) {
41	1	$fs->remove($fixturefile);
42	1	}
43	1	return $this->export($fixturefile, $entity);
44		} catch (\Exception $exc) {
45		echo $exc->getMessage() . " at line " . $exc->getLine();
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `at line` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
46		}
47		}
48
49	1	protected function export($fixturefile, $entity)
50		{
51	1	$entityclass = "Fi\\CoreBundle\\Entity\\" . $entity;
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `Fi\\CoreBundle\\Entity\\` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
52	1	$ret = $this->exportEntity($fixturefile, $entityclass);
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
53	1	if ($ret == 0) {
54	1	foreach ($this->entities as $entity) {
		0 ignored issues – show introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report `$entity` is overwriting one of the parameters of this function. Loading history...
55	1	$this->output->writeln("<info>Esporto " . $entity . " su file</info>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<info>Esporto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `su file</info>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
56	1	$this->exportEntityToFile($fixturefile, $entity);
57	1	}
58	1	$this->exportEntityToFile($fixturefile, $entityclass);
59	1	return 0;
60		}
61		return 1;
62		}
63
64	1	private function exportEntity($fixturefile, $entityclass)
65		{
66	1	$dbutility = $this->getContainer()->get("ficorebundle.database.utility");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-12 18:34 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.database.utility` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67	1	$this->output->writeln("<info>Export Entity: " . $entityclass . "</info>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<info>Export Entity:` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `</info>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
68	1	if ($dbutility->entityExists($entityclass)) {
69	1	$hasEntityCollegate = $dbutility->entityHasJoinTables($entityclass);
70	1	if ($hasEntityCollegate) {
71	1	$this->output->writeln("<info>Entity " . $entityclass . " ha tabelle in join</info>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<info>Entity` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `ha tabelle in join</info>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72	1	$entityCollegata = $dbutility->getEntityJoinTables($entityclass);
73	1	foreach ($entityCollegata as $key => $tabella) {
74	1	$this->entities[] = $key;
75	1	$this->output->writeln("<info>Prima esporto " . $key . " -> " . $tabella["entity"]["fieldName"] . "</info>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<info>Prima esporto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `->` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `entity` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `fieldName` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `</info>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
76	1	$this->exportEntity($fixturefile, $key);
77	1	}
78	1	}
79	1	} else {
80		$this->output->writeln("<error>Entity not found: " . $entityclass . " </error>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<error>Entity not found:` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `</error>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
81		return 1;
82		}
83	1	return 0;
84		}
85
86	1	private function exportEntityToFile($fixturefile, $entityclass)
87		{
88	1	$entityDump = array();
89
90
91	1	$query = $this->em->createQueryBuilder()
92	1	->select('p')
93	1	->from($entityclass, 'p')
94	1	->getQuery()
95	1	;
96	1	$repo = $query->getArrayResult();
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
97
98
99		//$repo = $this->em->getRepository($entityclass)->findAll();
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
100	1	$this->output->writeln("<info>Trovate " . count($repo) . " records per l'entity " . $entityclass . "</info>");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `<info>Trovate` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `</info>` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
101	1	foreach ($repo as $row) {
102	1	$entityDump[$entityclass][] = $row;
103	1	}
104	1	$yml = Yaml::dump($entityDump);
105	1	file_put_contents($fixturefile, $yml, FILE_APPEND);
106	1	}
107		}
108

ComuneFI / FifreeCoreBundle

Push — master ( 6f8d59...e8056d )

Fifree2configuratorexportCommand::entityExists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like