DatabaseUtility - Code Metrics - Inspection of "fix import fifree configuration" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6f8d59...e8056d )

by Andrea

created 2018-02-12 19:55 UTC

DatabaseUtility A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Test Coverage

Coverage

88.71%

Importance

Changes

Metric	Value
dl	0
loc	103
ccs	55
cts	62
cp	0.8871
rs	9.8
c	0
b	0
f	0
wmc	31

9 Methods

Rating	Name	Size	Complexity
B	isDateChanged()	11	7
A	entityHasJoinTables()	4	2
A	__construct()	4	1
A	getFieldType()	7	1
A	getEntityProperties()	16	4
B	isArrayChanged()	9	7
A	isRecordChanged()	11	3
A	entityExists()	8	3
A	getEntityJoinTables()	11	3

<?php

namespace Fi\CoreBundle\DependencyInjection;

use Symfony\Component\DependencyInjection\ContainerInterface as Container;

class DatabaseUtility
{

    private $container;
    private $em;

    public function __construct(Container $container)
    {
        $this->container = $container;
        $this->em = $this->container->get("doctrine")->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    public function getFieldType($entity, $field)
    {
        $metadata = $this->em->getClassMetadata(get_class($entity));
$a = "a";
$ab = "ab";
$abc = "abc";
        $fieldMetadata = $metadata->fieldMappings[$field];

        $fieldType = $fieldMetadata['type'];
        return $fieldType;
    }

    public function getEntityProperties($fieldname, $objrecord)
    {
        $parametri = array('str' => $fieldname, 'primamaiuscola' => true);
$a = "a";
$ab = "ab";
$abc = "abc";
        $getfieldname = \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
        if (!method_exists($objrecord, $getfieldname)) {
            $getfieldname = "has" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if (!method_exists($objrecord, $getfieldname)) {
                $getfieldname = "is" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                if (!method_exists($objrecord, $getfieldname)) {
                    $getfieldname = "get" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
            }
        }
        $setfieldname = "set" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        return array("get" => $getfieldname, "set" => $setfieldname);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    public function isRecordChanged($entity, $fieldname, $oldvalue, $newvalue)
    {
        $fieldtype = $this->getFieldType(new $entity(), $fieldname);
        if ($fieldtype === 'datetime') {
            return $this->isDateChanged($oldvalue, $newvalue);
        }
        if (is_array($oldvalue)) {
            return $this->isArrayChanged($oldvalue, $newvalue);
        }

        return ($oldvalue !== $newvalue);
    }

    public function isDateChanged($oldvalue, $newvalue)
    {
        $datenewvalue = new \DateTime();
        $datenewvalue->setTimestamp($newvalue);
        if (!$oldvalue && !$newvalue) {
            return false;
        }
        if ((!$oldvalue && $newvalue) || ($oldvalue && !$newvalue)) {
            return true;
        }
        return ($oldvalue != $datenewvalue);
    }

    public function isArrayChanged($oldvalue, $newvalue)
    {
        if (!$oldvalue && !$newvalue) {
            return false;
        }
        if ((!$oldvalue && $newvalue) || ($oldvalue && !$newvalue)) {
            return true;
        }
        return count(array_diff($oldvalue, $newvalue)) > 0;
    }

    public function entityExists($className)
    {

        if (is_object($className)) {
            $className = ($className instanceof Proxy) ? get_parent_class($className) : get_class($className);
filter:
    dependency_paths: ["lib/*"]
        }

        return !$this->em->getMetadataFactory()->isTransient($className);
    }

    public function getEntityJoinTables($entityclass)
    {
        $jointables = array();
        $metadata = $this->em->getClassMetadata($entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";
        $fielsassoc = $metadata->associationMappings;
        foreach ($fielsassoc as $tableassoc) {
            if ($tableassoc["inversedBy"]) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $jointables[$tableassoc["targetEntity"]] = array("entity" => $tableassoc);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
        return $jointables;
    }

    public function entityHasJoinTables($entityclass)
    {
        $jointables = $this->getEntityJoinTables($entityclass);
        return count($jointables) > 0 ? true : false;
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\DependencyInjection;
4
5		use Symfony\Component\DependencyInjection\ContainerInterface as Container;
6
7		class DatabaseUtility
8		{
9
10		private $container;
11		private $em;
12
13	1	public function __construct(Container $container)
14		{
15	1	$this->container = $container;
16	1	$this->em = $this->container->get("doctrine")->getManager();
		0 ignored issues – show Coding Style introduced 2018-02-12 20:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-12 18:34 UTC by Report Bug Copy Issue Report The string literal `doctrine` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
17	1	}
18
19	1	public function getFieldType($entity, $field)
20		{
21	1	$metadata = $this->em->getClassMetadata(get_class($entity));
		0 ignored issues – show Coding Style introduced 2018-02-11 22:59 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22	1	$fieldMetadata = $metadata->fieldMappings[$field];
23
24	1	$fieldType = $fieldMetadata['type'];
25	1	return $fieldType;
26		}
27
28	1	public function getEntityProperties($fieldname, $objrecord)
29		{
30	1	$parametri = array('str' => $fieldname, 'primamaiuscola' => true);
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31	1	$getfieldname = \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
32	1	if (!method_exists($objrecord, $getfieldname)) {
33	1	$getfieldname = "has" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `has` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
34	1	if (!method_exists($objrecord, $getfieldname)) {
35	1	$getfieldname = "is" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `is` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
36	1	if (!method_exists($objrecord, $getfieldname)) {
37	1	$getfieldname = "get" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `get` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
38	1	}
39	1	}
40	1	}
41	1	$setfieldname = "set" . \Fi\CoreBundle\Utils\GrigliaUtils::toCamelCase($parametri);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `set` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
42
43	1	return array("get" => $getfieldname, "set" => $setfieldname);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `get` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `set` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
44		}
45
46	1	public function isRecordChanged($entity, $fieldname, $oldvalue, $newvalue)
47		{
48	1	$fieldtype = $this->getFieldType(new $entity(), $fieldname);
49	1	if ($fieldtype === 'datetime') {
50	1	return $this->isDateChanged($oldvalue, $newvalue);
51		}
52	1	if (is_array($oldvalue)) {
53	1	return $this->isArrayChanged($oldvalue, $newvalue);
54		}
55
56	1	return ($oldvalue !== $newvalue);
57		}
58
59	1	public function isDateChanged($oldvalue, $newvalue)
60		{
61	1	$datenewvalue = new \DateTime();
62	1	$datenewvalue->setTimestamp($newvalue);
63	1	if (!$oldvalue && !$newvalue) {
64	1	return false;
65		}
66		if ((!$oldvalue && $newvalue) \|\| ($oldvalue && !$newvalue)) {
67		return true;
68		}
69		return ($oldvalue != $datenewvalue);
70		}
71
72	1	public function isArrayChanged($oldvalue, $newvalue)
73		{
74	1	if (!$oldvalue && !$newvalue) {
75		return false;
76		}
77	1	if ((!$oldvalue && $newvalue) \|\| ($oldvalue && !$newvalue)) {
78		return true;
79		}
80	1	return count(array_diff($oldvalue, $newvalue)) > 0;
81		}
82
83	1	public function entityExists($className)
84		{
85
86	1	if (is_object($className)) {
87		$className = ($className instanceof Proxy) ? get_parent_class($className) : get_class($className);
		0 ignored issues – show Bug introduced 2018-02-12 20:06 UTC by Report Bug Copy Issue Report The type `Fi\CoreBundle\DependencyInjection\Proxy` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
88		}
89
90	1	return !$this->em->getMetadataFactory()->isTransient($className);
91		}
92
93	1	public function getEntityJoinTables($entityclass)
94		{
95	1	$jointables = array();
96	1	$metadata = $this->em->getClassMetadata($entityclass);
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
97	1	$fielsassoc = $metadata->associationMappings;
98	1	foreach ($fielsassoc as $tableassoc) {
99	1	if ($tableassoc["inversedBy"]) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `inversedBy` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
100	1	$jointables[$tableassoc["targetEntity"]] = array("entity" => $tableassoc);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `targetEntity` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The string literal `entity` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
101	1	}
102	1	}
103	1	return $jointables;
104		}
105
106	1	public function entityHasJoinTables($entityclass)
107		{
108	1	$jointables = $this->getEntityJoinTables($entityclass);
109	1	return count($jointables) > 0 ? true : false;
110		}
111		}
112

ComuneFI / FifreeCoreBundle

Push — master ( 6f8d59...e8056d )

DatabaseUtility A

Complexity

Size/Duplication

Test Coverage

Importance

9 Methods

Duplication Side-by-Side

Filter issues like