FiVersioneController::versione() - Code Metrics - Inspection of "apcu" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ffc231...63b7b4 )

by Andrea

created 2018-02-28 11:29 UTC

FiVersioneController::versione() B

↳ Parent: FiVersioneController

Complexity

Conditions	5
Paths	5

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	5.0291

Importance

Changes

Metric	Value
cc	5
eloc	18
nc	5
nop	1
dl	0
loc	30
ccs	17
cts	19
cp	0.8947
crap	5.0291
rs	8.439
c	0
b	0
f	0

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Process\Process;

class FiVersioneController extends Controller
{

    public static $versione;

    public static function versione($container)
    {

        if (self::isWindows()) {
            return '';
        }

        if (self::$versione) {
            $risposta = self::$versione;
        } else {
            $projectDir = substr($container->get('kernel')->getRootDir(), 0, -4);

            $cmd = 'cd ' . $projectDir;
$a = "a";
$ab = "ab";
$abc = "abc";
            $process = new Process($cmd . ';git describe --tags');
            $process->setTimeout(60 * 100);
            $process->run();
            if ($process->isSuccessful()) {
                $out = explode(chr(10), $process->getOutput());

                $version = isset($out[0]) ? $out[0] : "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                $risposta = $version;
            } else {
                $risposta = "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            self::$versione = $risposta;
        }


        return $risposta;
    }

    public static function isWindows()
    {
        if (PHP_OS == 'WINNT') {
            return true;
        } else {
            return false;
        }
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6		use Symfony\Component\Process\Process;
7
8		class FiVersioneController extends Controller
9		{
10
11		public static $versione;
12
13	13	public static function versione($container)
14		{
15
16	13	if (self::isWindows()) {
17		return '';
18		}
19
20	13	if (self::$versione) {
21	12	$risposta = self::$versione;
22	12	} else {
23	1	$projectDir = substr($container->get('kernel')->getRootDir(), 0, -4);
24
25	1	$cmd = 'cd ' . $projectDir;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26	1	$process = new Process($cmd . ';git describe --tags');
27	1	$process->setTimeout(60 * 100);
28	1	$process->run();
29	1	if ($process->isSuccessful()) {
30	1	$out = explode(chr(10), $process->getOutput());
31
32	1	$version = isset($out[0]) ? $out[0] : "0";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `0` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
33
34	1	$risposta = $version;
35	1	} else {
36		$risposta = "0";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `0` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
37		}
38	1	self::$versione = $risposta;
39		}
40
41
42	13	return $risposta;
43		}
44
45	13	public static function isWindows()
46		{
47	13	if (PHP_OS == 'WINNT') {
48		return true;
49		} else {
50	13	return false;
51		}
52		}
53		}
54

ComuneFI / FifreeCoreBundle

Push — master ( ffc231...63b7b4 )

FiVersioneController::versione() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like