MenuApplicazioneController::updateAction() - Code Metrics - Inspection of "add tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 63b7b4...90b76b )

by Andrea

created 2018-02-28 12:34 UTC

MenuApplicazioneController::updateAction() B

↳ Parent: MenuApplicazioneController

Complexity

Conditions	6
Paths	7

Size

Total Lines	69
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	33
CRAP Score	6.5625

Importance

Changes

Metric	Value
dl	0
loc	69
ccs	33
cts	44
cp	0.75
rs	8.56
c	0
b	0
f	0
cc	6
eloc	43
nc	7
nop	2
crap	6.5625

How to fix Long Method

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * MenuApplicazione controller.
 */
class MenuApplicazioneController extends FiCoreController
{

    /**
     * Creates a new table entity.
     */
    public function createAction(Request $request)
    {
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!self::$canCreate) {
            throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $classbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Entity\\' . $controller;
        $formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $classbundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formbundle . 'Type';

        $form = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
                ),
                'action' => $this->generateUrl($controller . '_create'),
                )
        );

        $form->submit($request->request->get($form->getName()));

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($entity);
            $em->flush();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $entity->getId())));
            }
        }

        return $this->render(
            $nomebundle . ':' . $controller . ':new.html.twig',
            array(
                    'nomecontroller' => $controller,
                    'entity' => $entity,
                    'form' => $form->createView(),
                        )
        );
    }

    /**
     * Edits an existing table entity.
     */
    public function updateAction(Request $request, $id)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!self::$canUpdate) {
            throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
        $formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
        $formType = $formbundle . 'Type';
$a = "a";
$ab = "ab";
$abc = "abc";

        $repoStorico = $this->container->get('Storicomodifiche_repository');

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($nomebundle . ':' . $controller)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find ' . $controller . ' entity.');
        }

        $deleteForm = $this->createDeleteForm($id);

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
                ),
                'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
                )
        );

        $editForm->submit($request->request->get($editForm->getName()));

        if ($editForm->isValid()) {
            $originalData = $em->getUnitOfWork()->getOriginalEntityData($entity);

            $em->persist($entity);
            $em->flush();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);

            $newData = $em->getUnitOfWork()->getOriginalEntityData($entity);
            $changes = $repoStorico->isRecordChanged($nomebundle, $controller, $originalData, $newData);

            if ($changes) {
                $repoStorico->saveHistory($controller, $changes, $id, $this->getUser());
            }

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $id)));
            }
        }

        return $this->render(
            $nomebundle . ':' . $controller . ':edit.html.twig',
            array(
                    'entity' => $entity,
                    'edit_form' => $editForm->createView(),
                    'delete_form' => $deleteForm->createView(),
                    'nomecontroller' => $controller,
                        )
        );
    }

    /**
     * Deletes a table entity.
     */
    public function deleteAction(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $this->setup($request);
        if (!self::$canDelete) {
            throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $nomebundle = $namespace . $bundle . 'Bundle';

        try {
            $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
            $qb = $em->createQueryBuilder();
$a = "a";
$ab = "ab";
$abc = "abc";
            $ids = explode(',', $request->get('id'));
            $qb->delete($nomebundle . ':' . $controller, 'u')
                    ->andWhere('u.id IN (:ids)')
                    ->setParameter('ids', $ids);

            $query = $qb->getQuery();
            $query->execute();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);
        } catch (\Exception $e) {
            $response = new Response();
            $response->setStatusCode('200');

            return new Response('404');
        }

        return new Response('OK');
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Symfony\Component\HttpFoundation\Response;
7		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
8
9		/**
10		* MenuApplicazione controller.
11		*/
12		class MenuApplicazioneController extends FiCoreController
13		{
14
15		/**
16		* Creates a new table entity.
17		*/
18	1	public function createAction(Request $request)
19		{
20	1	$this->setup($request);
21	1	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22	1	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23	1	$controller = $this->getController();
24
25	1	if (!self::$canCreate) {
26		throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...creare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
27		}
28
29	1	$nomebundle = $namespace . $bundle . 'Bundle';
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30	1	$classbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Entity\\' . $controller;
31	1	$formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32
33	1	$entity = new $classbundle();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	1	$formType = $formbundle . 'Type';
35
36	1	$form = $this->createForm(
37	1	$formType,
38	1	$entity,
39		array('attr' => array(
40	1	'id' => 'formdati' . $controller,
41	1	),
42	1	'action' => $this->generateUrl($controller . '_create'),
43		)
44	1	);
45
46	1	$form->submit($request->request->get($form->getName()));
47
48	1	if ($form->isValid()) {
49	1	$em = $this->getDoctrine()->getManager();
50	1	$em->persist($entity);
51	1	$em->flush();
52	1	$em->getConfiguration()->getResultCacheImpl()->delete($controller);
53
54	1	$continua = (int) $request->get('continua');
55	1	if ($continua === 0) {
56	1	return new Response('OK');
57		} else {
58		return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $entity->getId())));
59		}
60		}
61
62		return $this->render(
63		$nomebundle . ':' . $controller . ':new.html.twig',
64		array(
65		'nomecontroller' => $controller,
66		'entity' => $entity,
67		'form' => $form->createView(),
68		)
69		);
70		}
71
72		/**
73		* Edits an existing table entity.
74		*/
75	1	public function updateAction(Request $request, $id)
76		{
77		/* @var $em \Doctrine\ORM\EntityManager */
78	1	$this->setup($request);
79	1	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80	1	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
81	1	$controller = $this->getController();
82
83	1	if (!self::$canUpdate) {
84		throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...ornare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
85		}
86
87	1	$nomebundle = $namespace . $bundle . 'Bundle';
88	1	$formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
89	1	$formType = $formbundle . 'Type';
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
90
91	1	$repoStorico = $this->container->get('Storicomodifiche_repository');
92
93	1	$em = $this->getDoctrine()->getManager();
94
95	1	$entity = $em->getRepository($nomebundle . ':' . $controller)->find($id);
96
97	1	if (!$entity) {
98		throw $this->createNotFoundException('Unable to find ' . $controller . ' entity.');
99		}
100
101	1	$deleteForm = $this->createDeleteForm($id);
102
103	1	$editForm = $this->createForm(
104	1	$formType,
105	1	$entity,
106		array('attr' => array(
107	1	'id' => 'formdati' . $controller,
108	1	),
109	1	'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
110		)
111	1	);
112
113	1	$editForm->submit($request->request->get($editForm->getName()));
114
115	1	if ($editForm->isValid()) {
116	1	$originalData = $em->getUnitOfWork()->getOriginalEntityData($entity);
117
118	1	$em->persist($entity);
119	1	$em->flush();
120	1	$em->getConfiguration()->getResultCacheImpl()->delete($controller);
121
122	1	$newData = $em->getUnitOfWork()->getOriginalEntityData($entity);
123	1	$changes = $repoStorico->isRecordChanged($nomebundle, $controller, $originalData, $newData);
124
125	1	if ($changes) {
126		$repoStorico->saveHistory($controller, $changes, $id, $this->getUser());
127		}
128
129	1	$continua = (int) $request->get('continua');
130	1	if ($continua === 0) {
131	1	return new Response('OK');
132		} else {
133		return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $id)));
134		}
135		}
136
137		return $this->render(
138		$nomebundle . ':' . $controller . ':edit.html.twig',
139		array(
140		'entity' => $entity,
141		'edit_form' => $editForm->createView(),
142		'delete_form' => $deleteForm->createView(),
143		'nomecontroller' => $controller,
144		)
145		);
146		}
147
148		/**
149		* Deletes a table entity.
150		*/
151	1	public function deleteAction(Request $request)
152		{
153		/* @var $em \Doctrine\ORM\EntityManager */
154	1	$this->setup($request);
155	1	if (!self::$canDelete) {
156		throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...ornare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
157		}
158	1	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
159	1	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
160	1	$controller = $this->getController();
161
162	1	$nomebundle = $namespace . $bundle . 'Bundle';
163
164		try {
165	1	$em = $this->getDoctrine()->getManager();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
166	1	$qb = $em->createQueryBuilder();
		0 ignored issues – show Coding Style introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
167	1	$ids = explode(',', $request->get('id'));
168	1	$qb->delete($nomebundle . ':' . $controller, 'u')
169	1	->andWhere('u.id IN (:ids)')
170	1	->setParameter('ids', $ids);
171
172	1	$query = $qb->getQuery();
173	1	$query->execute();
174	1	$em->getConfiguration()->getResultCacheImpl()->delete($controller);
175	1	} catch (\Exception $e) {
176		$response = new Response();
177		$response->setStatusCode('200');
178
179		return new Response('404');
180		}
181
182	1	return new Response('OK');
183		}
184		}
185

ComuneFI / FifreeCoreBundle

Push — master ( 63b7b4...90b76b )

MenuApplicazioneController::updateAction() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like