FfsecondariaController::indexAction() - Code Metrics - Inspection of "aggiunto filtro combo ffsecondaria" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b68917...198ad3 )

by Andrea

created 2018-02-08 14:36 UTC

FfsecondariaController::indexAction() B

↳ Parent: FfsecondariaController

Complexity

Conditions	4
Paths	8

Size

Total Lines	93
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	65
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	67
nc	8
nop	1
dl	0
loc	93
ccs	65
cts	66
cp	0.9848
crap	4
rs	8.3103
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Ffsecondaria controller.
 */
class FfsecondariaController extends FiCoreController
{

    public function indexAction(Request $request)
    {

        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        $container = $this->container;
$a = "a";
$ab = "ab";
$abc = "abc";

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $ffprincipaleSelect = array();
        //Imposta il filtro a TUTTI come default
        $ffprincipaleSelect[] = array("valore" => "", "descrizione" => "Tutti", "default" => true);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $em = $this->getDoctrine()->getManager();

        $q = $em->createQueryBuilder();

        $ffprincipales = $q->select('f')
                ->from($nomebundle . ':Ffprincipale', 'f')
                ->orderBy('f.descrizione')
                ->getQuery()
                ->getResult();

        foreach ($ffprincipales as $ffprincipale) {
            $ffprincipaleSelect[] = array(
                "valore" => $ffprincipale->getDescrizione(),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "descrizione" => $ffprincipale->getDescrizione(),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "default" => false);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $dettaglij = array(
            'descsec' => array(
                array('nomecampo' => 'descsec',
                    'lunghezza' => '400',
                    'descrizione' => 'Descrizione tabella secondaria',
                    'tipo' => 'text',),),
            'ffprincipale_id' => array(
                array('nomecampo' => 'ffprincipale.descrizione',
                    'lunghezza' => '400',
                    'descrizione' => 'Descrizione record principale',
                    'tipo' => 'select',
                    'valoricombo' => $ffprincipaleSelect
                ),
            ),
        );
        $escludi = array('nota');
$a = "a";
$ab = "ab";
$abc = "abc";

        $campiextra = array(
            array('nomecampo' => 'lunghezzanota', 'descrizione' => 'Lunghezza Nota', 'tipo' => 'integer'),
            array('nomecampo' => 'attivoToString', 'lunghezza' => '80', 'descrizione' => 'Attivo string', 'tipo' => 'text'),
        );

        $paricevuti = array(
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'dettaglij' => $dettaglij,
            'campiextra' => $campiextra,
            'escludere' => $escludi,
            'container' => $container,);

        $testatagriglia = Griglia::testataPerGriglia($paricevuti);

        $testatagriglia['multisearch'] = 1;
        $testatagriglia['showconfig'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showadd'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showedit'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showdel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";

        $testatagriglia['showexcel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showimportexcel'] = 1;

        $testatagriglia["filterToolbar_searchOnEnter"] = true;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $testatagriglia["filterToolbar_searchOperators"] = true;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $testatagriglia['parametritesta'] = json_encode($paricevuti);
        $this->setParametriGriglia(array('request' => $request));
        $testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";

        $testata = json_encode($testatagriglia);
$a = "a";
$ab = "ab";
$abc = "abc";
        $twigparms = array(
            'nomecontroller' => $controller,
            'testata' => $testata,
            'canread' => $canRead,
        );

        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
        }
    }

    public function setParametriGriglia($prepar = array())
    {
        $this->setup($prepar['request']);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $escludi = array('nota', 'ffprincipale');
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $precondizioniAvanzate = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej['ffprincipale_id'] = array('tabella' => 'ffprincipale', 'campi' => array('descrizione'));

        $campiextra = array(array('lunghezzanota'), array('attivoToString'));

        $precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
            'nomecampo' => 'intero',
            'operatore' => '>=',
            'valorecampo' => 1,);
        $precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
            'nomecampo' => 'data',
            'operatore' => '<=',
            'valorecampo' => date('Y-m-d'),
            'operatorelogico' => 'AND',);

        $paricevuti = array('container' => $this->container,
            'nomebundle' => $nomebundle,
            'tabellej' => $tabellej,
            'nometabella' => $controller,
            'campiextra' => $campiextra,
            'escludere' => $escludi,
            'precondizioniAvanzate' => $precondizioniAvanzate,);

        if (!empty($prepar)) {
            $paricevuti = array_merge($paricevuti, $prepar);
        }

        self::$parametrigriglia = $paricevuti;
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
7
8		/**
9		* Ffsecondaria controller.
10		*/
11		class FfsecondariaController extends FiCoreController
12		{
13
14	1	public function indexAction(Request $request)
15		{
16
17	1	$this->setup($request);
18	1	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19	1	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20	1	$controller = $this->getController();
21	1	$container = $this->container;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22
23	1	$nomebundle = $namespace . $bundle . 'Bundle';
		0 ignored issues – show Coding Style introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24	1	$ffprincipaleSelect = array();
25		//Imposta il filtro a TUTTI come default
26	1	$ffprincipaleSelect[] = array("valore" => "", "descrizione" => "Tutti", "default" => true);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `valore` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `descrizione` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `Tutti` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `default` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
27
28	1	$em = $this->getDoctrine()->getManager();
29
30	1	$q = $em->createQueryBuilder();
31
32	1	$ffprincipales = $q->select('f')
33	1	->from($nomebundle . ':Ffprincipale', 'f')
34	1	->orderBy('f.descrizione')
35	1	->getQuery()
36	1	->getResult();
37
38	1	foreach ($ffprincipales as $ffprincipale) {
39	1	$ffprincipaleSelect[] = array(
40	1	"valore" => $ffprincipale->getDescrizione(),
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `valore` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
41	1	"descrizione" => $ffprincipale->getDescrizione(),
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `descrizione` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
42	1	"default" => false);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-08 14:50 UTC by Report Bug Copy Issue Report The string literal `default` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
43	1	}
44
45		$dettaglij = array(
46		'descsec' => array(
47	1	array('nomecampo' => 'descsec',
48	1	'lunghezza' => '400',
49	1	'descrizione' => 'Descrizione tabella secondaria',
50	1	'tipo' => 'text',),),
51		'ffprincipale_id' => array(
52	1	array('nomecampo' => 'ffprincipale.descrizione',
53	1	'lunghezza' => '400',
54	1	'descrizione' => 'Descrizione record principale',
55	1	'tipo' => 'select',
56		'valoricombo' => $ffprincipaleSelect
57	1	),
58	1	),
59	1	);
60	1	$escludi = array('nota');
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
61
62		$campiextra = array(
63	1	array('nomecampo' => 'lunghezzanota', 'descrizione' => 'Lunghezza Nota', 'tipo' => 'integer'),
64	1	array('nomecampo' => 'attivoToString', 'lunghezza' => '80', 'descrizione' => 'Attivo string', 'tipo' => 'text'),
65	1	);
66
67		$paricevuti = array(
68	1	'nomebundle' => $nomebundle,
69	1	'nometabella' => $controller,
70	1	'dettaglij' => $dettaglij,
71	1	'campiextra' => $campiextra,
72	1	'escludere' => $escludi,
73	1	'container' => $container,);
74
75	1	$testatagriglia = Griglia::testataPerGriglia($paricevuti);
76
77	1	$testatagriglia['multisearch'] = 1;
78	1	$testatagriglia['showconfig'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
79	1	$testatagriglia['showadd'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80	1	$testatagriglia['showedit'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
81	1	$testatagriglia['showdel'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
82
83	1	$testatagriglia['showexcel'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
84	1	$testatagriglia['showimportexcel'] = 1;
85
86	1	$testatagriglia["filterToolbar_searchOnEnter"] = true;
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `filterToolbar_searchOnEnter` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
87	1	$testatagriglia["filterToolbar_searchOperators"] = true;
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `filterToolbar_searchOperators` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
88
89	1	$testatagriglia['parametritesta'] = json_encode($paricevuti);
90	1	$this->setParametriGriglia(array('request' => $request));
91	1	$testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);
92
93	1	$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
94	1	$canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
95
96	1	$testata = json_encode($testatagriglia);
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
97		$twigparms = array(
98	1	'nomecontroller' => $controller,
99	1	'testata' => $testata,
100	1	'canread' => $canRead,
101	1	);
102
103	1	if (!$canRead) {
104		throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
105		} else {
106	1	return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
107		}
108		}
109
110	4	public function setParametriGriglia($prepar = array())
111		{
112	4	$this->setup($prepar['request']);
113	4	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
114	4	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
115	4	$controller = $this->getController();
116
117	4	$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
118	4	$canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
119	4	if (!$canRead) {
120	1	throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
121		}
122
123	3	$nomebundle = $namespace . $bundle . 'Bundle';
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 18 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
124	3	$escludi = array('nota', 'ffprincipale');
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 21 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
125	3	$tabellej = array();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 20 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
126	3	$precondizioniAvanzate = array();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
127	3	$tabellej['ffprincipale_id'] = array('tabella' => 'ffprincipale', 'campi' => array('descrizione'));
128
129	3	$campiextra = array(array('lunghezzanota'), array('attivoToString'));
130
131	3	$precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
132	3	'nomecampo' => 'intero',
133	3	'operatore' => '>=',
134	3	'valorecampo' => 1,);
135	3	$precondizioniAvanzate[] = array('nometabella' => 'Ffsecondaria',
136	3	'nomecampo' => 'data',
137	3	'operatore' => '<=',
138	3	'valorecampo' => date('Y-m-d'),
139	3	'operatorelogico' => 'AND',);
140
141	3	$paricevuti = array('container' => $this->container,
142	3	'nomebundle' => $nomebundle,
143	3	'tabellej' => $tabellej,
144	3	'nometabella' => $controller,
145	3	'campiextra' => $campiextra,
146	3	'escludere' => $escludi,
147	3	'precondizioniAvanzate' => $precondizioniAvanzate,);
148
149	3	if (!empty($prepar)) {
150	3	$paricevuti = array_merge($paricevuti, $prepar);
151	3	}
152
153	3	self::$parametrigriglia = $paricevuti;
154	3	}
155		}
156

ComuneFI / FifreeCoreBundle

Push — master ( b68917...198ad3 )

FfsecondariaController::indexAction() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like