OperatoriController::new() - Code Metrics - Inspection of "refactor" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.1 ( 98684d...1ca7b1 )

by Andrea

created 2018-11-14 22:11 UTC

OperatoriController::new() A

↳ Parent: OperatoriController

Complexity

Conditions	4
Paths	4

Size

Total Lines	63
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
eloc	44
dl	0
loc	63
ccs	0
cts	41
cp	0
rs	9.216
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	20

How to fix Long Method

<?php

namespace Fi\CoreBundle\Controller;

use Fi\CoreBundle\Controller\FiController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Fi\CoreBundle\Utils\Tabella\ParametriTabella;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\KernelInterface;
use Psr\Log\LoggerInterface;
use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

/**
 * Operatori controller.
 */
class OperatoriController extends FiController
{

    private $logger;
    private $usermanipulator;

    public function __construct(ObjectManager $em, TokenStorageInterface $user, LoggerInterface $logger, $usermanipulator)
    {
        $this->logger = $logger;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->usermanipulator = $usermanipulator;
        parent::__construct($em, $user);
    }

        /**
         * Displays a form to create a new table entity.
         */
    public function new(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canCreate()) {
            throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellatemplate = $this->getTabellaTemplate($controller);

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $entityclass();
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formclass . 'Type';
        $form = $this->createForm($formType, $entity, array('attr' => array(
$a = "a";
$ab = "ab";
$abc = "abc";
            'id' => 'formdati' . $controller,
        ),
        'action' => $this->generateUrl($controller . '_new'),
        ));

        $form->handleRequest($request);

        $twigparms = array(
        'form' => $form->createView(),
        'nomecontroller' => ParametriTabella::setParameter($controller),
        'tabellatemplate' => $tabellatemplate
        );
        if ($form->isSubmitted()) {
            if ($form->isValid()) {
                $logger = $this->logger;
$a = "a";
$ab = "ab";
$abc = "abc";
                $entity = $form->getData();
$a = "a";
$ab = "ab";
$abc = "abc";
                $username = $entity->getUsername();
                $password = $entity->getPassword();
                $entity->setOperatore($username);
                $entity->setEnabled(true);
                $logger->info('Inserimento nuovo utente ' . $username);

                $entityManager = $this->getDoctrine()->getManager();
                $entityManager->persist($entity);
                $entityManager->flush();

                $content = $this->usermanipulator->changePassword($username, $password);

                $logger->info('Esito inserimento nuovo utente ' . $username . " : " . $content);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                return new Response(
                    $this->renderView($crudtemplate, $twigparms),
                    200
                );
            } else {
//Quando non passa la validazione
                return new Response(
                    $this->renderView($crudtemplate, $twigparms),
                    400
                );
            }
        } else {
//Quando viene richiesta una "nuova" new
            return new Response(
                $this->renderView($crudtemplate, $twigparms),
                200
            );
        }
    }
}


1			<?php
2
3			namespace Fi\CoreBundle\Controller;
4
5			use Fi\CoreBundle\Controller\FiController;
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
8			use Fi\CoreBundle\Utils\Tabella\ParametriTabella;
9			use Symfony\Bundle\FrameworkBundle\Console\Application;
10			use Symfony\Component\Console\Input\ArrayInput;
11			use Symfony\Component\Console\Output\BufferedOutput;
12			use Symfony\Component\HttpFoundation\Response;
13			use Symfony\Component\HttpKernel\KernelInterface;
14			use Psr\Log\LoggerInterface;
15			use Doctrine\Common\Persistence\ObjectManager;
16			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
17
18			/**
19			* Operatori controller.
20			*/
21			class OperatoriController extends FiController
22			{
23
24			private $logger;
25			private $usermanipulator;
26
27			public function __construct(ObjectManager $em, TokenStorageInterface $user, LoggerInterface $logger, $usermanipulator)
28			{
29			$this->logger = $logger;
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30			$this->usermanipulator = $usermanipulator;
31			parent::__construct($em, $user);
32			}
33
34			/**
35			* Displays a form to create a new table entity.
36			*/
37			public function new(Request $request)
38			{
39			/* @var $em \Doctrine\ORM\EntityManager */
40			$bundle = $this->getBundle();
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41			$controller = $this->getController();
42			if (!$this->getPermessi()->canCreate()) {
43			throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-27 14:31 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...creare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
44			}
45			$crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());
			0 ignored issues – show Coding Style introduced 2018-11-14 22:24 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
46			$tabellatemplate = $this->getTabellaTemplate($controller);
47
48			$entityclass = $this->getEntityClassName();
49			$formclass = str_replace("Entity", "Form", $entityclass);
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report The string literal `Entity` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report The string literal `Form` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
50
51			$entity = new $entityclass();
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
52			$formType = $formclass . 'Type';
53			$form = $this->createForm($formType, $entity, array('attr' => array(
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
54			'id' => 'formdati' . $controller,
55			),
56			'action' => $this->generateUrl($controller . '_new'),
57			));
58
59			$form->handleRequest($request);
60
61			$twigparms = array(
62			'form' => $form->createView(),
63			'nomecontroller' => ParametriTabella::setParameter($controller),
64			'tabellatemplate' => $tabellatemplate
65			);
66			if ($form->isSubmitted()) {
67			if ($form->isValid()) {
68			$logger = $this->logger;
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69			$entity = $form->getData();
			0 ignored issues – show Coding Style introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
70			$username = $entity->getUsername();
71			$password = $entity->getPassword();
72			$entity->setOperatore($username);
73			$entity->setEnabled(true);
74			$logger->info('Inserimento nuovo utente ' . $username);
75
76			$entityManager = $this->getDoctrine()->getManager();
77			$entityManager->persist($entity);
78			$entityManager->flush();
79
80			$content = $this->usermanipulator->changePassword($username, $password);
81
82			$logger->info('Esito inserimento nuovo utente ' . $username . " : " . $content);
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-14 13:23 UTC by Report Bug Copy Issue Report The string literal `:` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
83
84			return new Response(
85			$this->renderView($crudtemplate, $twigparms),
86			200
87			);
88			} else {
89			//Quando non passa la validazione
90			return new Response(
91			$this->renderView($crudtemplate, $twigparms),
92			400
93			);
94			}
95			} else {
96			//Quando viene richiesta una "nuova" new
97			return new Response(
98			$this->renderView($crudtemplate, $twigparms),
99			200
100			);
101			}
102			}
103			}
104

ComuneFI / FifreeCoreBundle

Push — 4.1 ( 98684d...1ca7b1 )

OperatoriController::new() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like