PermessiUtils::canDelete() - Code Metrics - Inspection of "add controller tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 4.1 ( cc1509...e0bb47 )

by Andrea

created 2018-11-09 23:58 UTC

PermessiUtils::canDelete() A

↳ Parent: PermessiUtils

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

namespace Fi\CoreBundle\Utils;

use Fi\CoreBundle\Entity\Permessi;

class PermessiUtils implements \JsonSerializable
{

    private $read = false;
$a = "a";
$ab = "ab";
$abc = "abc";
    private $create = false;
    private $delete = false;
    private $edit = false;
$a = "a";
$ab = "ab";
$abc = "abc";

    public function __construct($em, $modulo, $operatore)
    {
        $permessi = $em->getRepository(Permessi::class)->findPermessoModuloOperatore($modulo, $operatore);

        if ($permessi) {
            if (stripos(strtoupper($permessi->getCrud()), 'C') !== false) {
                $this->create = true;
            }
            if (stripos(strtoupper($permessi->getCrud()), 'R') !== false) {
                $this->read = true;
            }
            if (stripos(strtoupper($permessi->getCrud()), 'U') !== false) {
                $this->edit = true;
            }
            if (stripos(strtoupper($permessi->getCrud()), 'D') !== false) {
                $this->delete = true;
            }
        } else {
            /* Per il superadmin si restituisce sempre tutti i permessi a true */
            if ($operatore->isSuperadmin()) {
                $this->create = true;
                $this->read = true;
$a = "a";
$ab = "ab";
$abc = "abc";
                $this->edit = true;
$a = "a";
$ab = "ab";
$abc = "abc";
                $this->delete = true;
            }
        }
    }
    public function canRead()
    {
        return $this->read;
    }
    public function canCreate()
    {
        return $this->create;
    }
    public function canUpdate()
    {
        return $this->edit;
    }
    public function canDelete()
    {
        return $this->delete;
    }
    public function jsonSerialize()
    {
        return array("read" => $this->canRead(), "create" => $this->canCreate(), "delete" => $this->canDelete(), "update" => $this->canUpdate());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    public function __toString()
    {
        return json_encode($this);
    }
}


1		<?php
2
3		/*
4		* To change this license header, choose License Headers in Project Properties.
5		* To change this template file, choose Tools \| Templates
6		* and open the template in the editor.
7		*/
8
9		namespace Fi\CoreBundle\Utils;
10
11		use Fi\CoreBundle\Entity\Permessi;
12
13		class PermessiUtils implements \JsonSerializable
14		{
15
16		private $read = false;
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
17		private $create = false;
18		private $delete = false;
19		private $edit = false;
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20
21	1	public function __construct($em, $modulo, $operatore)
22		{
23	1	$permessi = $em->getRepository(Permessi::class)->findPermessoModuloOperatore($modulo, $operatore);
24
25	1	if ($permessi) {
26		if (stripos(strtoupper($permessi->getCrud()), 'C') !== false) {
27		$this->create = true;
28		}
29		if (stripos(strtoupper($permessi->getCrud()), 'R') !== false) {
30		$this->read = true;
31		}
32		if (stripos(strtoupper($permessi->getCrud()), 'U') !== false) {
33		$this->edit = true;
34		}
35		if (stripos(strtoupper($permessi->getCrud()), 'D') !== false) {
36		$this->delete = true;
37		}
38		} else {
39		/* Per il superadmin si restituisce sempre tutti i permessi a true */
40	1	if ($operatore->isSuperadmin()) {
41	1	$this->create = true;
42	1	$this->read = true;
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43	1	$this->edit = true;
		0 ignored issues – show Coding Style introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
44	1	$this->delete = true;
45		}
46		}
47	1	}
48	1	public function canRead()
49		{
50	1	return $this->read;
51		}
52	1	public function canCreate()
53		{
54	1	return $this->create;
55		}
56	1	public function canUpdate()
57		{
58	1	return $this->edit;
59		}
60	1	public function canDelete()
61		{
62	1	return $this->delete;
63		}
64	1	public function jsonSerialize()
65		{
66	1	return array("read" => $this->canRead(), "create" => $this->canCreate(), "delete" => $this->canDelete(), "update" => $this->canUpdate());
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `read` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `create` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `delete` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-06 16:43 UTC by Report Bug Copy Issue Report The string literal `update` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67		}
68		public function __toString()
69		{
70		return json_encode($this);
71		}
72		}
73

ComuneFI / FifreeCoreBundle

Push — 4.1 ( cc1509...e0bb47 )

PermessiUtils::canDelete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like