OpzioniTabellaController::indexAction() - Code Metrics - Inspection of "add tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ffa83f...6ce442 )

by Andrea

created 2018-10-03 19:31 UTC

OpzioniTabellaController::indexAction() B

↳ Parent: OpzioniTabellaController

Complexity

Conditions	1
Paths	1

Size

Total Lines	70
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	30
CRAP Score	1

Importance

Changes

Metric	Value
eloc	55
dl	0
loc	70
ccs	30
cts	30
cp	1
rs	8.9818
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

How to fix Long Method

<?php

/* Qui Bundle */
//namespace Fi\DemoBundle\Controller;

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * OpzioniTabella controller.
 */
class OpzioniTabellaController extends FiCoreController
{

    /**
     * Lists all opzioniTabella entities.
     */
    public function indexAction(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        $container = $this->container;
$a = "a";
$ab = "ab";
$abc = "abc";

        $nomebundle = $namespace . $bundle . 'Bundle';

        $dettaglij = array(
            'descrizione' => array(
                array(
                    'nomecampo' => 'descrizione',
                    'lunghezza' => '400',
                    'descrizione' => 'Descrizione',
                    'tipo' => 'text',),),
            'parametro' => array(
                array(
                    'nomecampo' => 'parametro',
                    'lunghezza' => '300',
                    'descrizione' => 'Parametro',
                    'tipo' => 'text',),),
            'valore' => array(
                array(
                    'nomecampo' => 'valore',
                    'lunghezza' => '300',
                    'descrizione' => 'Valore',
                    'tipo' => 'text',),),
            'tabelle_id' => array(
                array(
                    'nomecampo' => 'tabelle.nometabella',
                    'lunghezza' => '400',
                    'descrizione' => 'Tabella',
                    'tipo' => 'text',),
            ),
        );

        $escludi = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $paricevuti = array(
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'dettaglij' => $dettaglij,
            'escludere' => $escludi,
            'container' => $container,
        );

        $griglia = $this->get("ficorebundle.griglia");
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia = $griglia->testataPerGriglia($paricevuti);

        $testatagriglia['multisearch'] = 1;
        $testatagriglia['showconfig'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showadd'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showedit'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showdel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['editinline'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['overlayopen'] = 1;

        $testatagriglia['parametritesta'] = json_encode($paricevuti);
        $this->setParametriGriglia(array('request' => $request));
        $testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);

        $testata = json_encode($testatagriglia);
$a = "a";
$ab = "ab";
$abc = "abc";
        $twigparms = array(
            'nomecontroller' => $controller,
            'testata' => $testata,
        );

        return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
    }

    public function setParametriGriglia($prepar = array())
    {
        $this->setup($prepar['request']);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $escludi = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej['tabelle_id'] = array('tabella' => 'tabelle', 'campi' => array('nometabella'));

        $paricevuti = array(
            'container' => $this->container,
            'nomebundle' => $nomebundle,
            'tabellej' => $tabellej,
            'nometabella' => $controller,
            'escludere' => $escludi,);

        if (!empty($prepar)) {
            $paricevuti = array_merge($paricevuti, $prepar);
        }

        self::$parametrigriglia = $paricevuti;
    }

    /**
     * Creates a new table entity.
     */
    public function createAction(Request $request)
    {
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!self::$canCreate) {
            throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $classbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Entity\\' . $controller;
        $formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $classbundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formbundle . 'Type';

        $form = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
                ),
                'action' => $this->generateUrl($controller . '_create'),
                )
        );

        $form->submit($request->request->get($form->getName()));

        if ($form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($entity);
            $em->flush();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $entity->getId())));
            }
        }

        return $this->render(
            $nomebundle . ':' . $controller . ':new.html.twig',
            array(
                    'nomecontroller' => $controller,
                    'entity' => $entity,
                    'form' => $form->createView(),
                        )
        );
    }

    /**
     * Edits an existing table entity.
     */
    public function updateAction(Request $request, $id)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!self::$canUpdate) {
            throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
        $formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
        $formType = $formbundle . 'Type';
$a = "a";
$ab = "ab";
$abc = "abc";

        $repoStorico = $this->container->get('Storicomodifiche_repository');

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($nomebundle . ':' . $controller)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Unable to find ' . $controller . ' entity.');
        }

        $deleteForm = $this->createDeleteForm($id);

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
                ),
                'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
                )
        );

        $editForm->submit($request->request->get($editForm->getName()));

        if ($editForm->isValid()) {
            $originalData = $em->getUnitOfWork()->getOriginalEntityData($entity);

            $em->persist($entity);
            $em->flush();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);

            $newData = $em->getUnitOfWork()->getOriginalEntityData($entity);
            $changes = $repoStorico->isRecordChanged($nomebundle, $controller, $originalData, $newData);

            if ($changes) {
                $repoStorico->saveHistory($controller, $changes, $id, $this->getUser());
            }

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $id)));
            }
        }

        return $this->render(
            $nomebundle . ':' . $controller . ':edit.html.twig',
            array(
                    'entity' => $entity,
                    'edit_form' => $editForm->createView(),
                    'delete_form' => $deleteForm->createView(),
                    'nomecontroller' => $controller,
                        )
        );
    }

    /**
     * Deletes a table entity.
     */
    public function deleteAction(Request $request)
    {
        /* @var $em \Doctrine\ORM\EntityManager */
        $this->setup($request);
        if (!self::$canDelete) {
            throw new AccessDeniedException("Non si hanno i permessi per aggiornare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $nomebundle = $namespace . $bundle . 'Bundle';

        try {
            $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
            $qb = $em->createQueryBuilder();
$a = "a";
$ab = "ab";
$abc = "abc";
            $ids = explode(',', $request->get('id'));
            $qb->delete($nomebundle . ':' . $controller, 'u')
                    ->andWhere('u.id IN (:ids)')
                    ->setParameter('ids', $ids);

            $query = $qb->getQuery();
            $query->execute();
            $em->getConfiguration()->getResultCacheImpl()->delete($controller);
        } catch (\Exception $e) {
            $response = new Response();
            $response->setStatusCode('200');

            return new Response('404');
        }

        return new Response('OK');
    }
}


1		<?php
2
3		/* Qui Bundle */
4		//namespace Fi\DemoBundle\Controller;
5
6		namespace Fi\CoreBundle\Controller;
7
8		use Symfony\Component\HttpFoundation\Request;
9		use Symfony\Component\HttpFoundation\Response;
10		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
11
12		/**
13		* OpzioniTabella controller.
14		*/
15		class OpzioniTabellaController extends FiCoreController
16		{
17
18		/**
19		* Lists all opzioniTabella entities.
20		*/
21	1	public function indexAction(Request $request)
22		{
23		/* @var $em \Doctrine\ORM\EntityManager */
24	1	$this->setup($request);
25	1	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26	1	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
27	1	$controller = $this->getController();
28	1	$container = $this->container;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29
30	1	$nomebundle = $namespace . $bundle . 'Bundle';
31
32		$dettaglij = array(
33	1	'descrizione' => array(
34		array(
35		'nomecampo' => 'descrizione',
36		'lunghezza' => '400',
37		'descrizione' => 'Descrizione',

ComuneFI / FifreeCoreBundle

Push — master ( ffa83f...6ce442 )

OpzioniTabellaController::indexAction() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like