Fifree2configuratorimportCommand - Code Metrics - Inspection of "removed mysql commands" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a5a9cd...0a59dc )

by Andrea

created 2018-02-13 12:47 UTC

Fifree2configuratorimportCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	202
Duplicated Lines	0 %

Test Coverage

Coverage

85.81%

Importance

Changes

Metric	Value
wmc	30
dl	0
loc	202
ccs	133
cts	155
cp	0.8581
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	import()	15	3
B	executeImport()	22	6
A	execute()	10	1
A	configure()	8	1
C	executeInsert()	49	8
C	executeUpdate()	75	11

<?php

namespace Fi\CoreBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Yaml\Yaml;
use Symfony\Component\Filesystem\Filesystem;

class Fifree2configuratorimportCommand extends ContainerAwareCommand
{

    private $forceupdate = false;
    private $verboso = false;
$a = "a";
$ab = "ab";
$abc = "abc";
    private $dbutility;
    /* @var $em \Doctrine\ORM\EntityManager */
    private $em;

    protected function configure()
    {
        $this
                ->setName('fifree2:configuratorimport')
                ->setDescription('Configuratore per Fifree')
                ->setHelp('Importa la configurazione di fifree da file fixtures.yml')
                ->addOption('forceupdate', null, InputOption::VALUE_NONE, 'Forza update di record con id già presente')
                ->addOption('verboso', null, InputOption::VALUE_NONE, 'Visualizza tutti i messaggi di importazione');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->output = $output;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->forceupdate = $input->getOption('forceupdate');
        $this->verboso = $input->getOption('verboso');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->dbutility = $this->getContainer()->get("ficorebundle.database.utility");
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->em = $this->getContainer()->get("doctrine")->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";

        $fixturefile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . "fixtures.yml";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        return $this->import($fixturefile);
    }

    protected function import($fixturefile)
    {
        $fs = new Filesystem;
        if ($fs->exists($fixturefile)) {
            $fixtures = Yaml::parse(file_get_contents($fixturefile));
            $msg = "<info>Trovate " . count($fixtures) . " entities nel file " . $fixturefile . "</info>";
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->output->writeln($msg);
            foreach ($fixtures as $entityclass => $fixture) {
                $this->executeImport($entityclass, $fixture);
            }
            return 0;
        } else {
            $msgerr = "<error>Non trovato file " . $fixturefile . "</error>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->output->writeln($msgerr);
            return 1;
        }
    }

    private function executeImport($entityclass, $fixture)
    {
        $msg = "<info>Trovati " . count($fixture) . " record per l'entity " . $entityclass . "</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->output->writeln($msg);
        foreach ($fixture as $record) {
            $objrecord = $this->em->getRepository($entityclass)->find($record["id"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if ($objrecord) {
                if ($this->forceupdate) {
                    $retcode = $this->executeUpdate($entityclass, $record, $objrecord);
                    if ($retcode !== 0) {
                        return 1;
                    }
                } else {
                    $msgerr = "<error>" . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            . " non modificata, specificare l'opzione --forceupdate "
                            . "per sovrascrivere record presenti</error>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->output->writeln($msgerr);
                }
            } else {
                $retcode = $this->executeInsert($entityclass, $record);
                if ($retcode !== 0) {
                    return 1;
                }
            }
        }
    }

    private function executeInsert($entityclass, $record)
    {
        $objrecord = new $entityclass();

        foreach ($record as $key => $value) {
            if ($key !== 'id' && $value) {
                $joincolumn = $this->dbutility->getJoinTableField($entityclass, $key);
$a = "a";
$ab = "ab";
$abc = "abc";
                $joincolumnproperty = $this->dbutility->getJoinTableFieldProperty($entityclass, $key);
                
                if ($joincolumn && $joincolumnproperty) {
                    $joincolumnobj = $this->em->getRepository($joincolumn)->find($value);
                    $msgok = "<info>Inserimento " . $entityclass . " con id " . $record["id"]
$a = "a";
$ab = "ab";
$abc = "abc";
                            . " per campo " . $key
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            . " con valore " . print_r($value, true) . " tramite entity find</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $this->output->writeln($msgok);
                    $joinobj = $this->dbutility->getEntityProperties($joincolumnproperty, new $entityclass());
$a = "a";
$ab = "ab";
$abc = "abc";
                    $setfieldname = $joinobj["set"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $objrecord->$setfieldname($joincolumnobj);
                    continue;
                }

                $propertyEntity = $this->dbutility->getEntityProperties($key, $objrecord);
                $setfieldname = $propertyEntity["set"];
$a = "a";
$ab = "ab";
$abc = "abc";
                $objrecord->$setfieldname($value);
            }
        }
        $this->em->persist($objrecord);
        $this->em->flush();
        $this->em->clear();
        $infomsg = "<info>" . $entityclass . " con id " . $objrecord->getId() . " aggiunta</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->output->writeln($infomsg);
        if ($record["id"] !== $objrecord->getId()) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            try {
                $qb = $this->em->createQueryBuilder();
                $q = $qb->update($entityclass, 'u')
$a = "a";
$ab = "ab";
$abc = "abc";
                        ->set('u.id', ":newid")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        ->where('u.id = :oldid')
                        ->setParameter("newid", $record["id"])
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        ->setParameter("oldid", $objrecord->getId())
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        ->getQuery();
                $q->execute();
                $msgok = "<info>" . $entityclass . " con id " . $objrecord->getId() . " sistemata</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $this->output->writeln($msgok);
            } catch (\Exception $exc) {
                echo $exc->getMessage();
                return 1;
            }
        }
        return 0;
    }

    private function executeUpdate($entityclass, $record, $objrecord)
    {
        foreach ($record as $key => $value) {
            if ($key !== 'id') {
                $propertyEntity = $this->dbutility->getEntityProperties($key, $objrecord);
                $getfieldname = $propertyEntity["get"];
$a = "a";
$ab = "ab";
$abc = "abc";
                $setfieldname = $propertyEntity["set"];
$a = "a";
$ab = "ab";
$abc = "abc";
                $cambiato = $this->dbutility->isRecordChanged($entityclass, $key, $objrecord->$getfieldname(), $value);
$a = "a";
$ab = "ab";
$abc = "abc";
                if (!$cambiato) {
                    if ($this->verboso) {
                        $msginfo = "<info>" . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . " per campo " . $key . " non modificato perchè già "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . $value . "</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        $this->output->writeln($msginfo);
                    }
                } else {
                    try {
                        $fieldtype = $this->dbutility->getFieldType($objrecord, $key);
                        if ($fieldtype === 'datetime') {
                            $date = new \DateTime();
                            $date->setTimestamp($value);
                            $msgok = "<info>" . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . " per campo " . $key . " cambio valore da "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    //. (!is_null($objrecord->$getfieldname())) ? $objrecord->$getfieldname()->format("Y-m-d H:i:s") : "(null)"

                                    . ($objrecord->$getfieldname() ? $objrecord->$getfieldname()->format("Y-m-d H:i:s") : "")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . " a " . $date->format("Y-m-d H:i:s") . " in formato DateTime</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $this->output->writeln($msgok);
                            $objrecord->$setfieldname($date);
                            continue;
                        }
                        if (is_array($value)) {
                            $msgarray = "<info>" . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . " per campo " . $key . " cambio valore da "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . json_encode($objrecord->$getfieldname()) . " a "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . json_encode($value) . " in formato array" . "</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $this->output->writeln($msgarray);
                            $objrecord->$setfieldname($value);
                            continue;
                        }

                        $joincolumn = $this->dbutility->getJoinTableField($entityclass, $key);
$a = "a";
$ab = "ab";
$abc = "abc";
                        $joincolumnproperty = $this->dbutility->getJoinTableFieldProperty($entityclass, $key);
                        if ($joincolumn && $joincolumnproperty) {
                            $joincolumnobj = $this->em->getRepository($joincolumn)->find($value);
                            $msgok = "<info>Modifica " . $entityclass . " con id " . $record["id"]
$a = "a";
$ab = "ab";
$abc = "abc";
                                    . " per campo " . $key . " cambio valore da " . print_r($objrecord->$getfieldname(), true)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    . " a " . print_r($value, true) . " tramite entity find</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $this->output->writeln($msgok);
                            $joinobj = $this->dbutility->getEntityProperties($joincolumnproperty, new $entityclass());
$a = "a";
$ab = "ab";
$abc = "abc";
                            $setfieldname = $joinobj["set"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $objrecord->$setfieldname($joincolumnobj);
                            continue;
                        }

                        $msgok = "<info>Modifica " . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . " per campo " . $key . " cambio valore da " . print_r($objrecord->$getfieldname(), true)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . " a " . print_r($value, true) . "</info>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        $this->output->writeln($msgok);
                        $objrecord->$setfieldname($value);
                    } catch (\Exception $exc) {
                        $msgerr = "<error>" . $entityclass . " con id " . $record["id"]
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . " per campo " . $key . ", ERRORE: " . $exc->getMessage()
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                . " alla riga " . $exc->getLine() . "</error>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        $this->output->writeln($msgerr);
                        //dump($exc);
                        return 1;
                    }
                }
            }
        }
        $this->em->persist($objrecord);
        $this->em->flush();
        $this->em->clear();

        return 0;
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Command;
4
5		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6		use Symfony\Component\Console\Input\InputInterface;
7		use Symfony\Component\Console\Output\OutputInterface;
8		use Symfony\Component\Console\Input\InputOption;
9		use Symfony\Component\Yaml\Yaml;
10		use Symfony\Component\Filesystem\Filesystem;
11
12		class Fifree2configuratorimportCommand extends ContainerAwareCommand
13		{
14
15		private $forceupdate = false;
16		private $verboso = false;
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
17		private $dbutility;
18		/* @var $em \Doctrine\ORM\EntityManager */
19		private $em;
20
21	4	protected function configure()
22		{
23	4	$this
24	4	->setName('fifree2:configuratorimport')
25	4	->setDescription('Configuratore per Fifree')
26	4	->setHelp('Importa la configurazione di fifree da file fixtures.yml')
27	4	->addOption('forceupdate', null, InputOption::VALUE_NONE, 'Forza update di record con id già presente')
28	4	->addOption('verboso', null, InputOption::VALUE_NONE, 'Visualizza tutti i messaggi di importazione');
29	4	}
30
31	1	protected function execute(InputInterface $input, OutputInterface $output)
32		{
33	1	$this->output = $output;
		0 ignored issues – show Bug Best Practice introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report The property `output` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history... Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	1	$this->forceupdate = $input->getOption('forceupdate');
35	1	$this->verboso = $input->getOption('verboso');
		0 ignored issues – show Coding Style introduced 2018-02-11 18:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36	1	$this->dbutility = $this->getContainer()->get("ficorebundle.database.utility");
		0 ignored issues – show Coding Style introduced 2018-02-12 20:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-12 18:34 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.database.utility` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...

ComuneFI / FifreeCoreBundle

Push — master ( a5a9cd...0a59dc )

Fifree2configuratorimportCommand A

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like