TabelleController - Code Metrics - Inspection of "add tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e5181e...c911bb )

by Andrea

created 2018-10-08 15:46 UTC

TabelleController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	246
Duplicated Lines	0 %

Test Coverage

Coverage

95.92%

Importance

Changes

Metric	Value
wmc	17
eloc	166
dl	0
loc	246
ccs	141
cts	147
cp	0.9592
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	setParametriGriglia()	31	4
B	configuraAction()	103	1
A	getRequestValue()	6	3
A	listacampitabellaAction()	16	3
A	aggiornaAction()	48	5
A	grigliapopupAction()	28	1

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Tabelle controller.
 */
class TabelleController extends FiCoreController
{

    public function aggiornaAction(Request $request)
    {
        if ($request->get('oper') == 'edit') {
            $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $operatore = $gestionepermessi->utentecorrente();
$a = "a";
$ab = "ab";
$abc = "abc";

            $id = $request->get('id');

            $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
            $tabelle = $em->getRepository('FiCoreBundle:Tabelle')->find($id);
            if (!$tabelle) {
                throw new AccessDeniedException("Oggetto non trovato");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            $tabelle->setOperatoriId($operatore['id']);
            $nometabella = $this->getRequestValue($request, 'nometabella');
            if ($nometabella) {
                $tabelle->setNometabella($nometabella);
            }
            $nomecampo = $this->getRequestValue($request, 'nomecampo');
            if ($nomecampo) {
                $tabelle->setNomecampo($nomecampo);
            }
            $mostraindex = $this->getRequestValue($request, 'mostraindex');
            $tabelle->setMostraindex($mostraindex);
            $ordineindex = $this->getRequestValue($request, 'ordineindex');
            $tabelle->setOrdineindex($ordineindex);
            $etichettaindex = $this->getRequestValue($request, 'etichettaindex');
            $tabelle->setEtichettaindex($etichettaindex);

            $larghezzaindex = $this->getRequestValue($request, 'larghezzaindex');
            $tabelle->setLarghezzaindex($larghezzaindex);

            $mostrastampa = $this->getRequestValue($request, 'mostrastampa');
            $tabelle->setMostrastampa($mostrastampa);

            $ordinestampa = $this->getRequestValue($request, 'ordinestampa');
            $tabelle->setOrdinestampa($ordinestampa);

            $etichettastampa = $this->getRequestValue($request, 'etichettastampa');
            $tabelle->setEtichettastampa($etichettastampa);

            $larghezzastampa = $this->getRequestValue($request, 'larghezzastampa');
            $tabelle->setLarghezzastampa($larghezzastampa);
            $em->persist($tabelle);
            $em->flush();
        }

        return new Response('OK');
    }

    private function getRequestValue($request, $attribute)
    {
        if (($request->get($attribute) !== null) && ($request->get($attribute) !== '')) {
            return $request->get($attribute);
        } else {
            return null;
        }
    }

    public function configuraAction(Request $request, $nometabella)
    {
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $operatore = $gestionepermessi->utentecorrente();
$a = "a";
$ab = "ab";
$abc = "abc";

        $utilitytabelle = $this->get("ficorebundle.tabelle.utility");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $parametritabella = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            'tabella' => $nometabella,
            "namespace" => $namespace,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "bundle" => $bundle
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
        $parametritabellaoperatore = array(
            'tabella' => $nometabella,
            "namespace" => $namespace,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "bundle" => $bundle,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'operatore' => $operatore['id']
        );

        $utilitytabelle->generaDB($parametritabella);
        $utilitytabelle->generaDB($parametritabellaoperatore);

        $controller = $this->getController();
        $container = $this->container;
$a = "a";
$ab = "ab";
$abc = "abc";

        $nomebundle = $namespace . $bundle . 'Bundle';

        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entities = $em->getRepository($nomebundle . ':' . $controller)->findAll();

        $dettaglij = array(
            'nomecampo' => array(
                array('nomecampo' => 'nomecampo', 'lunghezza' => '150', 'descrizione' => 'Campo', 'tipo' => 'text', 'editable' => false),),
            'mostraindex' => array(
                array('nomecampo' => 'mostraindex', 'lunghezza' => '100', 'descrizione' => 'Vedi in griglia', 'tipo' => 'boolean'),
            ),
            'ordineindex' => array(
                array('nomecampo' => 'ordineindex', 'lunghezza' => '100', 'descrizione' => 'Ordine in griglia', 'tipo' => 'text'),
            ),
            'etichettaindex' => array(
                array('nomecampo' => 'etichettaindex', 'lunghezza' => '150', 'descrizione' => 'Label in griglia', 'tipo' => 'text'),
            ),
            'larghezzaindex' => array(
                array('nomecampo' => 'larghezzaindex', 'lunghezza' => '100', 'descrizione' => 'Largh. in griglia', 'tipo' => 'text'),
            ),
            'mostrastampa' => array(
                array('nomecampo' => 'mostrastampa', 'lunghezza' => '100', 'descrizione' => 'Vedi in stampa', 'tipo' => 'boolean'),
            ),
            'ordinestampa' => array(
                array('nomecampo' => 'ordinestampa', 'lunghezza' => '100', 'descrizione' => 'Ordine in stampa', 'tipo' => 'text'),
            ),
            'etichettastampa' => array(
                array('nomecampo' => 'etichettastampa', 'lunghezza' => '150', 'descrizione' => 'Label in stampa', 'tipo' => 'text'),
            ),
            'larghezzastampa' => array(
                array('nomecampo' => 'larghezzastampa', 'lunghezza' => '100', 'descrizione' => 'Largh. in stampa', 'tipo' => 'text'),
            ),
        );

        $paricevuti = array(
            'doctrine' => $em,
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'dettaglij' => $dettaglij,
            'container' => $container,
        );

        $paricevuti['escludere'] = array('nometabella', 'operatori_id');

        $griglia = $this->get("ficorebundle.griglia");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $testata = $griglia->testataPerGriglia($paricevuti);

        $testata['titolo'] = sprintf("Configurazione colonne per tabella %s", $nometabella);
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['multisearch'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['showdel'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['showadd'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['showedit'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['showprint'] = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['editinline'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['nomelist'] = '#listconfigura';
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['nomepager'] = '#pagerconfigura';
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['tastochiudi'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['div'] = '#dettaglioconf';
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['chiamante'] = $nometabella;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['percorsogriglia'] = $nometabella . '/grigliapopup';
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['altezzagriglia'] = '300';
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['larghezzagriglia'] = '900';

        $testata['permessiedit'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata['permessidelete'] = 1;
        $testata['permessicreate'] = 1;
        $testata['permessiread'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $twigparm = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            'entities' => $entities,
            'nomecontroller' => $controller,
            'testata' => json_encode($testata),
            'chiamante' => $nometabella,
        );

        return $this->render($nomebundle . ':' . $controller . ':configura.html.twig', $twigparm);
    }

    public function grigliapopupAction(Request $request, $chiamante)
    {
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $nomebundle = $namespace . $bundle . 'Bundle';
        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
$a = "a";
$ab = "ab";
$abc = "abc";
        $operatore = $gestionepermessi->utentecorrente();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej['operatori_id'] = array('tabella' => 'operatori', 'campi' => array('username', 'operatore'));

        $paricevuti = array(
            'request' => $request,
            'doctrine' => $em,
            'container' => $this->container,
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'tabellej' => $tabellej,);

        $paricevuti['escludere'] = array('nometabella', 'operatori_id');
$a = "a";
$ab = "ab";
$abc = "abc";
        $paricevuti['precondizioni'] = array('Tabelle.nometabella' => $chiamante, 'Tabelle.operatori_id' => $operatore['id']);

        $griglia = $this->get("ficorebundle.griglia");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        return new Response($griglia->datiPerGriglia($paricevuti));
    }

    protected function setParametriGriglia($prepar = array())
    {
        $this->setup($prepar['request']);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $nomebundle = $namespace . $bundle . 'Bundle';
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellej['operatori_id'] = array('tabella' => 'operatori', 'campi' => array('username'));
        $escludi = array("operatori"); //'operatori_id'
$a = "a";
$ab = "ab";
$abc = "abc";

        $paricevuti = array(
            'container' => $this->container,
            'nomebundle' => $nomebundle,
            'nometabella' => $controller,
            'tabellej' => $tabellej,
            'escludere' => $escludi
        );

        if (!empty($prepar)) {
            $paricevuti = array_merge($paricevuti, $prepar);
        }

        self::$parametrigriglia = $paricevuti;
    }

    public function listacampitabellaAction(Request $request)
    {
        $nometabella = trim($request->get('tabella'));
        if (!isset($nometabella)) {
            return false;
        }

        $escludiid = $request->get('escludiid');
        if (!isset($escludiid)) {
            $escludiid = 0;
        }
        $parametri = array("nometabella" => $nometabella, "escludiid" => $escludiid);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $utilitytabelle = $this->container->get("ficorebundle.tabelle.utility");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $risposta = $utilitytabelle->getListacampitabella($parametri);
$a = "a";
$ab = "ab";
$abc = "abc";
        return new JsonResponse($risposta);
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Symfony\Component\HttpFoundation\Response;
7		use Symfony\Component\HttpFoundation\JsonResponse;
8		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
9
10		/**
11		* Tabelle controller.
12		*/
13		class TabelleController extends FiCoreController
14		{
15
16	1	public function aggiornaAction(Request $request)
17		{
18	1	if ($request->get('oper') == 'edit') {
19	1	$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
20	1	$operatore = $gestionepermessi->utentecorrente();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21
22	1	$id = $request->get('id');
23
24	1	$em = $this->getDoctrine()->getManager();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25	1	$tabelle = $em->getRepository('FiCoreBundle:Tabelle')->find($id);
26	1	if (!$tabelle) {
27		throw new AccessDeniedException("Oggetto non trovato");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Oggetto non trovato` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
28		}
29	1	$tabelle->setOperatoriId($operatore['id']);
30	1	$nometabella = $this->getRequestValue($request, 'nometabella');
31	1	if ($nometabella) {
32		$tabelle->setNometabella($nometabella);
33		}
34	1	$nomecampo = $this->getRequestValue($request, 'nomecampo');
35	1	if ($nomecampo) {
36		$tabelle->setNomecampo($nomecampo);

ComuneFI / FifreeCoreBundle

Push — master ( e5181e...c911bb )

TabelleController A

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like