StampatabellaController - Code Metrics - Inspection of "improve tests" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdce12...77b06d )

by Andrea

created 2018-02-24 10:01 UTC

StampatabellaController B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	349
Duplicated Lines	0 %

Test Coverage

Coverage

52.44%

Importance

Changes

Metric	Value
wmc	41
dl	0
loc	349
ccs	129
cts	246
cp	0.5244
rs	8.2769
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	__construct()	4	2
A	esportaexcel()	56	3
A	stampa()	55	3
A	getValueCell()	19	4
B	printHeaderXls()	34	4
B	stampaDettaglio()	53	7
B	stampaTestata()	33	3
A	getWidthColumn()	8	2
C	printBodyXls()	66	13

How to fix Complexity

<?php

namespace Fi\CoreBundle\Controller;

use Fi\CoreBundle\Utils\GrigliaFiltriUtils;
use TCPDF;

class StampatabellaController extends FiCoreController
{

    public function __construct($container = null)
    {
        if ($container) {
            $this->setContainer($container);
        }
    }

    public function stampa($parametri = array())
    {
        $testata = $parametri['testata'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $request = $parametri['request'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $nometabella = $request->get('nometabella');

        $pdf = new TCPDF(PDF_PAGE_ORIENTATION, PDF_UNIT, PDF_PAGE_FORMAT, true, 'UTF-8', false);

        //echo PDF_HEADER_LOGO;
        $pdftitle = isset($testata['titolo']) && ($testata['titolo'] != '') ? $testata['titolo'] : 'Elenco ' . $nometabella;
        $pdf->SetHeaderData(PDF_HEADER_LOGO, PDF_HEADER_LOGO_WIDTH, 'FiFree2', $pdftitle, array(0, 0, 0), array(0, 0, 0));
        $pdf->setFooterData(array(0, 0, 0), array(0, 0, 0));

        $pdf->setHeaderFont(array(PDF_FONT_NAME_MAIN, '', PDF_FONT_SIZE_MAIN));
        $pdf->setFooterFont(array(PDF_FONT_NAME_DATA, '', PDF_FONT_SIZE_DATA));

        $pdf->SetMargins(PDF_MARGIN_LEFT, PDF_MARGIN_TOP, PDF_MARGIN_RIGHT);
        $pdf->SetHeaderMargin(PDF_MARGIN_HEADER);
        $pdf->SetFooterMargin(PDF_MARGIN_FOOTER);
        $pdf->SetFillColor(220, 220, 220);

        $pdf->AddPage('L');
        $arraystampaparm = array(
            "larghezzaform" => 900,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "h" => 6,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "border" => 1,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "align" => 'L',
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "fill" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "ln" => 0
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
        $parametristampa = array_merge($parametri, $arraystampaparm);

        $this->stampaTestata($pdf, $parametristampa);

        $this->stampaDettaglio($pdf, $parametristampa);

        /*
          I: send the file inline to the browser (default). The plug-in is used if available.
          The name given by name is used when one selects the “Save as” option on the link generating the PDF.
          D: send to the browser and force a file download with the name given by name.
          F: save to a local server file with the name given by name.
          S: return the document as a string (name is ignored).
          FI: equivalent to F + I option
          FD: equivalent to F + D option
          E: return the document as base64 mime multi-part email attachment (RFC 2045)
         */

        /* In caso il pdf stampato nel browser resti fisso a caricare la pagina,
          impostare 'D' per forzare lo scarico del file, oppure
          mettere exit al posto di return 0; questo opzione però non è accettata da gli strumenti di controllo del codice che non si
          aspettano exit nel codice
         */
        $pdf->Output($request->get('nometabella') . '.pdf', 'I');

        return 0;
    }

    public function esportaexcel($parametri = array())
    {
        set_time_limit(960);
        ini_set('memory_limit', '2048M');

        $cacheMethod = \PHPExcel_CachedObjectStorageFactory::cache_to_phpTemp;
$a = "a";
$ab = "ab";
$abc = "abc";
        $cacheSettings = array('memoryCacheSize' => '8MB');
        \PHPExcel_Settings::setCacheStorageMethod($cacheMethod, $cacheSettings);

        //Creare un nuovo file
        $objPHPExcel = new \PHPExcel();

        $objPHPExcel->setActiveSheetIndex(0);

        // Set properties
        $objPHPExcel->getProperties()->setCreator('Comune di Firenze');
        $objPHPExcel->getProperties()->setLastModifiedBy('Comune di Firenze');

        $testata = $parametri['testata'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $rispostaj = $parametri['griglia'];

        $modellicolonne = $testata['modellocolonne'];

        //Scrittura su file
        $sheet = $objPHPExcel->getActiveSheet();
$a = "a";
$ab = "ab";
$abc = "abc";
        $titolosheet = 'Esportazione ' . $testata['tabella'];
        $sheet->setTitle(substr($titolosheet, 0, 30));
        $sheet->getParent()->getDefaultStyle()->getFont()->setName('Verdana');

        $this->printHeaderXls($modellicolonne, $testata, $sheet);

        $risposta = json_decode($rispostaj);
        if (isset($risposta->rows)) {
            $righe = $risposta->rows;
        } else {
            $righe = array();
        }

        $this->printBodyXls($righe, $modellicolonne, $sheet);

        //Si crea un oggetto
        $objWriter = new \PHPExcel_Writer_Excel5($objPHPExcel);
        $todaydate = date('d-m-y');

        $filename = 'Exportazione_' . $testata['tabella'];
        $filename = $filename . '-' . $todaydate . '-' . strtoupper(md5(uniqid(rand(), true)));
        $filename = $filename . '.xls';
        $filename = sys_get_temp_dir() . DIRECTORY_SEPARATOR . $filename;

        if (file_exists($filename)) {
            unlink($filename);
        }

        $objWriter->save($filename);

        return $filename;
    }

    private function printHeaderXls($modellicolonne, $testata, $sheet)
    {
        $indicecolonnaheader = 0;
        $letteracolonna = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($modellicolonne as $modellocolonna) {
            //Si imposta la larghezza delle colonne
            $letteracolonna = \PHPExcel_Cell::stringFromColumnIndex($indicecolonnaheader);
$a = "a";
$ab = "ab";
$abc = "abc";
            $width = (int) $modellocolonna['width'] / 7;
$a = "a";
$ab = "ab";
$abc = "abc";
            $indicecolonnaheadertitle = $testata['nomicolonne'][$indicecolonnaheader];
            $coltitlecalc = isset($indicecolonnaheadertitle) ? $indicecolonnaheadertitle : $modellocolonna['name'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $coltitle = strtoupper($coltitlecalc);
$a = "a";
$ab = "ab";
$abc = "abc";
            $sheet->setCellValueByColumnAndRow($indicecolonnaheader, 1, $coltitle);
            $sheet->getColumnDimension($letteracolonna)->setWidth($width);

            ++$indicecolonnaheader;
        }

        if ($indicecolonnaheader > 0) {
            //Si imposta il colore dello sfondo delle celle
            //Colore header
            $style_header = array(
                'fill' => array(
                    'type' => \PHPExcel_Style_Fill::FILL_SOLID,
                    'color' => array('rgb' => '0404B4'),
                ),
                'font' => array(
                    'bold' => true,
                    'color' => array('rgb' => 'FFFFFF'),
                ),
            );
            $sheet->getStyle('A1:' . $letteracolonna . '1')->applyFromArray($style_header);
        }

        $sheet->getRowDimension('1')->setRowHeight(20);
    }

    private function getValueCell($tipocampo, $vettorecella)
    {
        $valore = null;
        switch ($tipocampo) {
            case 'date':
                $d = (int) substr($vettorecella, 0, 2);
$a = "a";
$ab = "ab";
$abc = "abc";
                $m = (int) substr($vettorecella, 3, 2);
$a = "a";
$ab = "ab";
$abc = "abc";
                $y = (int) substr($vettorecella, 6, 4);
$a = "a";
$ab = "ab";
$abc = "abc";
                $t_date = \PHPExcel_Shared_Date::FormattedPHPToExcel($y, $m, $d);
                $valore = $t_date;
                break;
            case 'boolean':
                $valore = ($vettorecella == 1) ? 'SI' : 'NO';
                break;
            default:
                $valore = $vettorecella;
                break;
        }
        return $valore;
    }

    private function printBodyXls($righe, $modellicolonne, $sheet)
    {
        $row = 2;
        foreach ($righe as $riga) {
            $vettorecelle = $riga->cell;
            $col = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
            foreach ($vettorecelle as $vettorecella) {
                if ($vettorecella === '' || $vettorecella === null) {
                    $col = $col + 1;

                    continue;
                }
                $valore = $this->getValueCell($modellicolonne[$col]['tipocampo'], $vettorecella);
                $sheet->setCellValueByColumnAndRow($col, $row, $valore);
                $col = $col + 1;

            }
            $sheet->getRowDimension($row)->setRowHeight(18);
            ++$row;
        }

        $indicecolonna = 0;
        foreach ($modellicolonne as $modellocolonna) {
            $letteracolonna = \PHPExcel_Cell::stringFromColumnIndex($indicecolonna);
            switch ($modellocolonna['tipocampo']) {
                case 'text':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode(\PHPExcel_Style_NumberFormat::FORMAT_GENERAL);
                    break;
                case 'string':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode(\PHPExcel_Style_NumberFormat::FORMAT_GENERAL);
                    break;
                case 'integer':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode(\PHPExcel_Style_NumberFormat::FORMAT_NUMBER);
                    break;
                case 'float':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode('#,##0.00');
                    break;
                case 'number':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode('#,##0.00');
                    break;
                case 'datetime':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode('dd/mm/yyyy');
                    break;
                case 'date':
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode('dd/mm/yyyy');
                    break;
                default:
                    $sheet->getStyle($letteracolonna . '2:' . $letteracolonna . $row)
                            ->getNumberFormat()
                            ->setFormatCode(\PHPExcel_Style_NumberFormat::FORMAT_GENERAL);
                    break;
            }

            ++$indicecolonna;
        }
    }

    private function stampaTestata($pdf, $parametri)
    {
        $ln = $parametri['ln'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $fill = $parametri['fill'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $align = $parametri['align'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $border = $parametri['border'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $h = $parametri['h'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $larghezzaform = $parametri['larghezzaform'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata = $parametri['testata'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $nomicolonne = $testata['nomicolonne'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $modellicolonne = $testata['modellocolonne'];

        // Testata
        $pdf->SetFont('helvetica', 'B', 9);
        $arr_heights = array();
        // store current object
        $pdf->startTransaction();
        foreach ($nomicolonne as $posizione => $nomecolonna) {
            $width = $this->getWidthColumn($modellicolonne, $posizione, $larghezzaform);
            // get the number of lines
            $arr_heights[] = $pdf->MultiCell($width, 0, $nomecolonna, $border, $align, $fill, 0, '', '', true, 0, false, true, 0);
        }
        // restore previous object
        $pdf->rollbackTransaction(true);
        //work out the number of lines required
        $rowcount = max($arr_heights);
        //now draw it
        foreach ($nomicolonne as $posizione => $nomecolonna) {
            $width = $this->getWidthColumn($modellicolonne, $posizione, $larghezzaform);
            $pdf->MultiCell($width, $rowcount * $h, $nomecolonna, $border, $align, $fill, $ln);
        }
        $pdf->SetFont('helvetica', '', 9);
        $pdf->Ln();
    }

    private function stampaDettaglio($pdf, $parametri)
    {

        $ln = $parametri['ln'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $fill = $parametri['fill'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $align = $parametri['align'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $border = $parametri['border'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $h = $parametri['h'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $larghezzaform = $parametri['larghezzaform'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $testata = $parametri['testata'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $modellicolonne = $testata['modellocolonne'];

        $rispostaj = $parametri['griglia'];
        // Dati
        $risposta = json_decode($rispostaj);
$a = "a";
$ab = "ab";
$abc = "abc";
        $dimensions = $pdf->getPageDimensions();
        $righe = $risposta->rows;
$a = "a";
$ab = "ab";
$abc = "abc";
        $pdf->SetFont('helvetica', '', 9);
        foreach ($righe as $riga) {
            $fill = !$fill;
$a = "a";
$ab = "ab";
$abc = "abc";
            $vettorecelle = $riga->cell;

            $arr_heights = array();
            // store current object
            $pdf->startTransaction();
            foreach ($vettorecelle as $posizione => $valore) {
                if (!is_object($valore)) {
                    $width = $this->getWidthColumn($modellicolonne, $posizione, $larghezzaform);
                    // get the number of lines
                    $arr_heights[] = $pdf->MultiCell($width, 0, $valore, $border, $align, $fill, 0, '', '', true, 0, false, true, 0);
                }
            }
            // restore previous object
            $pdf->rollbackTransaction(true);
            //work out the number of lines required
            $rowcount = max($arr_heights);
            $startY = $pdf->GetY();
$a = "a";
$ab = "ab";
$abc = "abc";
            if (($startY + $rowcount * $h) + $dimensions['bm'] > ($dimensions['hk'])) {
                // page break
                $pdf->AddPage('L');
                // stampa testata
                $this->stampaTestata($pdf, $parametri);
            }
            //now draw it
            foreach ($vettorecelle as $posizione => $valore) {
                if (!is_object($valore)) {
                    $width = $this->getWidthColumn($modellicolonne, $posizione, $larghezzaform);
                    $pdf->MultiCell($width, $rowcount * $h, $valore, $border, $align, $fill, $ln);
                }
            }
            $pdf->Ln();
        }
        $pdf->Cell(0, 10, GrigliaFiltriUtils::traduciFiltri(array('filtri' => $risposta->filtri)), 0, false, 'L', 0, '', 0, false, 'T', 'M');
    }

    private function getWidthColumn($modellicolonne, $posizione, $larghezzaform)
    {
        if (isset($modellicolonne[$posizione])) {
            $width = ((297 * $modellicolonne[$posizione]['width']) / $larghezzaform) / 2;
        } else {
            $width = ((297 * 100) / $larghezzaform) / 2;
        }
        return $width;
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Fi\CoreBundle\Utils\GrigliaFiltriUtils;
6		use TCPDF;
7
8		class StampatabellaController extends FiCoreController
9		{
10
11		public function __construct($container = null)
12		{
13		if ($container) {
14		$this->setContainer($container);
15		}
16		}
17
18	2	public function stampa($parametri = array())
19		{
20	2	$testata = $parametri['testata'];
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21	2	$request = $parametri['request'];
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22	2	$nometabella = $request->get('nometabella');
23
24	2	$pdf = new TCPDF(PDF_PAGE_ORIENTATION, PDF_UNIT, PDF_PAGE_FORMAT, true, 'UTF-8', false);
25
26		//echo PDF_HEADER_LOGO;
27	2	$pdftitle = isset($testata['titolo']) && ($testata['titolo'] != '') ? $testata['titolo'] : 'Elenco ' . $nometabella;
28	2	$pdf->SetHeaderData(PDF_HEADER_LOGO, PDF_HEADER_LOGO_WIDTH, 'FiFree2', $pdftitle, array(0, 0, 0), array(0, 0, 0));
29	2	$pdf->setFooterData(array(0, 0, 0), array(0, 0, 0));
30
31	2	$pdf->setHeaderFont(array(PDF_FONT_NAME_MAIN, '', PDF_FONT_SIZE_MAIN));
32	2	$pdf->setFooterFont(array(PDF_FONT_NAME_DATA, '', PDF_FONT_SIZE_DATA));
33
34	2	$pdf->SetMargins(PDF_MARGIN_LEFT, PDF_MARGIN_TOP, PDF_MARGIN_RIGHT);
35	2	$pdf->SetHeaderMargin(PDF_MARGIN_HEADER);
36	2	$pdf->SetFooterMargin(PDF_MARGIN_FOOTER);
37	2	$pdf->SetFillColor(220, 220, 220);
38

ComuneFI / FifreeCoreBundle

Push — master ( bdce12...77b06d )

StampatabellaController B

Complexity

Size/Duplication

Test Coverage

Importance

9 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like