PannelloamministrazioneCommands - Code Metrics - Inspection of "fix coveralls" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d27c52...62b14a )

by Andrea

created 2018-08-23 06:35 UTC

PannelloamministrazioneCommands A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	145
Duplicated Lines	0 %

Test Coverage

Coverage

64.1%

Importance

Changes

Metric	Value
wmc	20
eloc	81
dl	0
loc	145
ccs	50
cts	78
cp	0.641
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	aggiornaSchemaDatabase()	5	1
A	clearcacheEnv()	5	1
A	getVcs()	18	4
A	checkFormCrud()	28	5
A	generateEntity()	20	2
A	clearcache()	10	2
A	generateEntityClass()	20	2
A	generateFormCrud()	19	2

<?php

namespace Fi\PannelloAmministrazioneBundle\DependencyInjection;

use Symfony\Component\Filesystem\Filesystem;
use Fi\OsBundle\DependencyInjection\OsFunctions;

class PannelloamministrazioneCommands
{

    private $container;
    private $apppaths;
    private $pammutils;

    public function __construct($container)
    {
        $this->container = $container;
        $this->apppaths = $container->get("pannelloamministrazione.projectpath");
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->pammutils = $container->get("pannelloamministrazione.utils");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    public function getVcs()
    {
        $fs = new Filesystem();

        $sepchr = OsFunctions::getSeparator();
$a = "a";
$ab = "ab";
$abc = "abc";
        $projectDir = $this->apppaths->getRootPath();
        $vcscommand = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.svn')) {
            $vcscommand = 'svn update';
        }
        if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.git')) {
            $vcscommand = 'git pull';
        }
        if (!$vcscommand) {
            throw new \Exception("Vcs non trovato", 100);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $command = 'cd ' . $projectDir . $sepchr . $vcscommand;
        return $this->pammutils->runCommand($command);
    }
    public function generateEntity($wbFile)
    {
        $command = "pannelloamministrazione:generateymlentities";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $result = $this->pammutils->runSymfonyCommand($command, array('mwbfile' => $wbFile));
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($result["errcode"] != 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return array(
                'errcode' => -1,
                'message' => 'Errore nel comando: <i style="color: white;">' .
                $command . '</i><br/><i style="color: red;">' .
                str_replace("\n", '<br/>', $result["message"]) .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                'in caso di errori eseguire il comando symfony non da web: pannelloamministrazione:generateymlentities ' .
                $wbFile . '<br/></i>',
            );
        }

        return array(
            'errcode' => 0,
            'message' => '<pre>Eseguito comando: <i style = "color: white;">' .
            $command . '</i><br/>' . str_replace("\n", '<br/>', $result["message"]) . '</pre>',);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    public function generateEntityClass()
    {
        $command = "pannelloamministrazione:generateentities";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $result = $this->pammutils->runSymfonyCommand($command, array());
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($result["errcode"] != 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return array(
                'errcode' => -1,
                'message' => 'Errore nel comando: <i style="color: white;">' .
                $command . '</i><br/><i style="color: red;">' .
                str_replace("\n", '<br/>', $result["message"]) .
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                'in caso di errori eseguire il comando symfony non da web: pannelloamministrazione:generateentities ' .
                '<br/>Opzione --schemaupdate oer aggiornare anche lo schema database</i>',
            );
        }

        return array(
            'errcode' => 0,
            'message' => '<pre>Eseguito comando: <i style = "color: white;">' .
            $command . '</i><br/>' . str_replace("\n", '<br/>', $result["message"]) . '</pre>',);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    public function generateFormCrud($entityform)
    {
        /* @var $fs \Symfony\Component\Filesystem\Filesystem */
        $resultchk = $this->checkFormCrud($entityform);

        if ($resultchk["errcode"] != 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return $resultchk;
        }
        $formcrudparms = array("entityform" => $entityform);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $retmsggenerateform = $this->pammutils->runSymfonyCommand('pannelloamministrazione:generateformcrud', $formcrudparms);

        $retmsg = array(
            'errcode' => $retmsggenerateform['errcode'],
            'command' => $retmsggenerateform['command'],
            'message' => $retmsggenerateform['message'],
        );

        return $retmsg;
    }
    public function checkFormCrud($entityform)
    {
        /* @var $fs \Symfony\Component\Filesystem\Filesystem */
        $fs = new Filesystem();
$a = "a";
$ab = "ab";
$abc = "abc";
        $srcPath = $this->apppaths->getSrcPath();
        $appPath = $srcPath;
        if (!is_writable($appPath)) {
            return array('errcode' => -1, 'message' => $appPath . ' non scrivibile');
        }
        $formPath = $appPath . '/Form/' . $entityform . 'Type.php';

        if ($fs->exists($formPath)) {
            return array('errcode' => -1, 'message' => $formPath . ' esistente');
        }

        $controllerPath = $appPath . '/Controller' . DIRECTORY_SEPARATOR . $entityform . 'Controller.php';

        if ($fs->exists($controllerPath)) {
            return array('errcode' => -1, 'message' => $controllerPath . ' esistente');
        }

        $viewPathSrc = $appPath . '/Resources/views/' . $entityform;

        if ($fs->exists($viewPathSrc)) {
            return array('errcode' => -1, 'message' => $viewPathSrc . ' esistente');
        }

        return array('errcode' => 0, 'message' => 'OK');
    }
    public function clearcache()
    {
        $cmdoutput = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $envs = array("dev", "test", "prod");
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($envs as $env) {
            $cmdoutput = $cmdoutput . $this->clearcacheEnv($env);
        }
        //$cmdoutput = $cmdoutput . $this->clearcacheEnv($this->container->get('kernel')->getEnvironment());


        return $cmdoutput;
    }
    public function clearcacheEnv($env)
    {
        $ret = $this->pammutils->clearcache($env);

        return $ret["errmsg"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    public function aggiornaSchemaDatabase()
    {
        $result = $this->pammutils->runSymfonyCommand('doctrine:schema:update', array('--force' => true));

        return $result;
    }
}


1		<?php
2
3		namespace Fi\PannelloAmministrazioneBundle\DependencyInjection;
4
5		use Symfony\Component\Filesystem\Filesystem;
6		use Fi\OsBundle\DependencyInjection\OsFunctions;
7
8		class PannelloamministrazioneCommands
9		{
10
11		private $container;
12		private $apppaths;
13		private $pammutils;
14
15	2	public function __construct($container)
16		{
17	2	$this->container = $container;
18	2	$this->apppaths = $container->get("pannelloamministrazione.projectpath");
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione.projectpath` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19	2	$this->pammutils = $container->get("pannelloamministrazione.utils");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione.utils` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
20	2	}
21	1	public function getVcs()
22		{
23	1	$fs = new Filesystem();
24
25	1	$sepchr = OsFunctions::getSeparator();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26	1	$projectDir = $this->apppaths->getRootPath();
27	1	$vcscommand = "";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
28	1	if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.svn')) {
29		$vcscommand = 'svn update';
30		}
31	1	if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.git')) {
32		$vcscommand = 'git pull';
33		}
34	1	if (!$vcscommand) {
35	1	throw new \Exception("Vcs non trovato", 100);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Vcs non trovato` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
36		}
37		$command = 'cd ' . $projectDir . $sepchr . $vcscommand;
38		return $this->pammutils->runCommand($command);
39		}
40	1	public function generateEntity($wbFile)
41		{
42	1	$command = "pannelloamministrazione:generateymlentities";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione:generateymlentities` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
43	1	$result = $this->pammutils->runSymfonyCommand($command, array('mwbfile' => $wbFile));
		0 ignored issues – show Coding Style introduced 2018-03-22 22:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
44
45	1	if ($result["errcode"] != 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
46		return array(
47		'errcode' => -1,
48		'message' => 'Errore nel comando: <i style="color: white;">' .
49		$command . '</i><br/><i style="color: red;">' .
50		str_replace("\n", '<br/>', $result["message"]) .
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
51		'in caso di errori eseguire il comando symfony non da web: pannelloamministrazione:generateymlentities ' .
52		$wbFile . '<br/></i>',
53		);
54		}
55
56		return array(
57	1	'errcode' => 0,
58		'message' => '<pre>Eseguito comando: <i style = "color: white;">' .
59	1	$command . '</i><br/>' . str_replace("\n", '<br/>', $result["message"]) . '</pre>',);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
60		}
61	1	public function generateEntityClass()
62		{
63	1	$command = "pannelloamministrazione:generateentities";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione:generateentities` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
64	1	$result = $this->pammutils->runSymfonyCommand($command, array());
		0 ignored issues – show Coding Style introduced 2018-03-22 22:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
65
66	1	if ($result["errcode"] != 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-22 22:06 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67		return array(
68		'errcode' => -1,
69		'message' => 'Errore nel comando: <i style="color: white;">' .
70		$command . '</i><br/><i style="color: red;">' .
71		str_replace("\n", '<br/>', $result["message"]) .
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72		'in caso di errori eseguire il comando symfony non da web: pannelloamministrazione:generateentities ' .
73		'<br/>Opzione --schemaupdate oer aggiornare anche lo schema database</i>',
74		);
75		}
76
77		return array(
78	1	'errcode' => 0,
79		'message' => '<pre>Eseguito comando: <i style = "color: white;">' .
80	1	$command . '</i><br/>' . str_replace("\n", '<br/>', $result["message"]) . '</pre>',);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
81		}
82	1	public function generateFormCrud($entityform)
83		{
84		/* @var $fs \Symfony\Component\Filesystem\Filesystem */
85	1	$resultchk = $this->checkFormCrud($entityform);
86
87	1	if ($resultchk["errcode"] != 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
88		return $resultchk;
89		}
90	1	$formcrudparms = array("entityform" => $entityform);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-22 22:06 UTC by Report Bug Copy Issue Report The string literal `entityform` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
91
92	1	$retmsggenerateform = $this->pammutils->runSymfonyCommand('pannelloamministrazione:generateformcrud', $formcrudparms);
93
94		$retmsg = array(
95	1	'errcode' => $retmsggenerateform['errcode'],
96	1	'command' => $retmsggenerateform['command'],
97	1	'message' => $retmsggenerateform['message'],
98		);
99
100	1	return $retmsg;
101		}
102	1	public function checkFormCrud($entityform)
103		{
104		/* @var $fs \Symfony\Component\Filesystem\Filesystem */
105	1	$fs = new Filesystem();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
106	1	$srcPath = $this->apppaths->getSrcPath();
107	1	$appPath = $srcPath;
108	1	if (!is_writable($appPath)) {
109		return array('errcode' => -1, 'message' => $appPath . ' non scrivibile');
110		}
111	1	$formPath = $appPath . '/Form/' . $entityform . 'Type.php';
112
113	1	if ($fs->exists($formPath)) {
114		return array('errcode' => -1, 'message' => $formPath . ' esistente');
115		}
116
117	1	$controllerPath = $appPath . '/Controller' . DIRECTORY_SEPARATOR . $entityform . 'Controller.php';
118
119	1	if ($fs->exists($controllerPath)) {
120		return array('errcode' => -1, 'message' => $controllerPath . ' esistente');
121		}
122
123	1	$viewPathSrc = $appPath . '/Resources/views/' . $entityform;
124
125	1	if ($fs->exists($viewPathSrc)) {
126		return array('errcode' => -1, 'message' => $viewPathSrc . ' esistente');
127		}
128
129	1	return array('errcode' => 0, 'message' => 'OK');
130		}
131		public function clearcache()
132		{
133		$cmdoutput = "";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
134		$envs = array("dev", "test", "prod");
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `dev` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `test` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `prod` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
135		foreach ($envs as $env) {
136		$cmdoutput = $cmdoutput . $this->clearcacheEnv($env);
137		}
138		//$cmdoutput = $cmdoutput . $this->clearcacheEnv($this->container->get('kernel')->getEnvironment());
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-16 17:42 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
139
140		return $cmdoutput;
141		}
142		public function clearcacheEnv($env)
143		{
144		$ret = $this->pammutils->clearcache($env);
145
146		return $ret["errmsg"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `errmsg` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
147		}
148	1	public function aggiornaSchemaDatabase()
149		{
150	1	$result = $this->pammutils->runSymfonyCommand('doctrine:schema:update', array('--force' => true));
151
152	1	return $result;
153		}
154		}
155

ComuneFI / FifreeCoreBundle

Push — master ( d27c52...62b14a )

PannelloamministrazioneCommands A

Complexity

Size/Duplication

Test Coverage

Importance

9 Methods

Duplication Side-by-Side

Filter issues like