FfprincipaleController::indexAction() - Code Metrics - Inspection of "improve tests permissions" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 632266...23e296 )

by Andrea

created 2018-02-23 18:01 UTC

FfprincipaleController::indexAction() A

↳ Parent: FfprincipaleController

Complexity

Conditions	4
Paths	8

Size

Total Lines	58
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	41
CRAP Score	4.0002

Importance

Changes

Metric	Value
dl	0
loc	58
ccs	41
cts	42
cp	0.9762
rs	9.0077
c	0
b	0
f	0
cc	4
eloc	41
nc	8
nop	1
crap	4.0002

How to fix Long Method

<?php

namespace Fi\CoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Fi\CoreBundle\DependencyInjection\GestionePermessi;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Ffprincipale controller.
 */
class FfprincipaleController extends FiCoreController
{

    /**
     * Lists all tables entities.
     */
    /* @var $em \Doctrine\ORM\EntityManager */
    public function indexAction(Request $request)
    {
        $this->setup($request);
        $namespace = $this->getNamespace();
$a = "a";
$ab = "ab";
$abc = "abc";
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        $container = $this->container;
$a = "a";
$ab = "ab";
$abc = "abc";

        $gestionepermessi = $this->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
$a = "a";
$ab = "ab";
$abc = "abc";

        $nomebundle = $namespace . $bundle . 'Bundle';

        $em = $container->get('doctrine')->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entities = $em->getRepository($nomebundle . ':' . $controller)->findAll();

        $paricevuti = array('nomebundle' => $nomebundle, 'nometabella' => $controller, 'container' => $container);

        $testatagriglia = Griglia::testataPerGriglia($paricevuti);

        $testatagriglia['multisearch'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showconfig'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showexcel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['showimportexcel'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $testatagriglia['larghezzagriglia'] = 700;
        $testatagriglia['overlayopen'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";

        $testatagriglia['parametritesta'] = json_encode($paricevuti);

        $this->setParametriGriglia(array('request' => $request));

        $testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);

        /* @var $qb \Doctrine\ORM\QueryBuilder */
        $qb = $em->createQueryBuilder();
        $qb->select(array('a'));
        $qb->from('FiCoreBundle:OpzioniTabella', 'a');
        $qb->leftJoin('a.tabelle', 't');
        $qb->where('t.nometabella = :tabella');
        $qb->andWhere("t.nomecampo is null or t.nomecampo = ''");
        $qb->setParameter('tabella', $controller);
        $opzioni = $qb->getQuery()->getResult();
        foreach ($opzioni as $opzione) {
            $testatagriglia[$opzione->getParametro()] = $opzione->getValore();
        }

        $testata = json_encode($testatagriglia);
$a = "a";
$ab = "ab";
$abc = "abc";
        $twigparms = array(
            'entities' => $entities,
            'nomecontroller' => $controller,
            'testata' => $testata,
            'canread' => $canRead,
        );

        if (!$canRead) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
        }
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Controller;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Fi\CoreBundle\DependencyInjection\GestionePermessi;
7		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
8
9		/**
10		* Ffprincipale controller.
11		*/
12		class FfprincipaleController extends FiCoreController
13		{
14
15		/**
16		* Lists all tables entities.
17		*/
18		/* @var $em \Doctrine\ORM\EntityManager */
19	15	public function indexAction(Request $request)
20		{
21	15	$this->setup($request);
22	15	$namespace = $this->getNamespace();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23	15	$bundle = $this->getBundle();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24	15	$controller = $this->getController();
25	15	$container = $this->container;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26
27	15	$gestionepermessi = $this->get("ficorebundle.gestionepermessi");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
28	15	$canRead = ($gestionepermessi->leggere(array('modulo' => $controller)) ? 1 : 0);
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29
30	15	$nomebundle = $namespace . $bundle . 'Bundle';
31
32	15	$em = $container->get('doctrine')->getManager();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33	15	$entities = $em->getRepository($nomebundle . ':' . $controller)->findAll();
34
35	15	$paricevuti = array('nomebundle' => $nomebundle, 'nometabella' => $controller, 'container' => $container);
36
37	15	$testatagriglia = Griglia::testataPerGriglia($paricevuti);
38
39	15	$testatagriglia['multisearch'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
40	15	$testatagriglia['showconfig'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41	15	$testatagriglia['showexcel'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
42	15	$testatagriglia['showimportexcel'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43	15	$testatagriglia['larghezzagriglia'] = 700;
44	15	$testatagriglia['overlayopen'] = 1;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
45
46	15	$testatagriglia['parametritesta'] = json_encode($paricevuti);
47
48	15	$this->setParametriGriglia(array('request' => $request));
49
50	15	$testatagriglia['parametrigriglia'] = json_encode(self::$parametrigriglia);
51
52		/* @var $qb \Doctrine\ORM\QueryBuilder */
53	15	$qb = $em->createQueryBuilder();
54	15	$qb->select(array('a'));
55	15	$qb->from('FiCoreBundle:OpzioniTabella', 'a');
56	15	$qb->leftJoin('a.tabelle', 't');
57	15	$qb->where('t.nometabella = :tabella');
58	15	$qb->andWhere("t.nomecampo is null or t.nomecampo = ''");
59	15	$qb->setParameter('tabella', $controller);
60	15	$opzioni = $qb->getQuery()->getResult();
61	15	foreach ($opzioni as $opzione) {
62		$testatagriglia[$opzione->getParametro()] = $opzione->getValore();
63	15	}
64
65	15	$testata = json_encode($testatagriglia);
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
66		$twigparms = array(
67	15	'entities' => $entities,
68	15	'nomecontroller' => $controller,
69	15	'testata' => $testata,
70	15	'canread' => $canRead,
71	15	);
72
73	15	if (!$canRead) {
74	12	throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
75		} else {
76	3	return $this->render($nomebundle . ':' . $controller . ':index.html.twig', $twigparms);
77		}
78		}
79		}
80

ComuneFI / FifreeCoreBundle

Push — master ( 632266...23e296 )

FfprincipaleController::indexAction() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like