PermessiTwigExtension - Code Metrics - Inspection of "improve tests permissions" - ComuneFI/FifreeCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 632266...23e296 )

by Andrea

created 2018-02-23 18:01 UTC

PermessiTwigExtension A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Test Coverage

Coverage

85.71%

Importance

Changes

Metric	Value
wmc	9
dl	0
loc	59
ccs	24
cts	28
cp	0.8571
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getFilters()	4	1
A	getFunctions()	3	1
A	__construct()	4	1
B	singoloPermesso()	21	5
A	getControllerName()	7	1

<?php

namespace Fi\CoreBundle\Twig\Extension;

class PermessiTwigExtension extends \Twig_Extension
{

    protected $requeststack;
    protected $container;

    public function __construct($container, $request_stack)
    {
        $this->container = $container;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->requeststack = $request_stack;
    }

    /**
     * Get current controller name.
     */
    public function getControllerName()
    {
        $pattern = "#Controller\\\([a-zA-Z]*)Controller#";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $matches = array();
        preg_match($pattern, $this->requeststack->getCurrentRequest()->get('_controller'), $matches);

        return $matches[1];
    }

    public function getFunctions()
    {
        return array(
                //'permesso' => new \Twig_Function_Method($this, 'controllaPermesso'),

        );
    }

    public function getFilters()
    {
        return array(
            new \Twig_SimpleFilter('permesso', array($this, 'singoloPermesso')),
        );
    }

    public function singoloPermesso($lettera)
    {
        $gestionepermessi = $this->container->get("ficorebundle.gestionepermessi");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $parametri = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $parametri['modulo'] = $this->getControllerName();
        switch ($lettera) {
            case 'c':
                return $gestionepermessi->creare($parametri);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'r':
                return $gestionepermessi->leggere($parametri);
                break;
            case 'u':
                return $gestionepermessi->aggiornare($parametri);
                break;
            case 'd':
                return $gestionepermessi->cancellare($parametri);
                break;
            default:
                break;
        }
    }
}


1		<?php
2
3		namespace Fi\CoreBundle\Twig\Extension;
4
5		class PermessiTwigExtension extends \Twig_Extension
6		{
7
8		protected $requeststack;
9		protected $container;
10
11	32	public function __construct($container, $request_stack)
12		{
13	32	$this->container = $container;
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
14	32	$this->requeststack = $request_stack;
15	32	}
16
17		/**
18		* Get current controller name.
19		*/
20	4	public function getControllerName()
21		{
22	4	$pattern = "#Controller\\\([a-zA-Z]*)Controller#";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `#Controller\\\([a-zA-Z]*)Controller#` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
23	4	$matches = array();
24	4	preg_match($pattern, $this->requeststack->getCurrentRequest()->get('_controller'), $matches);
25
26	4	return $matches[1];
27		}
28
29	11	public function getFunctions()
30		{
31		return array(
32		//'permesso' => new \Twig_Function_Method($this, 'controllaPermesso'),
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-16 17:42 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33	11	);
34		}
35
36	11	public function getFilters()
37		{
38		return array(
39	11	new \Twig_SimpleFilter('permesso', array($this, 'singoloPermesso')),
40	11	);
41		}
42
43	4	public function singoloPermesso($lettera)
44		{
45	4	$gestionepermessi = $this->container->get("ficorebundle.gestionepermessi");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report The string literal `ficorebundle.gestionepermessi` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
46
47	4	$parametri = array();
		0 ignored issues – show Coding Style introduced 2018-02-07 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48	4	$parametri['modulo'] = $this->getControllerName();
49		switch ($lettera) {
50	4	case 'c':
51		return $gestionepermessi->creare($parametri);
52		break;
		0 ignored issues – show Unused Code introduced 2018-02-07 21:46 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
53	4	case 'r':
54		return $gestionepermessi->leggere($parametri);
55		break;
56	4	case 'u':
57	4	return $gestionepermessi->aggiornare($parametri);
58		break;
59	4	case 'd':
60	4	return $gestionepermessi->cancellare($parametri);
61		break;
62		default:
63		break;
64		}
65		}
66		}
67

ComuneFI / FifreeCoreBundle

Push — master ( 632266...23e296 )

PermessiTwigExtension A

Complexity

Size/Duplication

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like