ComuneFI /
FifreeCoreBundle
| Total Complexity | 48 |
| Total Lines | 317 |
| Duplicated Lines | 0 % |
| Coverage | 81.45% |
| Changes | 9 | ||
| Bugs | 4 | Features | 1 |
Complex classes like Fifree2configuratorimportCommand often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Fifree2configuratorimportCommand, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class Fifree2configuratorimportCommand extends ContainerAwareCommand |
||
| 14 | { |
||
| 15 | |||
| 16 | private $forceupdate = false; |
||
| 17 | private $verboso = false; |
||
| 18 | private $dbutility; |
||
| 19 | private $systementity; |
||
| 20 | private $entityutility; |
||
| 21 | private $em; |
||
| 22 | private $truncatetables; |
||
| 23 | private $output; |
||
| 24 | |||
| 25 | 6 | protected function configure() |
|
| 26 | { |
||
| 27 | $this |
||
| 28 | 6 | ->setName('fifree2:configuratorimport') |
|
| 29 | 6 | ->setDescription('Configuratore per Fifree') |
|
| 30 | 6 | ->setHelp('Importa la configurazione di fifree da file fixtures.yml') |
|
| 31 | 6 | ->addOption('forceupdate', null, InputOption::VALUE_NONE, 'Forza update di record con id già presente') |
|
| 32 | 6 | ->addOption('truncatetables', null, InputOption::VALUE_NONE, 'Esegue una truncate della tabelle') |
|
| 33 | 6 | ->addOption('verboso', null, InputOption::VALUE_NONE, 'Visualizza tutti i messaggi di importazione'); |
|
| 34 | 6 | } |
|
| 35 | |||
| 36 | 2 | protected function execute(InputInterface $input, OutputInterface $output) |
|
| 37 | { |
||
| 38 | 2 | $this->output = $output; |
|
| 39 | 2 | $this->forceupdate = $input->getOption('forceupdate'); |
|
| 40 | 2 | $this->verboso = $input->getOption('verboso'); |
|
| 41 | 2 | $this->truncatetables = $input->getOption('truncatetables'); |
|
| 42 | 2 | $this->dbutility = $this->getContainer()->get("ficorebundle.database.utility"); |
|
| 43 | 2 | $this->entityutility = $this->getContainer()->get("ficorebundle.entity.utility"); |
|
| 44 | 2 | $this->systementity = $this->getContainer()->get("ficorebundle.entity.system"); |
|
| 45 | 2 | $this->em = $this->getContainer()->get("doctrine")->getManager(); |
|
| 46 | |||
| 47 | 2 | $this->checkSchemaStatus(); |
|
| 48 | 2 | $this->checkSysstemTables(); |
|
| 49 | |||
| 50 | 2 | $fixturefile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . "fixtures.yml"; |
|
| 51 | 2 | $ret = $this->import($fixturefile); |
|
| 52 | 2 | return $ret; |
|
| 53 | } |
||
| 54 | |||
| 55 | 2 | protected function import($fixturefile) |
|
| 56 | { |
||
| 57 | 2 | $fs = new Filesystem; |
|
| 58 | 2 | if ($fs->exists($fixturefile)) { |
|
| 59 | 2 | $fixtures = Yaml::parse(file_get_contents($fixturefile)); |
|
| 60 | 2 | $msg = "<info>Trovate " . count($fixtures) . " entities nel file " . $fixturefile . "</info>"; |
|
| 61 | 2 | $this->output->writeln($msg); |
|
| 62 | |||
| 63 | 2 | if ($this->truncatetables) { |
|
| 64 | 1 | foreach ($fixtures as $entityclass => $fixture) { |
|
| 65 | 1 | $this->truncateTable($entityclass); |
|
| 66 | } |
||
| 67 | } |
||
| 68 | 2 | $sortedEntities = $this->getSortedEntities($fixtures); |
|
| 69 | 2 | foreach ($sortedEntities as $entityclass => $fixture) { |
|
| 70 | 2 | $ret = $this->executeImport($entityclass, $fixture); |
|
| 71 | 2 | if ($ret == 1) { |
|
| 72 | return 1; |
||
| 73 | } |
||
| 74 | } |
||
| 75 | 2 | return 0; |
|
| 76 | } else { |
||
| 77 | 1 | $msgerr = "<error>Non trovato file " . $fixturefile . "</error>"; |
|
| 78 | 1 | $this->output->writeln($msgerr); |
|
| 79 | 1 | return 1; |
|
| 80 | } |
||
| 81 | } |
||
| 82 | |||
| 83 | 2 | private function checkSysstemTables() |
|
| 86 | 2 | } |
|
| 87 | |||
| 88 | 2 | private function checkSchemaStatus() |
|
| 89 | { |
||
| 90 | 2 | $schemachanged = $this->dbutility->isSchemaChanged(); |
|
| 91 | |||
| 92 | 2 | if ($schemachanged) { |
|
| 93 | 2 | $msgerr = "<error>Attenzione, lo schema database non è aggiornato, verrà comunque tentata l'importazione</error>"; |
|
| 94 | 2 | $this->output->writeln($msgerr); |
|
| 95 | 2 | sleep(3); |
|
| 96 | } |
||
| 97 | 2 | } |
|
| 98 | |||
| 99 | 1 | private function truncateTable($entityclass) |
|
| 100 | { |
||
| 101 | 1 | $tablename = $this->entityutility->getTableFromEntity($entityclass); |
|
| 102 | 1 | $msg = "<info>TRUNCATE della tabella " . $tablename . " (" . $entityclass . ")</info>"; |
|
| 103 | 1 | $this->output->writeln($msg); |
|
| 104 | 1 | $this->dbutility->truncatetable($entityclass, true); |
|
| 105 | 1 | } |
|
| 106 | |||
| 107 | /** |
||
| 108 | * @SuppressWarnings(PHPMD.UnusedLocalVariable) |
||
| 109 | */ |
||
| 110 | 2 | private function getSortedEntities($fixtures) |
|
| 111 | { |
||
| 112 | 2 | $entities = array(); |
|
| 113 | 2 | $sortedEntities = $this->systementity->getSystemEntities(); |
|
| 114 | 2 | foreach ($sortedEntities as $fixture => $details) { |
|
| 115 | 2 | if (isset($fixtures[$fixture])) { |
|
| 116 | 2 | $entities[$fixture] = $fixtures[$fixture]; |
|
| 117 | } |
||
| 118 | } |
||
| 119 | 2 | return $entities; |
|
| 120 | } |
||
| 121 | |||
| 122 | 2 | private function executeImport($entityclass, $fixture) |
|
| 123 | { |
||
| 124 | 2 | $msg = "<info>Trovati " . count($fixture) . " record per l'entity " . $entityclass . "</info>"; |
|
| 125 | 2 | $this->output->writeln($msg); |
|
| 126 | 2 | foreach ($fixture as $record) { |
|
| 127 | 2 | $objrecord = $this->em->getRepository($entityclass)->find($record["id"]); |
|
| 128 | 2 | $ret = $this->switchInsertUpdate($entityclass, $record, $objrecord); |
|
| 129 | 2 | if ($ret !== 0) { |
|
| 130 | return 1; |
||
| 131 | } |
||
| 132 | } |
||
| 133 | 2 | return 0; |
|
| 134 | } |
||
| 135 | |||
| 136 | 2 | private function switchInsertUpdate($entityclass, $record, $objrecord) |
|
| 149 | } |
||
| 150 | } |
||
| 151 | |||
| 152 | 2 | private function executeInsert($entityclass, $record) |
|
| 153 | { |
||
| 154 | 2 | $objrecord = new $entityclass(); |
|
| 155 | 2 | foreach ($record as $key => $value) { |
|
| 156 | 2 | if ($key !== 'id') { |
|
| 157 | 2 | $propertyEntity = $this->entityutility->getEntityProperties($key, $objrecord); |
|
| 158 | 2 | $getfieldname = $propertyEntity["get"]; |
|
| 159 | 2 | $setfieldname = $propertyEntity["set"]; |
|
| 160 | 2 | $fieldtype = $this->dbutility->getFieldType($objrecord, $key); |
|
| 161 | 2 | if ($fieldtype === 'boolean') { |
|
| 162 | 2 | $newval = FieldTypeUtility::getBooleanValue($value); |
|
| 163 | 2 | $msgok = "<info>Inserimento " . $entityclass . " con id " . $record["id"] |
|
| 164 | 2 | . " per campo " . $key . " con valore " |
|
| 165 | 2 | . var_export($newval, true) . " in formato Boolean</info>"; |
|
| 166 | 2 | $this->output->writeln($msgok); |
|
| 167 | 2 | $objrecord->$setfieldname($newval); |
|
| 168 | 2 | continue; |
|
| 169 | } |
||
| 170 | //Si prende in considerazione solo il null del boolean, gli altri non si toccano |
||
| 171 | 2 | if (!$value) { |
|
| 172 | 2 | continue; |
|
| 173 | } |
||
| 174 | 2 | if ($fieldtype === 'datetime' || $fieldtype === 'date') { |
|
| 175 | 2 | $date = FieldTypeUtility::getDateTimeValueFromTimestamp($value); |
|
| 176 | 2 | $msgok = "<info>Inserimento " . $entityclass . " con id " . $record["id"] |
|
| 177 | 2 | . " per campo " . $key . " cambio valore da " |
|
| 178 | 2 | . ($objrecord->$getfieldname() ? $objrecord->$getfieldname()->format("Y-m-d H:i:s") : "NULL") |
|
| 179 | 2 | . " a " . $date->format("Y-m-d H:i:s") . " in formato DateTime</info>"; |
|
| 180 | 2 | $this->output->writeln($msgok); |
|
| 181 | 2 | $objrecord->$setfieldname($date); |
|
| 182 | 2 | continue; |
|
| 183 | } |
||
| 184 | 2 | if (is_array($value)) { |
|
| 185 | 2 | $msgarray = "<info>Inserimento " . $entityclass . " con id " . $record["id"] |
|
| 186 | 2 | . " per campo " . $key . " cambio valore da " |
|
| 187 | 2 | . json_encode($objrecord->$getfieldname()) . " a " |
|
| 188 | 2 | . json_encode($value) . " in formato array" . "</info>"; |
|
| 189 | 2 | $this->output->writeln($msgarray); |
|
| 190 | 2 | $objrecord->$setfieldname($value); |
|
| 191 | 2 | continue; |
|
| 192 | } |
||
| 193 | |||
| 194 | 2 | $joincolumn = $this->entityutility->getJoinTableField($entityclass, $key); |
|
| 195 | 2 | $joincolumnproperty = $this->entityutility->getJoinTableFieldProperty($entityclass, $key); |
|
| 196 | 2 | if ($joincolumn && $joincolumnproperty) { |
|
| 197 | 2 | $joincolumnobj = $this->em->getRepository($joincolumn)->find($value); |
|
| 198 | 2 | $msgok = "<info>Inserimento " . $entityclass . " con id " . $record["id"] |
|
| 199 | 2 | . " per campo " . $key |
|
| 200 | 2 | . " con valore " . print_r($value, true) . " tramite entity find</info>"; |
|
|
Bug
introduced
by
|
|||
| 201 | 2 | $this->output->writeln($msgok); |
|
| 202 | 2 | $joinobj = $this->entityutility->getEntityProperties($joincolumnproperty, new $entityclass()); |
|
| 203 | 2 | $setfieldname = $joinobj["set"]; |
|
| 204 | 2 | $objrecord->$setfieldname($joincolumnobj); |
|
| 205 | 2 | continue; |
|
| 206 | } |
||
| 207 | 2 | $objrecord->$setfieldname($value); |
|
| 208 | } |
||
| 209 | } |
||
| 210 | 2 | $this->em->persist($objrecord); |
|
| 211 | 2 | $this->em->flush(); |
|
| 212 | |||
| 213 | 2 | $infomsg = "<info>" . $entityclass . " con id " . $objrecord->getId() . " aggiunta</info>"; |
|
| 214 | 2 | $this->output->writeln($infomsg); |
|
| 215 | 2 | $checkid = $this->changeRecordId($entityclass, $record, $objrecord); |
|
| 216 | 2 | return $checkid; |
|
| 217 | } |
||
| 218 | |||
| 219 | 2 | private function changeRecordId($entityclass, $record, $objrecord) |
|
| 240 | } |
||
| 241 | |||
| 242 | 1 | private function executeUpdate($entityclass, $record, $objrecord) |
|
| 243 | { |
||
| 244 | 1 | unset($record["id"]); |
|
| 245 | 1 | foreach ($record as $key => $value) { |
|
| 246 | 1 | $propertyEntity = $this->entityutility->getEntityProperties($key, $objrecord); |
|
| 247 | 1 | $getfieldname = $propertyEntity["get"]; |
|
| 248 | 1 | $setfieldname = $propertyEntity["set"]; |
|
| 332 |
Loading history...
