DoctrineFieldReader::object2View() - Code Metrics - Inspection of "refactor config" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 3e7b2f...75e02f )

by Andrea

created 2018-11-30 06:55 UTC

DoctrineFieldReader::object2View() B

↳ Parent: DoctrineFieldReader

Complexity

Conditions	11
Paths	44

Size

Total Lines	36
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	11.393

Importance

Changes

Metric	Value
cc	11
eloc	28
nc	44
nop	3
dl	0
loc	36
ccs	23
cts	27
cp	0.8519
crap	11.393
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Cdf\BiCoreBundle\Utils\Entity;

class DoctrineFieldReader
{

    public $container;
    
    public function __construct($container)
    {
        $this->container = $container;
    }

    public function getField2Object($fieldname, $object, $decodifiche = null)
    {
        $property = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        $field = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        $propertyfound = false;
        //FIXME: TODO:
        $subfields = explode(".", str_replace('__bicorebundle_', "", $fieldname));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        foreach ($subfields as $field) {
            $property = $this->getObjectProperty($field, $object);
            if ($property) {
                $object = $object->$property();
$a = "a";
$ab = "ab";
$abc = "abc";
                $propertyfound = true;
            }
        }
        if (!$propertyfound) {
            throw new \Exception("Proprietà " . $field . " non trovata per " . $fieldname);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        if ($decodifiche) {
            if (key_exists($object, $decodifiche)) {
                $object = $decodifiche[$object];
            }
        }
        return $object;
    }

    public function object2View($object, $type = null, $decodifiche = null)
    {
        $risposta = null;

        if ($decodifiche) {
            $type = "string";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        if (!is_null($object)) {
            if ($type === null) {
                $tipo = is_object($object) ?
                        get_class($object) :
                        gettype($object);
            } else {
                $tipo = $type;
            }
            switch (strtolower($tipo)) {
                case 'array':
                    $risposta = print_r($object, true);
                    break;
                case 'date':
                    $risposta = $object->format("d/m/Y");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    break;
                case 'datetime':
                    $risposta = $object->format("d/m/Y H:i");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    break;
                case 'boolean':
                    $risposta = $object ? "SI" : "NO";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    break;
                case 'string':
                default:
                    $risposta = $object;
                    break;
            }
        }
        return $risposta;
    }

    private function getObjectProperty($field, $object)
    {
        $property = "get" . ucfirst($field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if (method_exists($object, $property)) {
            return $property;
        }
        $property = "is" . ucfirst($field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if (method_exists($object, $property)) {
            return $property;
        }
        $property = "has" . ucfirst($field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if (method_exists($object, $property)) {
            return $property;
        }
    }
}


1		<?php
2
3		namespace Cdf\BiCoreBundle\Utils\Entity;
4
5		class DoctrineFieldReader
6		{
7
8		public $container;
9
10	7	public function __construct($container)
11		{
12	7	$this->container = $container;
13	7	}
14
15	7	public function getField2Object($fieldname, $object, $decodifiche = null)
16		{
17	7	$property = "";
		0 ignored issues – show Unused Code introduced 2018-11-19 16:37 UTC by Report Bug Copy Issue Report The assignment to `$property` is dead and can be removed. Loading history... Coding Style introduced 2018-11-19 16:37 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-19 16:37 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
18	7	$field = "";
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19	7	$propertyfound = false;
20		//FIXME: TODO:
21	7	$subfields = explode(".", str_replace('__bicorebundle_', "", $fieldname));
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-30 00:35 UTC by Report Bug Copy Issue Report The string literal `.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-30 00:35 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
22	7	foreach ($subfields as $field) {
23	7	$property = $this->getObjectProperty($field, $object);
24	7	if ($property) {
25	7	$object = $object->$property();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26	7	$propertyfound = true;
27		}
28		}
29	7	if (!$propertyfound) {
30		throw new \Exception("Proprietà " . $field . " non trovata per " . $fieldname);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `Proprietà` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `non trovata per` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
31		}
32	7	if ($decodifiche) {
33		if (key_exists($object, $decodifiche)) {
34		$object = $decodifiche[$object];
35		}

ComuneFI / BiCoreBundle

Push — develop ( 3e7b2f...75e02f )

DoctrineFieldReader::object2View() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like