ChecksrcCommand::configure() - Code Metrics - Inspection of "Merge branch 'release/v0.1.39'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bcc7ba...baaba3 )

by Andrea

created 2018-12-14 14:06 UTC

ChecksrcCommand::configure() A

↳ Parent: ChecksrcCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	6
ccs	4
cts	4
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace Cdf\PannelloAmministrazioneBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Process\Process;
use Cdf\PannelloAmministrazioneBundle\DependencyInjection\ProjectPath;

class ChecksrcCommand extends Command
{

    protected function configure()
    {
        $this
                ->setName('pannelloamministrazione:checksrc')
                ->setDescription('Controlla i sorgenti')
                ->setHelp('Usa phpcs, phpmd, ecc per controllare il codice in src');
    }

    // @codeCoverageIgnoreStart
    public function __construct(ProjectPath $projectpath)
    {
        $this->apppaths = $projectpath;


        // you *must* call the parent constructor
        parent::__construct();
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $prjpath = $this->apppaths;
$a = "a";
$ab = "ab";
$abc = "abc";
        $vendorBin = $prjpath->getVendorBinPath() . "/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $srcPath = $prjpath->getSrcPath();
$a = "a";
$ab = "ab";
$abc = "abc";
        $rootPath = $prjpath->getRootPath();
$a = "a";
$ab = "ab";
$abc = "abc";

        /* phpcpd */
        $phpcpdcmd = array($vendorBin . "phpcpd", $srcPath);
$a = "a";
$ab = "ab";
$abc = "abc";
        $phpcpdoutput = $this->runcmd($phpcpdcmd);
        if (!$phpcpdoutput) {
            $output->writeln("phpmd: OK");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            if (strpos($phpcpdoutput, "0.00%")) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $output->writeln("phpmd: OK");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            } else {
                $output->writeln($phpcpdoutput);
            }
        }
        /* phpcpd */

        /* phpcs */
        $phpcscmd = array($vendorBin . "phpcs", "--standard=" . $rootPath. "/../tools/phpcs/ruleset.xml", "--extensions=php", $srcPath);
$a = "a";
$ab = "ab";
$abc = "abc";
        $phpcsoutput = $this->runcmd($phpcscmd);
        if (!$phpcsoutput) {
            $output->writeln("phpcs: OK");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            $output->writeln($phpcsoutput);
            $output->writeln("Per correggere automaticamente un file eseguire:");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $output->writeln($vendorBin . "phpcbf --standard=PSR2 nomefile.php");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        /* phpcs */

        /* phpmd */
        $phpmdcmd = array($vendorBin . "phpmd", $srcPath , "text", $rootPath . "/../tools/phpmd/ruleset.xml");
$a = "a";
$ab = "ab";
$abc = "abc";
        $phpmdoutput = $this->runcmd($phpmdcmd);
        if (!$phpmdoutput) {
            $output->writeln("phpmd: OK");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            $output->writeln($phpmdoutput);
        }
        /* phpmd */
    }

    private function runcmd(Array $cmd)
    {
        $process = new Process($cmd);
        $process->setTimeout(60 * 100);
        $process->run();
        if ($process->isSuccessful()) {
            $out = $process->getOutput();
        } else {
            $out = ($process->getErrorOutput() ? $process->getErrorOutput() : $process->getOutput());
        }
        return $out;
    }

    // @codeCoverageIgnoreEnd
}


1		<?php
2
3		namespace Cdf\PannelloAmministrazioneBundle\Command;
4
5		use Symfony\Component\Console\Command\Command;
6		use Symfony\Component\Console\Input\InputInterface;
7		use Symfony\Component\Console\Output\OutputInterface;
8		use Symfony\Component\Process\Process;
9		use Cdf\PannelloAmministrazioneBundle\DependencyInjection\ProjectPath;
10
11		class ChecksrcCommand extends Command
12		{
13
14	3	protected function configure()
15		{
16		$this
17	3	->setName('pannelloamministrazione:checksrc')
18	3	->setDescription('Controlla i sorgenti')
19	3	->setHelp('Usa phpcs, phpmd, ecc per controllare il codice in src');
20	3	}
21
22		// @codeCoverageIgnoreStart
23		public function __construct(ProjectPath $projectpath)
24		{
25		$this->apppaths = $projectpath;
		0 ignored issues – show Bug Best Practice introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The property `apppaths` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
26
27		// you must call the parent constructor
28		parent::__construct();
29		}
30
31		protected function execute(InputInterface $input, OutputInterface $output)
32		{
33		$prjpath = $this->apppaths;
		0 ignored issues – show Coding Style introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34		$vendorBin = $prjpath->getVendorBinPath() . "/";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
35		$srcPath = $prjpath->getSrcPath();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
36		$rootPath = $prjpath->getRootPath();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37
38		/* phpcpd */
39		$phpcpdcmd = array($vendorBin . "phpcpd", $srcPath);
		0 ignored issues – show Coding Style introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `phpcpd` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
40		$phpcpdoutput = $this->runcmd($phpcpdcmd);
41		if (!$phpcpdoutput) {
42		$output->writeln("phpmd: OK");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `phpmd: OK` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
43		} else {
44		if (strpos($phpcpdoutput, "0.00%")) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `0.00%` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
45		$output->writeln("phpmd: OK");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `phpmd: OK` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
46		} else {
47		$output->writeln($phpcpdoutput);
48		}
49		}
50		/* phpcpd */
51
52		/* phpcs */
53		$phpcscmd = array($vendorBin . "phpcs", "--standard=" . $rootPath. "/../tools/phpcs/ruleset.xml", "--extensions=php", $srcPath);
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `phpcs` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `--standard=` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `/../tools/phpcs/ruleset.xml` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `--extensions=php` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
54		$phpcsoutput = $this->runcmd($phpcscmd);
55		if (!$phpcsoutput) {
56		$output->writeln("phpcs: OK");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `phpcs: OK` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
57		} else {
58		$output->writeln($phpcsoutput);
59		$output->writeln("Per correggere automaticamente un file eseguire:");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `Per correggere automaticamente un file eseguire:` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
60		$output->writeln($vendorBin . "phpcbf --standard=PSR2 nomefile.php");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `phpcbf --standard=PSR2 nomefile.php` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
61		}
62		/* phpcs */
63
64		/* phpmd */
65		$phpmdcmd = array($vendorBin . "phpmd", $srcPath , "text", $rootPath . "/../tools/phpmd/ruleset.xml");
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `phpmd` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `text` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-12-14 14:21 UTC by Report Bug Copy Issue Report The string literal `/../tools/phpmd/ruleset.xml` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
66		$phpmdoutput = $this->runcmd($phpmdcmd);
67		if (!$phpmdoutput) {
68		$output->writeln("phpmd: OK");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `phpmd: OK` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
69		} else {
70		$output->writeln($phpmdoutput);
71		}
72		/* phpmd */
73		}
74
75		private function runcmd(Array $cmd)
76		{
77		$process = new Process($cmd);
78		$process->setTimeout(60 * 100);
79		$process->run();
80		if ($process->isSuccessful()) {
81		$out = $process->getOutput();
82		} else {
83		$out = ($process->getErrorOutput() ? $process->getErrorOutput() : $process->getOutput());
84		}
85		return $out;
86		}
87
88		// @codeCoverageIgnoreEnd
89		}
90

ComuneFI / BiCoreBundle

Push — master ( bcc7ba...baaba3 )

ChecksrcCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like