FiApiCoreControllerTrait::index() - Code Metrics - Inspection of "Merge branch 'release/2.0.0'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( a74354...254a60 )

by Andrea
created 2020-09-11 08:53 UTC
FiApiCoreControllerTrait::index() A

↳ Parent: FiApiCoreControllerTrait
Complexity

Conditions	2
Paths	2
Size

Total Lines	81
Code Lines	41
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	6
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	2
eloc	41
nc	2
nop	2
dl	0
loc	81
ccs	0
cts	42
cp	0
crap	6
rs	9.264
c	1
b	0
f	0
How to fix Long Method

<?php

namespace Cdf\BiCoreBundle\Controller;

use Cdf\BiCoreBundle\Utils\Arrays\ArrayUtils;
use Cdf\BiCoreBundle\Utils\Entity\EntityUtils;
use Cdf\BiCoreBundle\Utils\Entity\Finder;
use Cdf\BiCoreBundle\Utils\Tabella\ParametriTabella;
use Symfony\Component\Asset\Packages;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

trait FiApiCoreControllerTrait
{


    /**
     * Lists all tables entities.
     */
    public function index(Request $request, Packages $assetsmanager)
    {
        $bundle = $this->getBundle();
        $bundle = $this->getBundle();
        $controller = $this->getController();
        $controller = $this->getController();
        $idpassato = $request->get('id');

        if (!$this->getPermessi()->canRead($this->getController())) {
        if (!$this->/** @scrutinizer ignore-call */ getPermessi()->canRead($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per visualizzare questo contenuto');
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());

        //$entityclassnotation = $this->getEntityClassNotation();
        //$entityclass = $this->getEntityClassName();

        $entityclassnotation = 'App:'.$this->model;
        // Variable containing API controller

        $modellocolonne = [
                /*
                  $controller . ".nominativo" => array(
                  "nometabella" => $controller,
                  "nomecampo" => "nominativo",
                  "etichetta" => "Nominativo",
                  "ordine" => 10,
                  "larghezza" => 200,
                  "escluso" => false
                  ),
                  $controller . ".datanascita" => array(
                  "nometabella" => $controller,
                  "nomecampo" => "datanascita",
                  "etichetta" => "Data di nascita",
                  "ordine" => 20,
                  "larghezza" => 100,
                  "escluso" => false
                  ),

                 */
        ];

        //append automatic computed enum options
        $modellocolonne = array_merge($modellocolonne, $this->enumOptions);

        //dump($modellocolonne);
        //dump($this->enumOptions);

        $filtri = [];
        $prefiltri = [];
        //$entityutils = new EntityUtils($this->get('doctrine')->getManager());
        //$tablenamefromentity = $entityutils->getTableFromEntity($entityclass);
        $tablenamefromentity = $controller;
        $colonneordinamento = [$tablenamefromentity.'.id' => 'DESC'];
        $parametritabella = ['em' => ParametriTabella::setParameter('default'),
            'tablename' => ParametriTabella::setParameter($tablenamefromentity),
            'nomecontroller' => ParametriTabella::setParameter($controller),
            'bundle' => ParametriTabella::setParameter($bundle),
            'entityname' => ParametriTabella::setParameter($entityclassnotation),
            'entityclass' => ParametriTabella::setParameter($this->controllerItem),
            'formclass' => ParametriTabella::setParameter($this->formClass),
            'modellocolonne' => ParametriTabella::setParameter(json_encode($modellocolonne)),
            'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi()->toJson($controller))),
            'urltabella' => ParametriTabella::setParameter($assetsmanager->getUrl('/').$controller.'/'.'tabella'),
            'baseurl' => ParametriTabella::setParameter($assetsmanager->getUrl('/')),
            'idpassato' => ParametriTabella::setParameter($idpassato),
            'titolotabella' => ParametriTabella::setParameter('Elenco '.$controller),
            'multiselezione' => ParametriTabella::setParameter('0'),
            'editinline' => ParametriTabella::setParameter('0'),
            'paginacorrente' => ParametriTabella::setParameter('1'),
            'paginetotali' => ParametriTabella::setParameter(''),
            'righetotali' => ParametriTabella::setParameter('0'),
            'righeperpagina' => ParametriTabella::setParameter('15'),
            'estraituttirecords' => ParametriTabella::setParameter('0'),
            'colonneordinamento' => ParametriTabella::setParameter(json_encode($colonneordinamento)),
            'filtri' => ParametriTabella::setParameter(json_encode($filtri)),
            'prefiltri' => ParametriTabella::setParameter(json_encode($prefiltri)),
            'traduzionefiltri' => ParametriTabella::setParameter(''),
            'isApi' => ParametriTabella::setParameter('1'),
            'apicontroller' => ParametriTabella::setParameter($this->apiController),
            'apicollection' => ParametriTabella::setParameter($this->collection)
        ];

        return $this->render($crudtemplate, ['parametritabella' => $parametritabella]);
        return $this->/** @scrutinizer ignore-call */ render($crudtemplate, ['parametritabella' => $parametritabella]);
    }

    /**
     * Lists all tables entities.
     */
  /*  public function indexDettaglio(Request $request, Packages $assetsmanager)
    {
        if (!$this->getPermessi()->canRead($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per visualizzare questo contenuto');
        }

        $bundle = $this->getBundle();
        $controller = $this->getController();
        $parametripassati = json_decode($request->get('parametripassati'), true);

        $filtri = $this->getParametroIndexDettaglio($parametripassati, 'filtri', []);
        $prefiltri = $this->getParametroIndexDettaglio($parametripassati, 'prefiltri', []);
        $titolotabella = $this->getParametroIndexDettaglio($parametripassati, 'titolotabella', 'Elenco '.$controller);
        $modellocolonne = $this->getParametroIndexDettaglio($parametripassati, 'modellocolonne', []);
        $colonneordinamento = $this->getParametroIndexDettaglio($parametripassati, 'colonneordinamento', []);
        $multiselezione = $this->getParametroIndexDettaglio($parametripassati, 'multiselezione', 0);
        $parametriform = $this->getParametroIndexDettaglio($parametripassati, 'parametriform', []);

        $template = $bundle.':'.$controller.':'.$this->getThisFunctionName().'.html.twig';
        if (!$this->get('twig')->getLoader()->exists($template)) {
            $template = $controller.'/Crud/'.$this->getThisFunctionName().'.html.twig';
        }

        $entityclassnotation = $this->getEntityClassNotation();
        $entityclass = $this->getEntityClassName();

        $formclass = str_replace('Entity', 'Form', $entityclass);

        $entityutils = new EntityUtils($this->get('doctrine')->getManager());

        $tablenamefromentity = $entityutils->getTableFromEntity($entityclass);
        $parametritabella = ['em' => ParametriTabella::setParameter('default'),
            'tablename' => ParametriTabella::setParameter($tablenamefromentity),
            'nomecontroller' => ParametriTabella::setParameter($controller),
            'bundle' => ParametriTabella::setParameter($bundle),
            'entityname' => ParametriTabella::setParameter($entityclassnotation),
            'entityclass' => ParametriTabella::setParameter($entityclass),
            'formclass' => ParametriTabella::setParameter($formclass),
            'parametriform' => ParametriTabella::setParameter(json_encode($parametriform)),
            'modellocolonne' => ParametriTabella::setParameter(json_encode($modellocolonne)),
            'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi()->toJson($controller))),
            'urltabella' => ParametriTabella::setParameter($assetsmanager->getUrl('/').$controller.'/'.'tabella'),
            'baseurl' => ParametriTabella::setParameter($assetsmanager->getUrl('/')),
            'idpassato' => ParametriTabella::setParameter(0),
            'titolotabella' => ParametriTabella::setParameter($titolotabella),
            'multiselezione' => ParametriTabella::setParameter($multiselezione),
            'editinline' => ParametriTabella::setParameter('1'),
            'paginacorrente' => ParametriTabella::setParameter('1'),
            'paginetotali' => ParametriTabella::setParameter(''),
            'righeperpagina' => ParametriTabella::setParameter('15'),
            'colonneordinamento' => ParametriTabella::setParameter(json_encode($colonneordinamento)),
            'filtri' => ParametriTabella::setParameter(json_encode($filtri)),
            'prefiltri' => ParametriTabella::setParameter(json_encode($prefiltri)),
            'traduzionefiltri' => ParametriTabella::setParameter(''),
        ];

        return $this->render(
            $template,
            [
                            'parametritabella' => $parametritabella,
                        ]
        );
    }*/

  /*  protected function getParametroIndexDettaglio($parametripassati, $keyparametro, $defaultvalue)
    {
        if (isset($parametripassati[$keyparametro])) {
            $parametro = $parametripassati[$keyparametro];
        } else {
            $parametro = $defaultvalue;
        }

        return $parametro;
    }*/

    /**
     * Lists all tables entities.
     */
  /*  public function lista(Request $request)
    {
        if (!$this->getPermessi()->canRead($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per visualizzare questo contenuto');
        }

        $entityclassnotation = $this->getEntityClassNotation();
        $em = $this->get('doctrine')->getManager();
        $righe = $em->getRepository($entityclassnotation)->findAll();

        $lista = [];
        foreach ($righe as $riga) {
            $lista[] = ['id' => $riga->getId(), 'descrizione' => $riga->__toString()];
        }

        return new JsonResponse(ArrayUtils::arrayOrderby($lista, 'descrizione', SORT_ASC));
    }*/

    protected function getTabellaTemplate($controller)
    {
        $tabellatemplate = $controller.'/Tabella/tabellaform.html.twig';
        if (!$this->get('twig')->getLoader()->exists($tabellatemplate)) {
        if (!$this->/** @scrutinizer ignore-call */ get('twig')->getLoader()->exists($tabellatemplate)) {
            $tabellatemplate = '@BiCore/'.$controller.'/Tabella/tabellaform.html.twig';
            if (!$this->get('twig')->getLoader()->exists($tabellatemplate)) {
                $tabellatemplate = '@BiCore/Standard/Tabella/tabellaform.html.twig';
            }
        }

        return $tabellatemplate;
    }

    protected function getCrudTemplate($bundle, $controller, $operation)
    {
        $crudtemplate = $bundle.'/'.$controller.'/Crud/'.$operation.'.html.twig';
        if (!$this->get('twig')->getLoader()->exists($crudtemplate)) {
            $crudtemplate = $controller.'/Crud/'.$operation.'.html.twig';
            if (!$this->get('twig')->getLoader()->exists($crudtemplate)) {
                $crudtemplate = '@BiCore/Standard/Crud/'.$operation.'.html.twig';
            }
        }

        return $crudtemplate;
    }

    /**
     * Returns the calling function through a backtrace.
     */
    protected function getThisFunctionName()
    {
        // a funciton x has called a function y which called this
        // see stackoverflow.com/questions/190421
        $caller = debug_backtrace();
        $caller = $caller[1];

        return $caller['function'];
    }

    /**
     * Return the model class name needed to instantiate it
     */
    protected function getModelClassName(): String
    {
        return $this->modelClass;
    }

    /**
     * Return the controller item class name needed to instantiate it
     */
    protected function getControllerItemName(): String
    {
        return $this->controllerItem;
    }

    /**
     * Return the form class name needed to reference the proper form
     */
    protected function getFormName(): String
    {
        return $this->formClass;
    }

       /* protected function getEntityClassNotation()
    {
        $em = $this->get('doctrine')->getManager();
        $entityutils = new EntityUtils($em);

        return $entityutils->getClassNameToShortcutNotations($this->getEntityClassName());
    }*/

   /* protected function getEntityClassName()
    {
        $em = $this->get('doctrine')->getManager();
        $entityfinder = new Finder($em);

        return $entityfinder->getClassNameFromEntityName($this->controller);
    }*/
}

ComuneFI / BiCoreBundle

Push — master ( a74354...254a60 )

FiApiCoreControllerTrait::index() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
