ComuneFI /
BiCoreBundle
| Conditions | 3 |
| Paths | 3 |
| Total Lines | 74 |
| Code Lines | 59 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 57 |
| CRAP Score | 3 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | 1 | public function index(Request $request, Packages $assetsmanager) |
|
| 21 | { |
||
| 22 | 1 | $bundle = $this->getBundle(); |
|
| 23 | 1 | $controller = $this->getController(); |
|
| 24 | 1 | $idpassato = $request->get('id'); |
|
| 25 | |||
| 26 | 1 | if (!$this->getPermessi()->canRead($this->getController())) { |
|
| 27 | throw new AccessDeniedException('Non si hanno i permessi per visualizzare questo contenuto'); |
||
| 28 | } |
||
| 29 | 1 | $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName()); |
|
| 30 | |||
| 31 | 1 | $entityclassnotation = $this->getEntityClassNotation(); |
|
| 32 | 1 | $entityclass = $this->getEntityClassName(); |
|
| 33 | |||
| 34 | 1 | $formclass = str_replace('Entity', 'Form', $entityclass); |
|
| 35 | |||
| 36 | 1 | $em = $this->getDoctrine()->getManager(); |
|
| 37 | 1 | $query = $em->createQueryBuilder() |
|
|
Bug
introduced
by
|
|||
| 38 | 1 | ->select('o') |
|
| 39 | 1 | ->from('BiCoreBundle:Menuapplicazione', 'o') |
|
| 40 | 1 | ->getQuery() |
|
| 41 | ; |
||
| 42 | 1 | $menuobj = $query->getResult(); |
|
| 43 | 1 | $menus = []; |
|
| 44 | 1 | foreach ($menuobj as $menu) { |
|
| 45 | 1 | $menus[$menu->getId()] = $menu->getNome(); |
|
| 46 | } |
||
| 47 | |||
| 48 | $modellocolonne = array( |
||
| 49 | 1 | array('nometabella' => $controller, |
|
| 50 | 1 | 'nomecampo' => "__bicorebundle_Menuapplicazione.id", |
|
| 51 | 1 | 'etichetta' => 'Id', |
|
| 52 | 1 | 'ordine' => 0, |
|
| 53 | 1 | 'larghezza' => 10, |
|
| 54 | 'escluso' => true), |
||
| 55 | 1 | array('nometabella' => $controller, 'nomecampo' => |
|
| 56 | 1 | "__bicorebundle_Menuapplicazione.padre", 'etichetta' => 'Padre', |
|
| 57 | 1 | 'ordine' => 10, 'larghezza' => 10, 'escluso' => false, |
|
| 58 | 1 | 'decodifiche' => $menus, |
|
| 59 | ), |
||
| 60 | ); |
||
| 61 | |||
| 62 | 1 | $filtri = []; |
|
| 63 | 1 | $prefiltri = []; |
|
| 64 | 1 | $entityutils = new EntityUtils($this->get('doctrine')->getManager()); |
|
| 65 | 1 | $tablenamefromentity = $entityutils->getTableFromEntity($entityclass); |
|
| 66 | 1 | $colonneordinamento = [$tablenamefromentity . '.id' => 'DESC']; |
|
| 67 | 1 | $parametritabella = ['em' => ParametriTabella::setParameter('default'), |
|
| 68 | 1 | 'tablename' => ParametriTabella::setParameter($tablenamefromentity), |
|
| 69 | 1 | 'nomecontroller' => ParametriTabella::setParameter($controller), |
|
| 70 | 1 | 'bundle' => ParametriTabella::setParameter($bundle), |
|
| 71 | 1 | 'entityname' => ParametriTabella::setParameter($entityclassnotation), |
|
| 72 | 1 | 'entityclass' => ParametriTabella::setParameter($entityclass), |
|
| 73 | 1 | 'formclass' => ParametriTabella::setParameter($formclass), |
|
| 74 | 1 | 'modellocolonne' => ParametriTabella::setParameter(json_encode($modellocolonne)), |
|
| 75 | 1 | 'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi()->toJson($controller))), |
|
| 76 | 1 | 'urltabella' => ParametriTabella::setParameter($assetsmanager->getUrl('') . $controller . '/' . 'tabella'), |
|
| 77 | 1 | 'baseurl' => ParametriTabella::setParameter($assetsmanager->getUrl('')), |
|
| 78 | 1 | 'idpassato' => ParametriTabella::setParameter($idpassato), |
|
| 79 | 1 | 'titolotabella' => ParametriTabella::setParameter('Elenco ' . $controller), |
|
| 80 | 1 | 'multiselezione' => ParametriTabella::setParameter('0'), |
|
| 81 | 1 | 'editinline' => ParametriTabella::setParameter('0'), |
|
| 82 | 1 | 'paginacorrente' => ParametriTabella::setParameter('1'), |
|
| 83 | 1 | 'paginetotali' => ParametriTabella::setParameter(''), |
|
| 84 | 1 | 'righetotali' => ParametriTabella::setParameter('0'), |
|
| 85 | 1 | 'righeperpagina' => ParametriTabella::setParameter('15'), |
|
| 86 | 1 | 'estraituttirecords' => ParametriTabella::setParameter('0'), |
|
| 87 | 1 | 'colonneordinamento' => ParametriTabella::setParameter(json_encode($colonneordinamento)), |
|
| 88 | 1 | 'filtri' => ParametriTabella::setParameter(json_encode($filtri)), |
|
| 89 | 1 | 'prefiltri' => ParametriTabella::setParameter(json_encode($prefiltri)), |
|
| 90 | 1 | 'traduzionefiltri' => ParametriTabella::setParameter(''), |
|
| 91 | ]; |
||
| 92 | |||
| 93 | 1 | return $this->render($crudtemplate, ['parametritabella' => $parametritabella]); |
|
| 94 | } |
||
| 96 |
Loading history...