Cdf\BiCoreBundle\Utils\Database\DatabaseUtils

Complexity

Total Complexity

27

Size/Duplication

Total Lines	124
Duplicated Lines	0 %

Test Coverage

Coverage

86.49%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	isDateChanged()	0	15	7
B	isArrayChanged()	0	13	7
A	truncateTable()	0	31	5
A	isRecordChanged()	0	14	5
A	__construct()	0	4	1
A	getFieldType()	0	8	1
A	isSchemaChanged()	0	21	1

<?php

namespace Cdf\BiCoreBundle\Utils\Database;

use DateTime;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityManager;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;
use function count;

class DatabaseUtils
{
    /* @var $em EntityManager */

The doc comment $em at position 0 could not be parsed: Unknown type name '$em' at position 0 in $em.

    private $em;
    private $kernel;

    public function __construct($kernel, EntityManagerInterface $em)
    {
        $this->kernel = $kernel;
        $this->em = $em;
    }

    public function getFieldType($entity, $field)
    {
        $metadata = $this->em->getClassMetadata(get_class($entity));
        $fieldMetadata = $metadata->fieldMappings[$field];

Accessing fieldMappings on the interface Doctrine\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

        $fieldType = $fieldMetadata['type'];

        return $fieldType;
    }

    public function isRecordChanged($entity, $fieldname, $oldvalue, $newvalue)
    {
        $fieldtype = $this->getFieldType(new $entity(), $fieldname);
        if ('boolean' === $fieldtype) {
            return $oldvalue !== $newvalue;
        }
        if ('datetime' === $fieldtype || 'date' === $fieldtype) {
            return $this->isDateChanged($oldvalue, $newvalue);
        }
        if (is_array($oldvalue)) {
            return $this->isArrayChanged($oldvalue, $newvalue);
        }

        return $oldvalue !== $newvalue;
    }

    public function isDateChanged($oldvalue, $newvalue)
    {
        $datenewvalue = new DateTime();
        $datenewvalue->setTimestamp($newvalue);
        $twoboth = !$oldvalue && !$newvalue;
        if ($twoboth) {
            return false;
        }
        $onlyonenull = (!$oldvalue && $newvalue) || ($oldvalue && !$newvalue);

Consider adding parentheses for clarity. Current Interpretation: $onlyonenull = (! $oldvalue && $newvalue || $oldvalue && ! $newvalue), Probably Intended Meaning: $onlyonenull = ! $oldvalue && ($newvalue || $oldvalue && ! $newvalue)

        if ($onlyonenull) {
            return true;
        }
        $changed = ($oldvalue != $datenewvalue);

        return $changed;
    }

    public function isArrayChanged($oldvalue, $newvalue)
    {
        $twoboth = !$oldvalue && !$newvalue;
        if ($twoboth) {
            return false;
        }
        $onlyonenull = (!$oldvalue && $newvalue) || ($oldvalue && !$newvalue);

Consider adding parentheses for clarity. Current Interpretation: $onlyonenull = (! $oldvalue && $newvalue || $oldvalue && ! $newvalue), Probably Intended Meaning: $onlyonenull = ! $oldvalue && ($newvalue || $oldvalue && ! $newvalue)

        if ($onlyonenull) {
            return true;
        }
        $numdiff = array_diff($oldvalue, $newvalue);

        return count($numdiff) > 0;
    }

    public function truncateTable($entityclass, $cascade = false)
    {
        $cmd = $this->em->getClassMetadata($entityclass);
        $connection = $this->em->getConnection();
        $dbPlatform = $connection->getDatabasePlatform();
        $dbtype = $connection->getDriver()->getDatabasePlatform()->getName();
        $retval = false;

        switch ($dbtype) {
            case 'mysql':
                $connection->query('SET FOREIGN_KEY_CHECKS=0');
                $q = $dbPlatform->getTruncateTableSql($cmd->getTableName(), $cascade);
                $retval = $connection->executeUpdate($q);
                $connection->query('SET FOREIGN_KEY_CHECKS=1');
                break;
            case 'postgresql':
                $cascadesql = $cascade ? 'CASCADE' : '';
                $tablename = $cmd->getTableName();
                if ($cmd->getSchemaName()) {
                    $tablename = $cmd->getSchemaName().'.'.$tablename;
                }
                $retval = $connection->executeQuery(sprintf('TRUNCATE TABLE %s '.$cascadesql, $tablename));
                break;
            default:
                $q = $dbPlatform->getTruncateTableSql($cmd->getTableName(), $cascade);
                $retval = $connection->executeUpdate($q);
                break;
        }
        $this->em->clear();

        return $retval;
    }

    public function isSchemaChanged()
    {
        $application = new Application($this->kernel);
        $application->setAutoExit(false);

        $input = new ArrayInput(array(
            'command' => 'doctrine:schema:update',
            '--dump-sql' => true,
            '--no-debug' => true,
            '--env' => $this->kernel->getEnvironment(),
        ));

        // You can use NullOutput() if you don't need the output
        $output = new BufferedOutput();
        $application->run($input, $output);

        // return the output, don't use if you used NullOutput()
        $content = $output->fetch();
        $changed = strpos($content, 'Nothing to update');

        return 0 !== $changed;
    }
}