Commands::checkFormCrud() - Code Metrics - Inspection of "Merge branch 'release/v0.1.40'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5e8bf6...1d619d )

by Andrea

created 2018-12-15 10:59 UTC

Commands::checkFormCrud() A

↳ Parent: Commands

Complexity

Conditions	6
Paths	6

Size

Total Lines	34
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	6.3357

Importance

Changes

Metric	Value
cc	6
eloc	18
nc	6
nop	1
dl	0
loc	34
ccs	15
cts	19
cp	0.7895
crap	6.3357
rs	9.0444
c	0
b	0
f	0

<?php

namespace Cdf\PannelloAmministrazioneBundle\Utils;

use Symfony\Component\Filesystem\Filesystem;
use Fi\OsBundle\DependencyInjection\OsFunctions;
use Cdf\PannelloAmministrazioneBundle\Utils\ProjectPath;
use Cdf\PannelloAmministrazioneBundle\Utils\Utility;

class Commands
{

    /* @var $apppaths \Cdf\PannelloAmministrazioneBundle\Utils\ProjectPath */

    private $apppaths;
    /* @var $pammutils \Cdf\PannelloAmministrazioneBundle\Utils\Utility */

    private $pammutils;

    public function __construct(ProjectPath $projectpath, Utility $pautils)
    {
        $this->apppaths = $projectpath;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->pammutils = $pautils;
    }


    // @codeCoverageIgnoreStart
    public function getVcs()
    {
        $fs = new Filesystem();

        $sepchr = OsFunctions::getSeparator();
$a = "a";
$ab = "ab";
$abc = "abc";
        $projectDir = $this->apppaths->getRootPath();
        $vcscommand = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.svn')) {
            $vcscommand = 'svn update';
        }
        if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.git')) {
            $vcscommand = 'git pull';
        }
        if (!$vcscommand) {
            throw new \Exception("Vcs non trovato", 100);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $command = 'cd ' . $projectDir . $sepchr . $vcscommand;
        return $this->pammutils->runCommand($command);
    }

    // @codeCoverageIgnoreEnd
    public function generateEntity($wbFile)
    {
        $command = "pannelloamministrazione:generateormentities";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $result = $this->pammutils->runSymfonyCommand($command, array('mwbfile' => $wbFile));
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($result["errcode"] != 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return array(
                'errcode' => -1,
                'command' => $command,
                'message' => 'Errore nel comando:' . $command . ';' . $result["message"],
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            );
        }

        return array(
            'errcode' => 0,
            'command' => $command,
            'message' => 'Eseguito comando:' . $command . ';' . $result["message"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    public function generateFormCrud($entityform, $generatemplate)
    {
        /* @var $fs \Symfony\Component\Filesystem\Filesystem */
        $resultchk = $this->checkFormCrud($entityform);

        if ($resultchk["errcode"] !== 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return $resultchk;
        }
        $formcrudparms = array("entityform" => $entityform, "--generatemplate" => $generatemplate);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $retmsggenerateform = $this->pammutils->runSymfonyCommand('pannelloamministrazione:generateformcrud', $formcrudparms);

        $retmsg = array(
            'errcode' => $retmsggenerateform['errcode'],
            'command' => $retmsggenerateform['command'],
            'message' => $retmsggenerateform['message'],
        );

        return $retmsg;
    }

    public function checkFormCrud($entityform)
    {
        /* @var $fs \Symfony\Component\Filesystem\Filesystem */
        $fs = new Filesystem();
$a = "a";
$ab = "ab";
$abc = "abc";
        $srcPath = $this->apppaths->getSrcPath();
        $appPath = $srcPath;
        if (!is_writable($appPath)) {
            return array('errcode' => -1, 'message' => $appPath . ' non scrivibile');
        }
        $formPath = $appPath . '/Form/' . $entityform . 'Type.php';

        $entityPath = $appPath . '/Entity' . DIRECTORY_SEPARATOR . $entityform . '.php';

        if (!$fs->exists($entityPath)) {
            return array('errcode' => -1, 'message' => $entityPath . ' entity non trovata');
        }

        if ($fs->exists($formPath)) {
            return array('errcode' => -1, 'message' => $formPath . ' esistente');
        }

        $controllerPath = $appPath . '/Controller' . DIRECTORY_SEPARATOR . $entityform . 'Controller.php';

        if ($fs->exists($controllerPath)) {
            return array('errcode' => -1, 'message' => $controllerPath . ' esistente');
        }

        $viewPathSrc = $this->apppaths->getTemplatePath() . DIRECTORY_SEPARATOR . $entityform;

        if ($fs->exists($viewPathSrc)) {
            return array('errcode' => -1, 'message' => $viewPathSrc . ' esistente');
        }

        return array('errcode' => 0, 'message' => 'OK');
    }

    public function clearcache()
    {
        $cmdoutput = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $envs = array("dev", "test", "prod");
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($envs as $env) {
            $result = $this->pammutils->clearcache($env);
$a = "a";
$ab = "ab";
$abc = "abc";
            $cmdoutput = $cmdoutput . $result["message"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if ($result["errcode"] !== 0) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                return $result;
            }
            $result["message"] = $cmdoutput;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        return $result;

    }

    public function aggiornaSchemaDatabase()
    {
        $result = $this->pammutils->runSymfonyCommand('doctrine:schema:update', array('--force' => true));

        return $result;
    }
}


1		<?php
2
3		namespace Cdf\PannelloAmministrazioneBundle\Utils;
4
5		use Symfony\Component\Filesystem\Filesystem;
6		use Fi\OsBundle\DependencyInjection\OsFunctions;
7		use Cdf\PannelloAmministrazioneBundle\Utils\ProjectPath;
8		use Cdf\PannelloAmministrazioneBundle\Utils\Utility;
9
10		class Commands
11		{
12
13		/* @var $apppaths \Cdf\PannelloAmministrazioneBundle\Utils\ProjectPath */
		0 ignored issues – show Documentation Bug introduced 2018-12-14 19:43 UTC by Report Bug Copy Issue Report The doc comment `$apppaths` at position `0` could not be parsed: Unknown type name '$apppaths' at position 0 in $apppaths. Loading history...
14		private $apppaths;
15		/* @var $pammutils \Cdf\PannelloAmministrazioneBundle\Utils\Utility */
		0 ignored issues – show Documentation Bug introduced 2018-12-14 19:43 UTC by Report Bug Copy Issue Report The doc comment `$pammutils` at position `0` could not be parsed: Unknown type name '$pammutils' at position 0 in $pammutils. Loading history...
16		private $pammutils;
17
18	1	public function __construct(ProjectPath $projectpath, Utility $pautils)
19		{
20	1	$this->apppaths = $projectpath;
		0 ignored issues – show Coding Style introduced 2018-12-14 18:58 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21	1	$this->pammutils = $pautils;
22	1	}
23
24
25		// @codeCoverageIgnoreStart
26		public function getVcs()
27		{
28		$fs = new Filesystem();
29
30		$sepchr = OsFunctions::getSeparator();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31		$projectDir = $this->apppaths->getRootPath();
32		$vcscommand = "";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
33		if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.svn')) {
34		$vcscommand = 'svn update';
35		}
36		if ($fs->exists($projectDir . DIRECTORY_SEPARATOR . '.git')) {
37		$vcscommand = 'git pull';
38		}
39		if (!$vcscommand) {
40		throw new \Exception("Vcs non trovato", 100);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `Vcs non trovato` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
41		}
42		$command = 'cd ' . $projectDir . $sepchr . $vcscommand;
43		return $this->pammutils->runCommand($command);
44		}
45
46		// @codeCoverageIgnoreEnd
47	1	public function generateEntity($wbFile)
48		{
49	1	$command = "pannelloamministrazione:generateormentities";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione:generateormentities` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
50	1	$result = $this->pammutils->runSymfonyCommand($command, array('mwbfile' => $wbFile));
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
51
52	1	if ($result["errcode"] != 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
53		return array(
54	1	'errcode' => -1,
55	1	'command' => $command,
56	1	'message' => 'Errore nel comando:' . $command . ';' . $result["message"],
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-28 09:34 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
57		);
58		}
59
60		return array(
61	1	'errcode' => 0,
62	1	'command' => $command,
63	1	'message' => 'Eseguito comando:' . $command . ';' . $result["message"]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-28 09:34 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
64		}
65
66	1	public function generateFormCrud($entityform, $generatemplate)
67		{
68		/* @var $fs \Symfony\Component\Filesystem\Filesystem */
69	1	$resultchk = $this->checkFormCrud($entityform);
70
71	1	if ($resultchk["errcode"] !== 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72	1	return $resultchk;
73		}
74	1	$formcrudparms = array("entityform" => $entityform, "--generatemplate" => $generatemplate);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-25 22:10 UTC by Report Bug Copy Issue Report The string literal `entityform` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-25 22:10 UTC by Report Bug Copy Issue Report The string literal `--generatemplate` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
75
76	1	$retmsggenerateform = $this->pammutils->runSymfonyCommand('pannelloamministrazione:generateformcrud', $formcrudparms);
77
78		$retmsg = array(
79	1	'errcode' => $retmsggenerateform['errcode'],
80	1	'command' => $retmsggenerateform['command'],
81	1	'message' => $retmsggenerateform['message'],
82		);
83
84	1	return $retmsg;
85		}
86
87	1	public function checkFormCrud($entityform)
88		{
89		/* @var $fs \Symfony\Component\Filesystem\Filesystem */
90	1	$fs = new Filesystem();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
91	1	$srcPath = $this->apppaths->getSrcPath();
92	1	$appPath = $srcPath;
93	1	if (!is_writable($appPath)) {
94		return array('errcode' => -1, 'message' => $appPath . ' non scrivibile');
95		}
96	1	$formPath = $appPath . '/Form/' . $entityform . 'Type.php';
97
98	1	$entityPath = $appPath . '/Entity' . DIRECTORY_SEPARATOR . $entityform . '.php';
99
100	1	if (!$fs->exists($entityPath)) {
101		return array('errcode' => -1, 'message' => $entityPath . ' entity non trovata');
102		}
103
104	1	if ($fs->exists($formPath)) {
105	1	return array('errcode' => -1, 'message' => $formPath . ' esistente');
106		}
107
108	1	$controllerPath = $appPath . '/Controller' . DIRECTORY_SEPARATOR . $entityform . 'Controller.php';
109
110	1	if ($fs->exists($controllerPath)) {
111		return array('errcode' => -1, 'message' => $controllerPath . ' esistente');
112		}
113
114	1	$viewPathSrc = $this->apppaths->getTemplatePath() . DIRECTORY_SEPARATOR . $entityform;
115
116	1	if ($fs->exists($viewPathSrc)) {
117		return array('errcode' => -1, 'message' => $viewPathSrc . ' esistente');
118		}
119
120	1	return array('errcode' => 0, 'message' => 'OK');
121		}
122
123	1	public function clearcache()
124		{
125	1	$cmdoutput = "";
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
126	1	$envs = array("dev", "test", "prod");
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `dev` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `test` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `prod` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
127	1	foreach ($envs as $env) {
128	1	$result = $this->pammutils->clearcache($env);
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
129	1	$cmdoutput = $cmdoutput . $result["message"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
130	1	if ($result["errcode"] !== 0) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
131		return $result;
132		}
133	1	$result["message"] = $cmdoutput;
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
134		}
135	1	return $result;
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The variable `$result` seems to be defined by a `foreach` iteration on line `127`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
136		}
137
138	1	public function aggiornaSchemaDatabase()
139		{
140	1	$result = $this->pammutils->runSymfonyCommand('doctrine:schema:update', array('--force' => true));
141
142	1	return $result;
143		}
144		}
145

ComuneFI / BiCoreBundle

Push — master ( 5e8bf6...1d619d )

Commands::checkFormCrud() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like